Bug 1746112 - Config-download based deployment fails if a role name starts with a number
Summary: Config-download based deployment fails if a role name starts with a number
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-tripleo-common
Version: 13.0 (Queens)
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: z9
: 13.0 (Queens)
Assignee: Emilien Macchi
QA Contact: Alexander Chuzhoy
URL:
Whiteboard:
Depends On:
Blocks: 1784036 1784041
TreeView+ depends on / blocked
 
Reported: 2019-08-27 17:04 UTC by Sai Sindhur Malleni
Modified: 2020-09-22 10:47 UTC (History)
9 users (show)

Fixed In Version: openstack-tripleo-common-8.6.8-17.el7ost
Doc Type: Enhancement
Doc Text:
With this update, the overcloud role name can now start with a number, for example, `10Controller` or `99Compute`.
Clone Of:
: 1784036 (view as bug list)
Environment:
Last Closed: 2019-11-07 14:01:46 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Launchpad 1842141 0 None None None 2019-08-30 21:14:04 UTC
OpenStack gerrit 679514 0 'None' MERGED config-download: rename pre/post deployment hostvars 2020-11-24 05:28:18 UTC
OpenStack gerrit 679515 0 'None' MERGED Rename pre/post deployments host vars 2020-11-24 05:28:16 UTC
OpenStack gerrit 679516 0 'None' MERGED Clean up host var for pre/post deployment 2020-11-24 05:28:16 UTC
Red Hat Product Errata RHBA-2019:3794 0 None None None 2019-11-07 14:02:01 UTC

Description Sai Sindhur Malleni 2019-08-27 17:04:26 UTC
Description of problem:
If a role name starts with a number, config-download fails.

Name of my role: 1029uCompute
 
2019-08-27 16:41:38,214 p=17220 u=mistral |  TASK [Output for async deployment ControllerArtifactsDeploy] *******************
2019-08-27 16:41:38,214 p=17220 u=mistral |  Tuesday 27 August 2019  16:41:38 +0000 (0:00:00.214)       0:01:47.975 ********
2019-08-27 16:41:38,273 p=17220 u=mistral |  skipping: [overcloud-controller-2] => {}
2019-08-27 16:41:38,326 p=17220 u=mistral |  skipping: [overcloud-controller-1] => {}
2019-08-27 16:41:38,333 p=17220 u=mistral |  skipping: [overcloud-controller-0] => {}
2019-08-27 16:41:38,379 p=17220 u=mistral |  TASK [include] *****************************************************************
2019-08-27 16:41:38,379 p=17220 u=mistral |  Tuesday 27 August 2019  16:41:38 +0000 (0:00:00.164)       0:01:48.140 ********
2019-08-27 16:41:38,610 p=17220 u=mistral |  TASK [include] *****************************************************************
2019-08-27 16:41:38,611 p=17220 u=mistral |  Tuesday 27 August 2019  16:41:38 +0000 (0:00:00.231)       0:01:48.372 ********
2019-08-27 16:41:38,722 p=17220 u=mistral |  fatal: [overcloud-controller-2]: FAILED! => {"msg": "template error while templating string: expected token 'end of print statement', got 'uCompute_pre_deployments'. 
String: {{ 1029uCompute_pre_deployments|default([]) }}"}
2019-08-27 16:41:38,776 p=17220 u=mistral |  fatal: [overcloud-controller-1]: FAILED! => {"msg": "template error while templating string: expected token 'end of print statement', got 'uCompute_pre_deployments'. String: {{ 1029uCompute_pre_deployments|default([]) }}"}
2019-08-27 16:41:38,843 p=17220 u=mistral |  fatal: [overcloud-controller-0]: FAILED! => {"msg": "template error while templating string: expected token 'end of print statement', got 'uCompute_pre_deployments'. String: {{ 1029uCompute_pre_deployments|default([]) }}"}
2019-08-27 16:41:38,852 p=17220 u=mistral |  fatal: [overcloud-r630compute-0]: FAILED! => {"msg": "template error while templating string: expected token 'end of print statement', got 'uCompute_pre_deployments'. String: {{ 1029uCompute_pre_deployments|default([]) }}"}
2019-08-27 16:41:38,852 p=17220 u=mistral |  NO MORE HOSTS LEFT *************************************************************
2019-08-27 16:41:38,853 p=17220 u=mistral |  PLAY RECAP *********************************************************************
2019-08-27 16:41:38,853 p=17220 u=mistral |  overcloud-controller-0     : ok=65   changed=22   unreachable=0    failed=1
2019-08-27 16:41:38,853 p=17220 u=mistral |  overcloud-controller-1     : ok=65   changed=22   unreachable=0    failed=1
2019-08-27 16:41:38,854 p=17220 u=mistral |  overcloud-controller-2     : ok=65   changed=22   unreachable=0    failed=1
2019-08-27 16:41:38,854 p=17220 u=mistral |  overcloud-r630compute-0    : ok=9    changed=6    unreachable=0    failed=1
2019-08-27 16:41:38,854 p=17220 u=mistral |  undercloud                 : ok=2    changed=0    unreachable=0    failed=0
2019-08-27 16:41:38,854 p=17220 u=mistral |  Tuesday 27 August 2019  16:41:38 +0000 (0:00:00.243)       0:01:48.615 ********


Version-Release number of selected component (if applicable):
OSP 13

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Alex Schultz 2019-08-27 18:18:29 UTC
We should document this limitation and also add some validations. This unfortunately will have impact on any folks who already have numbers in their roles and attempt to upgrade past OSP13 without config-download.

Comment 14 Alex McLeod 2019-10-31 11:32:39 UTC
If this bug requires doc text for errata release, please set the 'Doc Type' and provide draft text according to the template in the 'Doc Text' field. The documentation team will review, edit, and approve the text.

If this bug does not require doc text, please set the 'requires_doc_text' flag to -.

Comment 16 errata-xmlrpc 2019-11-07 14:01:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:3794


Note You need to log in before you can comment on or make changes to this bug.