This is a re-review due to the renaming of amavisd-new to amavis Spec URL: https://jorti.fedorapeople.org/amavis/amavis.spec SRPM URL: https://jorti.fedorapeople.org/amavis/amavis-2.12.0-3.fc30.src.rpm Description: amavis is a high-performance and reliable interface between mailer (MTA) and one or more content checkers: virus scanners, and/or Mail::SpamAssassin Perl module. It is written in Perl, assuring high reliability, portability and maintainability. It talks to MTA via (E)SMTP or LMTP, or by using helper programs. No timing gaps exist in the design which could cause a mail loss. Fedora Account System Username: jorti
Here is a successful koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=37662683
Hello Juan, Please check the following error and warning messages by rpmlint on amavis-2.12.0-3.fc31.noarch.rpm. 1. E: dir-or-file-in-var-run A file in the package is located in /var/run. /var/run is a legacy symlink to /run in Fedora. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_run 2. E: non-standard-dir-perm I found non-standard-dir-perm errors are ignored in the amavis-new package review[1] because they are safe to be ignored. Please fix the non-standard-dir-perm errors if you could. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions 3. warnings I found warnings are ignored in the amavis-new package review[1] because they are safe to be ignored. Please fix the warnings if you could. [1] https://bugzilla.redhat.com/show_bug.cgi?id=167354 Appendix: output of rpmlint ``` $ rpmlint ~/rpmbuild/RPMS/noarch/amavis-2.12.0-3.fc31.noarch.rpm amavis.noarch: W: spelling-error Summary(en_US) spamassassin -> spam assassin, spam-assassin, assassin amavis.noarch: W: spelling-error %description -l en_US SpamAssassin -> Spam Assassin, Spam-assassin, Assassin amavis.noarch: W: obsolete-not-provided amavisd-new-snmp-zeromq amavis.noarch: W: obsolete-not-provided amavisd-new-zeromq amavis.noarch: W: no-documentation amavis.noarch: W: non-standard-uid /var/run/amavisd amavis amavis.noarch: W: non-standard-gid /var/run/amavisd amavis amavis.noarch: E: dir-or-file-in-var-run /var/run/amavisd amavis.noarch: W: non-standard-uid /var/run/clamd.amavisd amavis amavis.noarch: W: non-standard-gid /var/run/clamd.amavisd clamupdate amavis.noarch: E: dir-or-file-in-var-run /var/run/clamd.amavisd amavis.noarch: E: non-standard-dir-perm /var/run/clamd.amavisd 770 amavis.noarch: W: non-standard-uid /var/spool/amavisd amavis amavis.noarch: W: non-standard-gid /var/spool/amavisd amavis amavis.noarch: E: non-standard-dir-perm /var/spool/amavisd 750 amavis.noarch: W: non-standard-uid /var/spool/amavisd/db amavis amavis.noarch: W: non-standard-gid /var/spool/amavisd/db amavis amavis.noarch: E: non-standard-dir-perm /var/spool/amavisd/db 750 amavis.noarch: W: non-standard-uid /var/spool/amavisd/quarantine amavis amavis.noarch: W: non-standard-gid /var/spool/amavisd/quarantine amavis amavis.noarch: E: non-standard-dir-perm /var/spool/amavisd/quarantine 750 amavis.noarch: W: non-standard-uid /var/spool/amavisd/tmp amavis amavis.noarch: W: non-standard-gid /var/spool/amavisd/tmp amavis amavis.noarch: E: non-standard-dir-perm /var/spool/amavisd/tmp 750 amavis.noarch: W: no-manual-page-for-binary amavisd-agent amavis.noarch: W: no-manual-page-for-binary amavisd-nanny amavis.noarch: W: no-manual-page-for-binary amavisd-release amavis.noarch: W: no-manual-page-for-binary amavisd-signer amavis.noarch: W: no-manual-page-for-binary amavisd-submit amavis.noarch: W: no-manual-page-for-binary amavisd 1 packages and 0 specfiles checked; 7 errors, 23 warnings. $ rpmlint ~/rpmbuild/SRPMS/amavis-2.12.0-3.fc31.src.rpm amavis.src: W: spelling-error Summary(en_US) spamassassin -> spam assassin, spam-assassin, assassin amavis.src: W: spelling-error %description -l en_US SpamAssassin -> Spam Assassin, Spam-assassin, Assassin 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/amavis-snmp-2.12.0-3.fc31.noarch.rpm amavis-snmp.noarch: W: spelling-error %description -l en_US amavisd -> atavism amavis-snmp.noarch: W: spelling-error %description -l en_US subagent -> sub agent, sub-agent, subbasement amavis-snmp.noarch: W: spelling-error %description -l en_US stdout -> stout, std out, std-out amavis-snmp.noarch: W: spelling-error %description -l en_US mrtg -> mtg amavis-snmp.noarch: W: no-manual-page-for-binary amavisd-snmp-subagent 1 packages and 0 specfiles checked; 0 errors, 5 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/amavis-doc-2.12.0-3.fc31.noarch.rpm amavis-doc.noarch: W: install-file-in-docs /usr/share/doc/amavis-doc/INSTALL 1 packages and 0 specfiles checked; 0 errors, 1 warnings. ``` Thanks in advance, Hirotaka Wakabayashi
Spec URL: https://jorti.fedorapeople.org/amavis/amavis.spec SRPM URL: https://jorti.fedorapeople.org/amavis/amavis-2.12.0-4.fc30.src.rpm Hi, I've changed /var/run to /run everywhere and removed the INSTALL file. I won't touch the directory permissions as they are correct. Thank you.
Hello Juan, Thank you for your comment. I will review the package today later. Here is a successful koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=37849629
Hello Juan, Package APPROVED. I have confirmed that you have fixed the rpmlint errors. I also confirmed the new package, amavis, successufully renamed the old package, amavisd-new package in my local environment. 1. results of rpmlint ```` $ rpmlint ~/rpmbuild/SRPMS/amavis-2.12.0-4.fc31.src.rpm amavis.src: W: spelling-error Summary(en_US) spamassassin -> spam assassin, spam-assassin, assassin amavis.src: W: spelling-error %description -l en_US SpamAssassin -> Spam Assassin, Spam-assassin, Assassin 1 packages and 0 specfiles checked; 0 errors, 2 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/amavis-amavis-2.12.0-4.fc31.noarch.rpm (none): E: no installed packages by name /home/vagrant/rpmbuild/RPMS/noarch/amavis-amavis-2.12.0-4.fc31.noarch.rpm 0 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/amavis-doc-2.12.0-4.fc31.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ~/rpmbuild/RPMS/noarch/amavis-snmp-2.12.0-4.fc31.noarch.rpm amavis-snmp.noarch: W: spelling-error %description -l en_US amavisd -> atavism amavis-snmp.noarch: W: spelling-error %description -l en_US subagent -> sub agent, sub-agent, subbasement amavis-snmp.noarch: W: spelling-error %description -l en_US stdout -> stout, std out, std-out amavis-snmp.noarch: W: spelling-error %description -l en_US mrtg -> mtg amavis-snmp.noarch: W: no-manual-page-for-binary amavisd-snmp-subagent 1 packages and 0 specfiles checked; 0 errors, 5 warnings. ``` 2. success on replacement old packages. ``` $ sudo yum install ~/rpmbuild/RPMS/noarch/amavis-doc-2.12.0-4.fc31.noarch.rpm ~/rpmbuild/RPMS/noarch/amavis-snmp-2.12.0-4.fc31.noarch.rpm ~/rpmbuild/RPMS/noarch/amavis-2.12.0-4.fc31.noarch.rpm Last metadata expiration check: 0:20:53 ago on Wed 25 Sep 2019 02:26:02 PM UTC. Dependencies resolved. ============================================================================================================================================================================================================================================== Package Architecture Version Repository Size ============================================================================================================================================================================================================================================== Installing: amavis-doc noarch 2.12.0-4.fc31 @commandline 437 k replacing amavisd-new-doc.noarch 2.12.0-2.fc31 amavis-snmp noarch 2.12.0-4.fc31 @commandline 32 k replacing amavisd-new-snmp.noarch 2.12.0-2.fc31 amavis noarch 2.12.0-4.fc31 @commandline 363 k replacing amavisd-new.noarch 2.12.0-2.fc31 Transaction Summary ============================================================================================================================================================================================================================================== Install 3 Packages Total size: 832 k Is this ok [y/N]: y Downloading Packages: Running transaction check Transaction check succeeded. Running transaction test Transaction test succeeded. Running transaction Preparing : 1/1 Running scriptlet: amavis-doc-2.12.0-4.fc31.noarch 1/1 Installing : amavis-doc-2.12.0-4.fc31.noarch 1/6 Running scriptlet: amavis-2.12.0-4.fc31.noarch 2/6 Installing : amavis-2.12.0-4.fc31.noarch 2/6 Running scriptlet: amavis-2.12.0-4.fc31.noarch 2/6 Installing : amavis-snmp-2.12.0-4.fc31.noarch 3/6 Running scriptlet: amavis-snmp-2.12.0-4.fc31.noarch 3/6 Running scriptlet: amavisd-new-snmp-2.12.0-2.fc31.noarch 4/6 Obsoleting : amavisd-new-snmp-2.12.0-2.fc31.noarch 4/6 Running scriptlet: amavisd-new-snmp-2.12.0-2.fc31.noarch 4/6 Running scriptlet: amavisd-new-2.12.0-2.fc31.noarch 5/6 Obsoleting : amavisd-new-2.12.0-2.fc31.noarch 5/6 Running scriptlet: amavisd-new-2.12.0-2.fc31.noarch 5/6 Obsoleting : amavisd-new-doc-2.12.0-2.fc31.noarch 6/6 Running scriptlet: amavisd-new-doc-2.12.0-2.fc31.noarch 6/6 Verifying : amavis-doc-2.12.0-4.fc31.noarch 1/6 Verifying : amavisd-new-doc-2.12.0-2.fc31.noarch 2/6 Verifying : amavis-snmp-2.12.0-4.fc31.noarch 3/6 Verifying : amavisd-new-snmp-2.12.0-2.fc31.noarch 4/6 Verifying : amavis-2.12.0-4.fc31.noarch 5/6 Verifying : amavisd-new-2.12.0-2.fc31.noarch 6/6 Installed: amavis-doc-2.12.0-4.fc31.noarch amavis-snmp-2.12.0-4.fc31.noarch amavis-2.12.0-4.fc31.noarch Complete! $ rpm -qa|grep amavis amavis-2.12.0-4.fc31.noarch amavis-doc-2.12.0-4.fc31.noarch amavis-snmp-2.12.0-4.fc31.noarch ```` Best Regards, Hirotaka Wakabayashi
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/amavis