Bug 1747138 - Review Request: perl-DBIx-Class-Helpers - A collection of various components for DBIx::Class
Summary: Review Request: perl-DBIx-Class-Helpers - A collection of various components ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-08-29 18:23 UTC by Emmanuel Seyman
Modified: 2019-09-03 17:39 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-09-03 17:39:50 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Emmanuel Seyman 2019-08-29 18:23:17 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-Helpers/perl-DBIx-Class-Helpers.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-DBIx-Class-Helpers/perl-DBIx-Class-Helpers-2.034000-1.fc30.src.rpm
Description:
This perl distribution contains a collection of various helper components
for DBIx::Class.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2019-08-30 10:57:26 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires
FIX: Please add missing build-requires:
     - perl(B) - t/Row/NumifyGet.t:13
     - perl(base) - lib/DBIx/Class/Helper/Schema/Verifier.pm:14
     - perl(Data::Dumper::Concise) - t/ResultSet/Explain.t:5
     - perl(DateTime) - t/Schema/DateTime.t:8
     - perl(DBI) - lib/DBIx/Class/Helper/ResultSet/DateMethods1.pm:10
     - perl(DBIx::Class::Candy::Exports) - lib/DBIx/Class/Helper/Row/SubClass.pm:11
     - perl(DBIx::Class::Candy::ResultSet) - t/lib/VerifySchema/ResultSet/A.pm:3
     - perl(DBIx::Class::Core) - t/Schema/Verifier/C3.t:27
     - perl(DBIx::Class::ResultSet) - lib/DBIx/Class/Helper/ResultSet/AutoRemoveColumns.pm:8
     - perl(DBIx::Class::Row) - lib/DBIx/Class/Helper/Row/ToJSON.pm:8
     - perl(DBIx::Class::Schema) - lib/DBIx/Class/Helper/Schema/DateTime.pm:8
     - perl(Devel::Dwarn) - t/ResultSet/RemoveColumns/_resolved_attrs.t:8
     - perl(File::Spec) - t/lib/TestSchema.pm:6
     - perl(lib) - t/bug-1.t:6
     - perl(Moo::Role) - t/lib/A/Role/TestConnect.pm:3
     - perl(mro) - t/Schema/Verifier/C3.t:35
     - perl(MRO::Compat) - t/Schema/Verifier/C3.t:34
     - perl(Scalar::Util) - lib/DBIx/Class/Helper/ResultClass/Tee.pm:9
     - perl(strict) - Makefile.PL:2
     - perl(Sub::Name) - lib/DBIx/Class/Helper/Row/ProxyResultSetMethod.pm:10
     - perl(utf8) - lib/DBIx/Class/Helper/ResultClass/Tee.pm:5
     - perl(vars) - lib/DBIx/Class/Helper/ResultSet/VirtualView.pm:7
     - perl(warnings) - Makefile.PL:3


$ rpm -qp --requires perl-DBIx-Class-Helpers-2.034000-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Carp::Clan)
      1 perl(DBI)
      1 perl(DBIx::Class::Candy::Exports)
      1 perl(DBIx::Class::Helper::ResultSet::AutoRemoveColumns)
      1 perl(DBIx::Class::Helper::ResultSet::CorrelateRelationship)
      1 perl(DBIx::Class::Helper::ResultSet::IgnoreWantarray)
      1 perl(DBIx::Class::Helper::ResultSet::Me)
      1 perl(DBIx::Class::Helper::ResultSet::NoColumns)
      1 perl(DBIx::Class::Helper::ResultSet::Random)
      1 perl(DBIx::Class::Helper::ResultSet::RemoveColumns)
      1 perl(DBIx::Class::Helper::ResultSet::ResultClassDWIM)
      1 perl(DBIx::Class::Helper::ResultSet::SearchOr)
      1 perl(DBIx::Class::Helper::ResultSet::SetOperations)
      1 perl(DBIx::Class::Helper::ResultSet::Shortcut)
      1 perl(DBIx::Class::Helper::ResultSet::Shortcut::OrderBy)
      1 perl(DBIx::Class::Helper::ResultSet::Shortcut::Page)
      1 perl(DBIx::Class::Helper::ResultSet::Shortcut::Rows)
      1 perl(DBIx::Class::Helper::ResultSet::Shortcut::Search::Base)
      1 perl(DBIx::Class::Helper::ResultSet::Util)
      1 perl(DBIx::Class::Helper::ResultSet::VirtualView)
      1 perl(DBIx::Class::Helper::Row::JoinTable)
      1 perl(DBIx::Class::Helper::Row::SelfResultSet)
      1 perl(DBIx::Class::Helper::Row::StorageValues)
      1 perl(DBIx::Class::Helper::Row::SubClass)
      1 perl(DBIx::Class::Helper::Schema::Verifier)
      1 perl(DBIx::Class::Helpers::Util)
      1 perl(DBIx::Class::ResultSet)
      1 perl(DBIx::Class::Row)
      1 perl(DBIx::Class::Schema)
      1 perl(DBIx::Introspector)
      1 perl(Lingua::EN::Inflect)
      1 perl(List::Util)
      1 perl(:MODULE_COMPAT_5.30.0)
      1 perl(Module::Runtime)
      1 perl(Moo)
      1 perl(mro)
      1 perl(MRO::Compat)
      1 perl(namespace::clean)
      1 perl(parent)
      1 perl(Safe::Isa)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Exporter::Progressive)
      1 perl(Sub::Name)
      1 perl(Text::Brew)
      1 perl(Try::Tiny)
      1 perl(utf8)
      1 perl(vars)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-DBIx-Class-Helpers-2.034000-1.fc32.noarch.rpm | sort | uniq -c
There is a long list of provide, so I don't copy it. I checked the list and
binary provides are Ok.

$ rpmlint ./perl-DBIx-Class-Helpers*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

Resolution:
Approved

Comment 2 Gwyn Ciesla 2019-08-30 16:49:42 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-DBIx-Class-Helpers

Comment 3 Emmanuel Seyman 2019-09-03 17:39:50 UTC
This package is now in Rawhide and updates have been released for the stable distributions. Thank you for the review, Jikta.


Note You need to log in before you can comment on or make changes to this bug.