Bug 1748349
| Summary: | 'View objectclass' modal dialog doesn't have all controls disabled | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Directory Server | Reporter: | Viktor Ashirov <vashirov> | ||||||||
| Component: | cockpit-389-ds | Assignee: | mreynolds | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | RHDS QE <ds-qe-bugs> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 11.0 | CC: | ebock, lkrispen, mhonek, pasik, spichugi, tbordaz | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | dirsrv-11.1 | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | 389-ds-base-1.4.2.7-1.module+el8dsrv+5547+8be68086 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2020-04-29 08:04:40 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Viktor Ashirov
2019-09-03 12:14:57 UTC
Build tested: 389-ds-base-1.4.1.7-1.module+el8dsrv+4200+233a821d Checkboxes also should be read only: disabled="disabled" Builds tested: 389-ds-base-1.4.1.9-1.module+el8dsrv+4243+ba0eb3c6.x86_64 cockpit-389-ds-1.4.1.9-1.module+el8dsrv+4243+ba0eb3c6.noarch Input fields should have 'disabled' attribute, not 'readonly'. There is a difference between 'readonly' and 'disabled': user can't differentiate *visually* between readonly and non-readonly input fields, they looks the same, but behave differently. Disabled field, on the other hand, has a different look and its intent is clear. I'm attaching screenshots of readonly, disabled and writeable dialogs. Note how readonly and writable input fields look exactly the same. Marking as ASSIGNED. Created attachment 1620140 [details]
Dialog with writable input fields
Created attachment 1620141 [details]
Dialog with readonly fields
Created attachment 1620142 [details]
Dialog with disabled input fields
Builds tested: 389-ds-base-1.4.1.10-1.module+el8dsrv+4575+0d8b81fc.x86_64 cockpit-389-ds-1.4.1.10-1.module+el8dsrv+4575+0d8b81fc.noarch View objectClass and View attribute modals have all attributes 'readonly', not 'disabled'. Moving to ASSIGNED. Build tested: 389-ds-base-1.4.2.7-1.module+el8dsrv+5547+8be68086.x86_64
There is no View objectClass or View attribute modals anymore. Only Edit. Is this expected?
And when I press Edit on an attribute, I get the following error in the console
Uncaught TypeError: Cannot read property 'title' of undefined
at load_attr_form (schema.js:701)
at HTMLAnchorElement.<anonymous> (schema.js:789)
at HTMLDocument.dispatch (jquery-3.3.1.min.js:2)
at HTMLDocument.y.handle (jquery-3.3.1.min.js:2)
And the modal dialog doesn't appear.
Moving to ASSIGNED.
Please ignore last comment, was testing on a wrong build. Build tested: cockpit-389-ds-1.4.2.7-1.module+el8dsrv+5547+8be68086.noarch View objectClass and attribute modals look good, fields are disabled as requested. No crash is observed. Marking as VERIFIED. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:1961 |