Bug 1748349 - 'View objectclass' modal dialog doesn't have all controls disabled
Summary: 'View objectclass' modal dialog doesn't have all controls disabled
Keywords:
Status: POST
Alias: None
Product: Red Hat Directory Server
Classification: Red Hat
Component: cockpit-389-ds
Version: 11.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: mreynolds
QA Contact: RHDS QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-09-03 12:14 UTC by Viktor Ashirov
Modified: 2019-11-08 22:03 UTC (History)
6 users (show)

Fixed In Version: 389-ds-base-1.4.1.10-1.module+el8dsrv+4575+0d8b81fc
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:


Attachments (Terms of Use)
Dialog with writable input fields (46.62 KB, image/png)
2019-09-27 13:48 UTC, Viktor Ashirov
no flags Details
Dialog with readonly fields (52.88 KB, image/png)
2019-09-27 13:49 UTC, Viktor Ashirov
no flags Details
Dialog with disabled input fields (55.92 KB, image/png)
2019-09-27 13:49 UTC, Viktor Ashirov
no flags Details

Description Viktor Ashirov 2019-09-03 12:14:57 UTC
Description of problem:
'View objectclass' dialog is a re-purposed edit dialog, but only with a different title and Save button disabled. Unfortunately, it creates confusion, as all the other elements are enabled and allow to edit name, attributes, etc. It should be clear to the user that a View dialog is read-only. 

Version-Release number of selected component (if applicable):
389-ds-base-1.4.1.6-2.module+el8dsrv+3912+aa2ce078.x86_64


How reproducible:
always

Steps to Reproduce:
1. Schema -> Objectclasses -> View Objectclass
2. Try adding/removing required/allowed attributes, selecting parent objectClass or objectClass kind, etc.
3.

Actual results:
UI elements are enabled and allow changes.

Expected results:
UI elements should be disabled as it is a read-only dialog.

Additional info:

Comment 1 Viktor Ashirov 2019-09-10 11:15:11 UTC
Build tested:  389-ds-base-1.4.1.7-1.module+el8dsrv+4200+233a821d

Checkboxes also should be read only:

disabled="disabled"

Comment 3 Viktor Ashirov 2019-09-27 13:48:15 UTC
Builds tested:
389-ds-base-1.4.1.9-1.module+el8dsrv+4243+ba0eb3c6.x86_64
cockpit-389-ds-1.4.1.9-1.module+el8dsrv+4243+ba0eb3c6.noarch

Input fields should have 'disabled' attribute, not 'readonly'. There is a difference between 'readonly' and 'disabled': user can't differentiate *visually* between readonly and non-readonly input fields, they looks the same, but behave differently. Disabled field, on the other hand, has a different look and its intent is clear.
I'm attaching screenshots of readonly, disabled and writeable dialogs. Note how readonly and writable input fields look exactly the same.

Marking as ASSIGNED.

Comment 4 Viktor Ashirov 2019-09-27 13:48:45 UTC
Created attachment 1620140 [details]
Dialog with writable input fields

Comment 5 Viktor Ashirov 2019-09-27 13:49:09 UTC
Created attachment 1620141 [details]
Dialog with readonly fields

Comment 6 Viktor Ashirov 2019-09-27 13:49:35 UTC
Created attachment 1620142 [details]
Dialog with disabled input fields

Comment 8 Viktor Ashirov 2019-11-04 14:05:12 UTC
Builds tested:
389-ds-base-1.4.1.10-1.module+el8dsrv+4575+0d8b81fc.x86_64
cockpit-389-ds-1.4.1.10-1.module+el8dsrv+4575+0d8b81fc.noarch

View objectClass and View attribute modals have all attributes 'readonly', not 'disabled'.

Moving to ASSIGNED.

Comment 10 mreynolds 2019-11-08 22:03:47 UTC
https://pagure.io/389-ds-base/issue/50696


Note You need to log in before you can comment on or make changes to this bug.