Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://sergesanspaille.fedorapeople.org/xtensor.spec SRPM URL: https://sergesanspaille.fedorapeople.org/xtensor-0.20.8-0.fc31.src.rpm Description: xtensor is a C++ library meant for numerical analysis with multi-dimensional array expressions. xtensor provides an extensible expression system enabling lazy broadcasting, an API following the idioms of the C++ standard library, tools to manipulate array expressions and build upon xtensor. Fedora Account System Username: sergesanspaille
#see https://github.com/QuantStack/xtensor/commit/842d79cc7aea882ad69dfe5ebcd6ad8a7be24624 Patch1: 842d79cc7aea882ad69dfe5ebcd6ad8a7be24624.patch Does the commit apply cleanly? If yes, you can do: Patch1: %{github}/commit/842d79cc7aea882ad69dfe5ebcd6ad8a7be24624.patch That line also has tabs and you are mixing tabs and spaces. Running automated checks.
> Does the commit apply cleanly? If yes, you can do: Unfortunately not. it contains some binary diff ( for a test case) so I had to slightly rework it. Thanks for the tip anyway :-)
tab vs. space issue fixed and uploaded.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated There are rpmlint errors to fix: - description-line-too-long - mixed-use-of-spaces-and-tabs ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: xtensor-0.20.8/cmake/FindTBB.cmake is MIT, but not shipped. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [?]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xtensor-devel-0.20.8-0.fc32.x86_64.rpm xtensor-0.20.8-0.fc32.src.rpm xtensor-devel.x86_64: E: description-line-too-long C xtensor is a C++ library meant for numerical analysis with multi-dimensional array expressions. xtensor.src: E: description-line-too-long C xtensor is a C++ library meant for numerical analysis with multi-dimensional array expressions. xtensor.src:12: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) 2 packages and 0 specfiles checked; 2 errors, 1 warnings. Please fix those. Rpmlint (installed packages) ---------------------------- xtensor-devel.x86_64: E: description-line-too-long C xtensor is a C++ library meant for numerical analysis with multi-dimensional array expressions. xtensor-devel.x86_64: W: invalid-url URL: http://xtensor.readthedocs.io/ <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 1 errors, 1 warnings. Please fix those. Source checksums ---------------- https://github.com/QuantStack/xtensor/archive/0.20.8/xtensor-0.20.8.tar.gz : CHECKSUM(SHA256) this package : 5421aede8971342adb97becea4edfb9a4b05bf9ebf64b0146003998ee4153383 CHECKSUM(SHA256) upstream package : 5421aede8971342adb97becea4edfb9a4b05bf9ebf64b0146003998ee4153383 Requires -------- xtensor-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config cmake-filesystem(x86-64) xsimd-devel xtl-devel Provides -------- xtensor-devel: cmake(xtensor) pkgconfig(xtensor) xtensor xtensor-devel xtensor-devel(x86-64) xtensor-static
The description was updated as well: $ rpmlint xtensor.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint xtensor-0.20.8-0.fc31.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/xtensor
build done, package should be availabe in rawhide. https://koji.fedoraproject.org/koji/buildinfo?buildID=1371231