Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01027810-usbtop/usbtop.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01027810-usbtop/usbtop-1.0-1.fc32.src.rpm Description: usbtop is a top-like utility that shows an estimated instantaneous bandwidth on USB buses and devices. Fedora Account System Username: carlwgeorge
Taking this review.
> install -d %{buildroot}%{_usr}/lib/modules-load.d Replace "%{_usr}/lib/modules-load.d" with "%{_modulesloaddir}". This requires adding "BuildRequires: systemd" (or for Fedora 30+, "BuildRequires: systemd-rpm-macros" is sufficient). > %setup -q -n usbtop-release-%{version} You can use "%autosetup -n %{name}-release-%{version}" instead.
Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01028279-usbtop/usbtop.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/01028279-usbtop/usbtop-1.0-2.fc32.src.rpm As requested: +BuildRequires: systemd-rpm-macros -%setup -q -n usbtop-release-%{version} +%autosetup -n usbtop-release-%{version} -install -d %{buildroot}%{_usr}/lib/modules-load.d -echo usbmon > %{buildroot}%{_usr}/lib/modules-load.d/usbtop.conf +install -d %{buildroot}%{_modulesloaddir} +echo usbmon > %{buildroot}%{_modulesloaddir}/usbtop.conf -%{_usr}/lib/modules-load.d/usbtop.conf +%{_modulesloaddir}/usbtop.conf
Package review notes: [x]: Package is named according to packaging guidelines [x]: Package builds and installs [x]: Package uses macros consistently [x]: Package licensing is correctly declared and installed PACKAGE APPROVED.
Thanks Neal.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/usbtop
rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c030d7ddae
FEDORA-2019-a4f86875db has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a4f86875db
FEDORA-2019-5390b38041 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5390b38041
usbtop-1.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5390b38041
usbtop-1.0-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a4f86875db
usbtop-1.0-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
usbtop-1.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.