Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/xde-menu/fedora-30-x86_64/01028070-xde-menu/xde-menu.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/xde-menu/fedora-30-x86_64/01028070-xde-menu/xde-menu-0.10-1.fc30.src.rpm Description: This package provides a number of "C"-language tools for working with the X Desktop Environment. Most of these tools were previously written in 'perl(1)' and were part of the 'xde-tools' package. They have now been codified in "C" for speed and to provide access to libraries not available from 'perl(1)'. Fedora Account System Username: atim Working COPR: https://copr.fedorainfracloud.org/coprs/atim/xde-menu
https://copr-be.cloud.fedoraproject.org/results/atim/xde-menu/fedora-30-x86_64/01028234-xde-menu/xde-menu.spec https://copr-be.cloud.fedoraproject.org/results/atim/xde-menu/fedora-30-x86_64/01028234-xde-menu/xde-menu-0.10-2.fc30.src.rpm
https://copr-be.cloud.fedoraproject.org/results/atim/xde-menu/fedora-30-x86_64/01028557-xde-menu/xde-menu.spec https://copr-be.cloud.fedoraproject.org/results/atim/xde-menu/fedora-30-x86_64/01028557-xde-menu/xde-menu-0.11-1.fc30.src.rpm
WIP. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain any libtool archives (.la) Note: xde-menu : /usr/lib64/xde-menu/modules/xde-menu-2bwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-adwm.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-aewm++.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-aewm.la xde-menu : /usr/lib64/xde-menu/modules/xde- menu-afterstep.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu- awesome.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-blackbox.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-bspwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-ctwm.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-cwm.la xde-menu : /usr/lib64/xde-menu/modules/xde- menu-dtwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-dwm.la xde- menu : /usr/lib64/xde-menu/modules/xde-menu-echinus.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-etwm.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-ewmh.la xde-menu : /usr/lib64/xde-menu/modules/xde- menu-fluxbox.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-flwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-fvwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-glasswm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-goomwwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-herbstluftwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-i3.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-icewm.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-jwm.la xde-menu : /usr/lib64/xde-menu/modules/xde- menu-larswm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-matwm2.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-metacity.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-mvwm.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-mwm.la xde-menu : /usr/lib64/xde-menu/modules/xde- menu-openbox.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu- openboxold.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-pekwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-perlpanel.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-spectrwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-twm.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-uwm.la xde-menu : /usr/lib64/xde-menu/modules/xde- menu-vtwm.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-waimea.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-wind.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-wm2.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-wmaker.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-wmakerold.la xde-menu : /usr/lib64/xde- menu/modules/xde-menu-wmii.la xde-menu : /usr/lib64/xde-menu/modules/xde- menu-wmx.la xde-menu : /usr/lib64/xde-menu/modules/xde-menu-xdwm.la xde- menu : /usr/lib64/xde-menu/modules/xde-menu-yeahwm.la See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3) (with incorrect FSF address)". 31 files have unknown license. Detailed output of licensecheck in /mnt/data-linux/1748942-xde-menu/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/X11/app- defaults(libXt) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 153600 bytes in 5 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in xde-menu [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xde-menu-0.11-1.fc32.x86_64.rpm xde-menu-debuginfo-0.11-1.fc32.x86_64.rpm xde-menu-debugsource-0.11-1.fc32.x86_64.rpm xde-menu-0.11-1.fc32.src.rpm xde-menu.x86_64: W: spelling-error %description -l en_US perl -> Perl, peel, perk xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-2bwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-adwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-aewm++.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-aewm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-afterstep.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-awesome.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-bspwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-cwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-dwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-echinus.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-ewmh.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-flwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-glasswm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-goomwwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-herbstluftwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-i3.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-jwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-larswm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-matwm2.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-metacity.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-mvwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-spectrwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-wind.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-wm2.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-wmii.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-wmx.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-xdwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-yeahwm.so xde-menu.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/xde-menu.desktop xde-menu.x86_64: E: invalid-desktopfile /usr/share/applications/xde-menu.desktop value "XDE;System;Utility;" for key "Categories" in group "Desktop Entry" contains an unregistered value "XDE"; values extending the format should start with "X-" xde-menu.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk 4 packages and 0 specfiles checked; 29 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: xde-menu-debuginfo-0.11-1.fc32.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_UA.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_UA.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). xde-menu.x86_64: W: spelling-error %description -l en_US perl -> Perl, peel, perk xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-2bwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-adwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-aewm++.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-aewm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-afterstep.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-awesome.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-bspwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-cwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-dwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-echinus.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-ewmh.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-flwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-glasswm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-goomwwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-herbstluftwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-i3.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-jwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-larswm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-matwm2.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-metacity.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-mvwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-spectrwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-wind.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-wm2.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-wmii.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-wmx.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-xdwm.so xde-menu.x86_64: E: shared-lib-without-dependency-information /usr/lib64/xde-menu/modules/xde-menu-yeahwm.so xde-menu.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/xde-menu.desktop xde-menu.x86_64: E: invalid-desktopfile /usr/share/applications/xde-menu.desktop value "XDE;System;Utility;" for key "Categories" in group "Desktop Entry" contains an unregistered value "XDE"; values extending the format should start with "X-" 3 packages and 0 specfiles checked; 29 errors, 2 warnings. Unversioned so-files -------------------- xde-menu: /usr/lib64/xde-menu/modules/xde-menu-2bwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-adwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-aewm++.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-aewm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-afterstep.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-awesome.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-blackbox.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-bspwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-ctwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-cwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-dtwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-dwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-echinus.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-etwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-ewmh.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-fluxbox.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-flwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-fvwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-glasswm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-goomwwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-herbstluftwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-i3.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-icewm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-jwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-larswm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-matwm2.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-metacity.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-mvwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-mwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-openbox.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-openboxold.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-pekwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-perlpanel.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-spectrwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-twm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-uwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-vtwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-waimea.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-wind.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-wm2.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-wmaker.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-wmakerold.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-wmii.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-wmx.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-xdwm.so xde-menu: /usr/lib64/xde-menu/modules/xde-menu-yeahwm.so Source checksums ---------------- https://github.com/bbidulock/xde-menu/archive/0.11/xde-menu-0.11.tar.gz : CHECKSUM(SHA256) this package : 07d73fccd0c8e62b61ef45b99fb838c5e692bf8fff9a3118dd96d9cfa9be0f8d CHECKSUM(SHA256) upstream package : 07d73fccd0c8e62b61ef45b99fb838c5e692bf8fff9a3118dd96d9cfa9be0f8d Requires -------- xde-menu (rpmlib, GLIBC filtered): libICE.so.6()(64bit) libSM.so.6()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgnome-menu-3.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) libwnck-1.so.22()(64bit) rtld(GNU_HASH) xde-menu-debuginfo (rpmlib, GLIBC filtered): xde-menu-debugsource (rpmlib, GLIBC filtered): Provides -------- xde-menu: application() application(xde-menu.desktop) libtool(/usr/lib64/xde-menu/modules/xde-menu-2bwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-adwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-aewm++.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-aewm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-afterstep.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-awesome.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-blackbox.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-bspwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-ctwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-cwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-dtwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-dwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-echinus.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-etwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-ewmh.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-fluxbox.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-flwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-fvwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-glasswm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-goomwwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-herbstluftwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-i3.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-icewm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-jwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-larswm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-matwm2.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-metacity.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-mvwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-mwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-openbox.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-openboxold.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-pekwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-perlpanel.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-spectrwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-twm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-uwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-vtwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-waimea.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-wind.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-wm2.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-wmaker.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-wmakerold.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-wmii.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-wmx.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-xdwm.la) libtool(/usr/lib64/xde-menu/modules/xde-menu-yeahwm.la) xde-menu xde-menu(x86-64) xde-menu-debuginfo: debuginfo(build-id) xde-menu-debuginfo xde-menu-debuginfo(x86-64) xde-menu-debugsource: xde-menu-debugsource xde-menu-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1748942 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Perl, Python, Ocaml, Java, SugarActivity, PHP, Haskell, fonts, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Just drop .la files.
https://copr-be.cloud.fedoraproject.org/results/atim/xde-menu/fedora-30-x86_64/01028651-xde-menu/xde-menu.spec https://copr-be.cloud.fedoraproject.org/results/atim/xde-menu/fedora-30-x86_64/01028651-xde-menu/xde-menu-0.11-2.fc30.src.rpm
Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3) (with incorrect FSF address)". 31 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/xde-menu/review-xde- menu/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/X11/app- defaults(libXt) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 153600 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xde-menu-0.11-2.fc32.x86_64.rpm xde-menu-debuginfo-0.11-2.fc32.x86_64.rpm xde-menu-debugsource-0.11-2.fc32.x86_64.rpm xde-menu-0.11-2.fc32.src.rpm xde-menu.x86_64: W: spelling-error %description -l en_US perl -> Perl, peel, perk xde-menu.x86_64: W: non-conffile-in-etc /etc/xdg/autostart/xde-menu.desktop xde-menu.x86_64: E: invalid-desktopfile /usr/share/applications/xde-menu.desktop value "XDE;System;Utility;" for key "Categories" in group "Desktop Entry" contains an unregistered value "XDE"; values extending the format should start with "X-" xde-menu.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk 4 packages and 0 specfiles checked; 1 errors, 3 warnings.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/xde-menu
FEDORA-2019-8a3369603d has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-8a3369603d
FEDORA-2019-5e52ce8772 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-5e52ce8772
xde-menu-0.11-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-5e52ce8772
xde-menu-0.11-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-8a3369603d
xde-menu-0.11-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
xde-menu-0.11-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.