Created attachment 1611909 [details]
activate eth1 interface, setting ip in it

Description of problem:
When adding complex network configurations - for instance, attaching a bond (with slaves) as a port to a bridge, within a single transaction, it is possible for the transaction to fail, and rolled-back.

Version-Release number of selected component (if applicable):
nmstate-0.0.8-12.el8

How reproducible:
50 % of times

Steps to Reproduce:
1. start the nmstate container - e.g. ./automation/run-tests.sh --debug-shell
2. interrupt the shell when the tests start. that'll give a shell into the nmstate container
3. provision the activate_eth1.yml attachment
4. provision the bridge_over_bond_over_slave_single_tx.yml attachment

Actual results:
2019-09-05 10:46:49,353 root         ERROR    NM main-loop aborted: Connection activation failed on connection_id bond0: error=nm-manager-error-quark: Master device 'bond0' can't be activated: Device unmanaged or not available for activation (7)
2019-09-05 10:46:49,376 root         DEBUG    Checkpoint /org/freedesktop/NetworkManager/Checkpoint/2 rollback executed: dbus.Dictionary({dbus.String('/org/freedesktop/NetworkManager/Devices/4'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/2'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/3'): dbus.UInt32(0), dbus.String('/org/freedesktop/NetworkManager/Devices/1'): dbus.UInt32(0)}, signature=dbus.Signature('su'))
Traceback (most recent call last):
  File "/usr/bin/nmstatectl", line 11, in <module>
    load_entry_point('nmstate==0.0.8', 'console_scripts', 'nmstatectl')()
  File "/usr/lib/python3.7/site-packages/nmstatectl/nmstatectl.py", line 62, in main
    return args.func(args)
  File "/usr/lib/python3.7/site-packages/nmstatectl/nmstatectl.py", line 220, in apply
    statedata, args.verify, args.commit, args.timeout
  File "/usr/lib/python3.7/site-packages/nmstatectl/nmstatectl.py", line 240, in apply_state
    checkpoint = libnmstate.apply(state, verify_change, commit, timeout)
  File "/usr/lib/python3.7/site-packages/libnmstate/netapplier.py", line 66, in apply
    state.State(desired_state), verify_change, commit, rollback_timeout
  File "/usr/lib/python3.7/site-packages/libnmstate/netapplier.py", line 146, in _apply_ifaces_state
    con_profiles=ifaces_add_configs + ifaces_edit_configs,
  File "/usr/lib64/python3.7/contextlib.py", line 119, in __exit__
    next(self.gen)
  File "/usr/lib/python3.7/site-packages/libnmstate/netapplier.py", line 210, in _setup_providers
    mainloop.error
libnmstate.error.NmstateLibnmError: Unexpected failure of libnm when running the mainloop: run execution


Expected results:
...
2019-09-05 10:52:44,687 root         DEBUG    Checkpoint /org/freedesktop/NetworkManager/Checkpoint/13 destroyed
Desired state applied: 
---
interfaces:
- name: bond0
  type: bond
  state: up
  link-aggregation:
    mode: balance-rr
    options:
      miimon: '140'
    slaves:
    - eth1
- name: eth1
  type: ethernet
  state: up
- name: linux-br0
  type: linux-bridge
  state: up
  bridge:
    options:
      group-forward-mask: 0
      mac-ageing-time: 300
      multicast-snooping: true
      stp:
        enabled: true
        forward-delay: 15
        hello-time: 2
        max-age: 20
        priority: 32768
    port:
    - name: bond0


Additional info:
The following can be seen in the journal (journalctl -u NetworkManager):

Sep 05 10:53:38 dce0bd94a71c NetworkManager[228]: <debug> [1567680818.6972] manager: Activation of 'bond0' requires master device 'linux-br0'
Sep 05 10:53:38 dce0bd94a71c NetworkManager[228]: <info>  [1567680818.6973] audit: op="connection-activate" uuid="7df861cb-37e1-4804-bfb2-305068d10568" name="bond0" pid=1818 uid=0 result="fail" reason="Master device 'bond0' can't be activated: Device unmanaged or not available for activation"