Bug 174967 – Missing break statement in 8250 serial driver code (timedia cards)

Bug 174967 - Missing break statement in 8250 serial driver code (timedia cards)

Summary:	Missing break statement in 8250 serial driver code (timedia cards)

Status:	CLOSED ERRATA

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	kernel (Show other bugs)
Sub Component:
Version:	4
Hardware:	All Linux

Priority	medium Severity medium
Target Milestone:	---
Target Release:	---
Assigned To:	Dave Jones
QA Contact:	Brian Brock
Docs Contact:

URL:
Whiteboard:
Keywords:

Depends On:
Blocks:
	Show dependency tree / graph

Reported:	2005-12-05 03:17 EST by JW
Modified:	2015-01-04 17:23 EST (History)
CC List:	2 users (show)

See Also:
Fixed In Version:
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2005-12-15 20:42:34 EST
Type:	---
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Patch to fix missing break statement (461 bytes, patch) 2005-12-05 03:19 EST, JW	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description JW 2005-12-05 03:17:40 EST

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (compatible; MSIE 6.0; Windows; U; AIIEEEE!; Win98; Windows 98; en-US; Gecko masquerading as IE; should it matter?; rv:1.8b) Gecko/20050217

Description of problem:
While reading through the kernel code I found a missing break statement (or two) for timedia serial cards.



Version-Release number of selected component (if applicable):
kernel-2.6.13-1.1532_FC4

How reproducible:
Always

Steps to Reproduce:
1.vi drivers/serial/8250_pci.c
2.545G
3.
  

Actual Results:  Observed missing break statement in switch.


Expected Results:  case 3 should not fall through to cases 4,5,6,7.
Also, cases 4,5,6,7 should end with a break statement.


Additional info:

Comment 1 JW 2005-12-05 03:19:36 EST

Created attachment 121834 [details]
Patch to fix missing break statement

Comment 2 Dave Jones 2005-12-06 20:02:32 EST

Good catch. I've applied this, and have sent it upstream to the serial maintainer.

Note You need to log in before you can comment on or make changes to this bug.