Spec URL: https://decathorpe.fedorapeople.org/packages/rubygem-kramdown-parser-gfm.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/rubygem-kramdown-parser-gfm-1.1.0-1.fc30.src.rpm Description: kramdown-parser-gfm provides a kramdown parser for the GFM dialect of Markdown. Fedora Account System Username: decathorpe COPR repo with working packages: https://copr.fedorainfracloud.org/coprs/decathorpe/jekyll4/monitor/
1. Review * license okay - MIT for all files * spec file * mock build okay https://koji.fedoraproject.org/koji/taskinfo?taskID=37637054 * rpmlint okay for src.rpm, binary rpm, installed rpm * installable for F-32 * basic functionality okay (as documentated on "Usage" of https://github.com/kramdown/parser-gfm) ``` [mockbuild@1a996dddfd3e4efb85d341420b9e76a2 ~]$ ruby -e 'require "kramdown" ; require "kramdown-parser-gfm" ; text="This ~~is a complex strike through *test ~~with nesting~~ involved* here~~." ; puts Kramdown::Document.new(text, input: "GFM").to_html' <p>This <del>is a complex strike through *test ~~with nesting</del> involved* here~~.</p> ``` 2. Advice * BR - I would recommend to write "BuildRequires: rubygem(kramdown) >= 2.0" because on F-31 and below rubygem-kramdown is still 1.7.x and this srpm is incompatible on those branches (not a blocker for review) By the way do you plan to import this also on F-31? If so I will coordinate it.
============================================================ This package (rubygem-kramdown-parser-gfm) is APPROVED by mtasaka ============================================================
Thanks for the review! BuildRequires: rubygem(kramdown) >= 2.0.0 is already in the .spec file. ;) I only intend to push this to fedora 32, since it's a breaking change (in both kramdown and jekyll 4). See: https://fedoraproject.org/wiki/Changes/Jekyll4
https://pagure.io/releng/fedora-scm-requests/issue/16685
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-kramdown-parser-gfm
Built for rawhide. https://koji.fedoraproject.org/koji/buildinfo?buildID=1377189