Bug 1749755 - Review Request: rubygem-kramdown-syntax-coderay - Coderay syntax highlighting for kramdown
Summary: Review Request: rubygem-kramdown-syntax-coderay - Coderay syntax highlighting...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1749749
Blocks: 1743745
TreeView+ depends on / blocked
 
Reported: 2019-09-06 11:25 UTC by Fabio Valentini
Modified: 2019-09-13 13:28 UTC (History)
1 user (show)

Fixed In Version: rubygem-kramdown-syntax-coderay-1.0.1-1.fc32
Clone Of:
Environment:
Last Closed: 2019-09-13 13:28:26 UTC
Type: ---
Embargoed:
mtasaka: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2019-09-06 11:25:21 UTC
Spec URL: https://decathorpe.fedorapeople.org/packages/rubygem-kramdown-syntax-coderay.spec
SRPM URL: https://decathorpe.fedorapeople.org/packages/rubygem-kramdown-syntax-coderay-1.0.1-1.fc30.src.rpm

Description:
kramdown-syntax-coderay uses coderay to highlight code blocks/spans.

Fedora Account System Username: decathorpe


COPR repo with working packages:
https://copr.fedorainfracloud.org/coprs/decathorpe/jekyll4/monitor/

Comment 1 Mamoru TASAKA 2019-09-13 09:19:03 UTC
1. Review

* license okay (overall: MIT)
* spec file clean
* mock build okay for F-32
  https://koji.fedoraproject.org/koji/taskinfo?taskID=37641779
* binary rpm installable on F-32
* rpmlint clean
  - src.rpm, binary rpms, installed rpm
* at least "require"ing installed gem works
```
[mockbuild@6a90abd4ac174b7b845382de2995036e ~]$ ruby -e 'require "kramdown" ; require "kramdown-syntax-coderay"'
```

All okay.

Comment 2 Mamoru TASAKA 2019-09-13 09:20:16 UTC
=========================================================
  This package (rubygem-kramdown-syntax-coderay) is
  APPROVED by mtasaka
=========================================================

Comment 3 Fabio Valentini 2019-09-13 11:07:25 UTC
Thanks for the review!

Comment 5 Gwyn Ciesla 2019-09-13 13:08:26 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-kramdown-syntax-coderay

Comment 6 Fabio Valentini 2019-09-13 13:28:26 UTC
Built for rawhide:
https://koji.fedoraproject.org/koji/buildinfo?buildID=1377190


Note You need to log in before you can comment on or make changes to this bug.