Spec URL: https://snavin.fedorapeople.org/packages/abhaya-libre-fonts/abhaya-libre-fonts.spec SRPM URL: https://snavin.fedorapeople.org/packages/abhaya-libre-fonts/abhaya-libre-fonts-1.060-0.fc30.src.rpm Additonal file: https://snavin.fedorapeople.org/packages/abhaya-libre-fonts/abhaya-libre-fonts.metainfo.xml Description: I have packaged abhaya-libre-fonts for the Sinhala language. I highly appreciate if you can review this package. Abhaya Libre is the Unicode compliant, complete libre version of FM Abhaya font. Fedora Account System Username: snavin
- Not a valid license shourthand, it should be "OFL": License: SIL Open Font License - Use a better name for your archive: Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz - What is this: %undefine _disable_source_fetch - Use %autosetup %setup -q -c then: install -m 0644 -p fonts/ttf/AbhayaLibre-Bold.ttf %{buildroot}%{_fontdir} install -m 0644 -p fonts/ttf/AbhayaLibre-ExtraBold.ttf %{buildroot}%{_fontdir} install -m 0644 -p fonts/ttf/AbhayaLibre-Medium.ttf %{buildroot}%{_fontdir} install -m 0644 -p fonts/ttf/AbhayaLibre-Regular.ttf %{buildroot}%{_fontdir} install -m 0644 -p fonts/ttf/AbhayaLibre-SemiBold.ttf %{buildroot}%{_fontdir} - Don't: install -m 0755 -d %{buildroot}/usr/share/doc/%{fontname} install -m 0644 -p abhaya-libre-font-1.060/CONTRIBUTORS.md %{buildroot}/usr/share/doc/%{fontname} install -m 0644 -p abhaya-libre-font-1.060/README.md %{buildroot}/usr/share/doc/%{fontname} install -m 0644 -p abhaya-libre-font-1.060/OFL.txt %{buildroot}/usr/share/doc/%{fontname} install -m 0644 -p abhaya-libre-font-1.060/FONTLOG.md %{buildroot}/usr/share/doc/%{fontname} The license file must be installed with %license in %files: %license OFL.txt The docs should be installed with %doc in %files: %doc CONTRIBUTORS.md README.md FONTLOG.md - Release should start at 1 in Fedora not 0: Release: 0%{?dist}
Robert, Thanks for taking this package to review. (In reply to Robert-André Mauchin from comment #1) > - Not a valid license shourthand, it should be "OFL": > > License: SIL Open Font License > Ok, I will make it as OFL > - Use a better name for your archive: > > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > > - What is this: > > %undefine _disable_source_fetch without this rpmbuild looking for the source file in my local. danishka@localhost rpmbuild]$ rpmbuild -ba SPECS/abhaya-libre-fonts.spec error: Bad source: /home/danishka/rpmbuild/SOURCES/abhaya-libre-fonts-1.060.tar.gz: No such file or directory When I add it source is downloading from the given location. [danishka@localhost rpmbuild]$ rpmbuild -ba SPECS/abhaya-libre-fonts.spec warning: Downloading https://github.com/mooniak/abhaya-libre-font/archive/v1.060/abhaya-libre-fonts-1.060.tar.gz to /home/danishka/rpmbuild/SOURCES/abhaya-libre-fonts-1.060.tar.gz > > - Use %autosetup > > %setup -q -c > > then: > > install -m 0644 -p fonts/ttf/AbhayaLibre-Bold.ttf %{buildroot}%{_fontdir} > install -m 0644 -p fonts/ttf/AbhayaLibre-ExtraBold.ttf > %{buildroot}%{_fontdir} > install -m 0644 -p fonts/ttf/AbhayaLibre-Medium.ttf %{buildroot}%{_fontdir} > install -m 0644 -p fonts/ttf/AbhayaLibre-Regular.ttf %{buildroot}%{_fontdir} > install -m 0644 -p fonts/ttf/AbhayaLibre-SemiBold.ttf %{buildroot}%{_fontdir} > > - Don't: > > install -m 0755 -d %{buildroot}/usr/share/doc/%{fontname} > install -m 0644 -p abhaya-libre-font-1.060/CONTRIBUTORS.md > %{buildroot}/usr/share/doc/%{fontname} > install -m 0644 -p abhaya-libre-font-1.060/README.md > %{buildroot}/usr/share/doc/%{fontname} > install -m 0644 -p abhaya-libre-font-1.060/OFL.txt > %{buildroot}/usr/share/doc/%{fontname} > install -m 0644 -p abhaya-libre-font-1.060/FONTLOG.md > %{buildroot}/usr/share/doc/%{fontname} > > The license file must be installed with %license in %files: > > %license OFL.txt > > The docs should be installed with %doc in %files: > > %doc CONTRIBUTORS.md README.md FONTLOG.md > > - Release should start at 1 in Fedora not 0: > > Release: 0%{?dist} noted.
Btw, I have originally used fontname as abhaya-libre-font as the upstream also use the same name. But when I build the package there was an error >error: line 57: %files -n abhaya-libre-fonts >: package abhaya-libre-fonts does not exist So, I renamed it as abhaya-libre-fonts In order to use a source from upstream, I used the following URL. Source0: https://github.com/mooniak/abhaya-libre-font/archive/v1.060.tar.gz
(In reply to Danishka Navin from comment #2) > Robert, Thanks for taking this package to review. > > (In reply to Robert-André Mauchin from comment #1) > > - Not a valid license shourthand, it should be "OFL": > > > > License: SIL Open Font License > > > > > Ok, I will make it as OFL > > > - Use a better name for your archive: > > > > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > > > > - What is this: > > > > %undefine _disable_source_fetch > > without this rpmbuild looking for the source file in my local. > That's normal and expected. Besides it won't work within Mock/Koji. You can use spectool -g to download the sources: spectool -g *.spec And mockbuild to test your package in a chroot: fedpkg --release f32 mockbuild --mock-config fedora-rawhide-x86_64 (In reply to Danishka Navin from comment #3) > Btw, I have originally used fontname as abhaya-libre-font as the upstream > also use the same name. > > But when I build the package there was an error > > >error: line 57: %files -n abhaya-libre-fonts > >: package abhaya-libre-fonts does not exist > > > So, I renamed it as abhaya-libre-fonts > In order to use a source from upstream, I used the following URL. > Source0: > https://github.com/mooniak/abhaya-libre-font/archive/v1.060.tar.gz Then the correct way to extract the archive should be: %autosetup -n abhaya-libre-font-%{version} Please post updated SPEC/SRPM
Thanks Andrade for your feedback. I have made changes to spec file. https://snavin.fedorapeople.org/packages/abhaya-libre-fonts/abhaya-libre-fonts.spec I still get the following error. [danishka@danishka rpmbuild]$ rpmbuild -ba SPECS/abhaya-libre-fonts.spec error: line 58: %files -n abhaya-libre-fonts : package abhaya-libre-fonts does not exist [danishka@danishka rpmbuild]$ I haven't used fedpkg or koji before. Do I need to configure fedpkg locally? Do I need a seperate account in koji? tried fedpkg as you meantioned but failed. [danishka@danishka rpmbuild]$ spectool -g SPECS/abhaya-libre-fonts.spec Getting https://github.com/mooniak/abhaya-libre-font/archive/v1.060/abhaya-libre-font-1.060.tar.gz to ./abhaya-libre-font-1.060.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 133 100 133 0 0 726 0 --:--:-- --:--:-- --:--:-- 726 100 52.7M 0 52.7M 0 0 7035k 0 --:--:-- 0:00:07 --:--:-- 10.1M [danishka@danishka rpmbuild]$ fedpkg --release f34 mockbuild --mock-config fedora-rawhide-x86_64 sources file doesn't exist. Source files download skipped. Failed to get repository name from Git url or pushurl Could not execute mockbuild: No spec file found. [danishka@danishka rpmbuild]$
Please note that I ran the local build against f30 as my base OS fedora30. Anyway I still get the same error [danishka@danishka abhaya-libre-font]$ spectool -g abhaya-libre-font.spec Getting https://github.com/mooniak/abhaya-libre-font/archive/v1.060/abhaya-libre-font-1.060.tar.gz to ./abhaya-libre-font-1.060.tar.gz % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 133 100 133 0 0 246 0 --:--:-- --:--:-- --:--:-- 245 100 52.7M 0 52.7M 0 0 320k 0 --:--:-- 0:02:48 --:--:-- 1029k [danishka@danishka abhaya-libre-font]$ fedpkg --release f30 local sources file doesn't exist. Source files download skipped. error: line 58: %files -n abhaya-libre-fonts : package abhaya-libre-fonts does not exist error: query of specfile /home/danishka/packaging/abhaya-libre-font/abhaya-libre-font.spec failed, can't parse Could not execute local: Could not get n-v-r-e from /home/danishka/packaging/abhaya-libre-font/abhaya-libre-font.spec [danishka@danishka abhaya-libre-font]$ ls abhaya-libre-font-1.060.tar.gz abhaya-libre-font.metainfo.xml abhaya-libre-font.spec [danishka@danishka abhaya-libre-font]$ [danishka@danishka abhaya-libre-font]$ grep abhaya-libre-fonts abhaya-libre-font.spec Files used: https://snavin.fedorapeople.org/packages/abhaya-libre-fonts/abhaya-libre-font.metainfo.xml https://snavin.fedorapeople.org/packages/abhaya-libre-fonts/abhaya-libre-fonts.spec Could not get the srpm due to above error.
Bump We have new font build system. Try these spec and srpm: https://eclipseo.fedorapeople.org/for-review/mooniak-abhaya-fonts.spec https://eclipseo.fedorapeople.org/for-review/mooniak-abhaya-fonts-1.060-1.fc36.src.rpm
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.