Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/video-downloader/fedora-30-x86_64/01030687-video-downloader/video-downloader.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/video-downloader/fedora-30-x86_64/01030687-video-downloader/video-downloader-0.1.5-3.fc30.src.rpm Description: Download videos from websites with an easy-to-use interface. Provides the following features: - Convert videos to MP3 - Supports password-protected and private videos - Download single videos or whole playlists - Automatically selects a video format based on your preferred resolution Based on youtube-dl. Fedora Account System Username: atim Working COPR: https://copr.fedorainfracloud.org/coprs/atim/video-downloader
I will review this. Replace %{_datadir}/appdata/*.xml to %{_metainfodir}/%{name}.appdata.xml.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)". 19 files have unknown license. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: video-downloader-0.1.5-3.fc32.noarch.rpm video-downloader-0.1.5-3.fc32.src.rpm video-downloader.noarch: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists video-downloader.noarch: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube video-downloader.noarch: W: spelling-error %description -l en_US dl -> fl, d, l video-downloader.noarch: W: no-manual-page-for-binary video-downloader video-downloader.src: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists video-downloader.src: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube video-downloader.src: W: spelling-error %description -l en_US dl -> fl, d, l 2 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_US.utf8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). video-downloader.noarch: W: spelling-error %description -l en_US playlists -> play lists, play-lists, stylists video-downloader.noarch: W: spelling-error %description -l en_US youtube -> you tube, you-tube, YouTube video-downloader.noarch: W: spelling-error %description -l en_US dl -> fl, d, l video-downloader.noarch: W: invalid-url URL: https://github.com/Unrud/video-downloader <urlopen error [Errno -2] Name or service not known> video-downloader.noarch: W: no-manual-page-for-binary video-downloader video-downloader.noarch: E: invalid-appdata-file /usr/share/appdata/com.github.unrud.VideoDownloader.appdata.xml 1 packages and 0 specfiles checked; 1 errors, 5 warnings. Source checksums ---------------- https://github.com/Unrud/video-downloader/archive/0.1.5/video-downloader-0.1.5.tar.gz : CHECKSUM(SHA256) this package : 614d9b58a6a180b8b660ac08d8e4538095a5ef1b0e7176db20ec61c20ebc753a CHECKSUM(SHA256) upstream package : 614d9b58a6a180b8b660ac08d8e4538095a5ef1b0e7176db20ec61c20ebc753a Requires -------- video-downloader (rpmlib, GLIBC filtered): /usr/bin/python3 hicolor-icon-theme python3-pillow-tk python3-xlib Provides -------- video-downloader: application() application(com.github.unrud.VideoDownloader.desktop) metainfo() metainfo(com.github.unrud.VideoDownloader.appdata.xml) video-downloader Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1750376 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Python, R, PHP, C/C++, Ocaml, Perl, Java, SugarActivity, Haskell, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
https://copr-be.cloud.fedoraproject.org/results/atim/video-downloader/fedora-31-x86_64/01030717-video-downloader/video-downloader.spec https://copr-be.cloud.fedoraproject.org/results/atim/video-downloader/fedora-31-x86_64/01030717-video-downloader/video-downloader-0.1.5-5.fc31.src.rpm
https://copr-be.cloud.fedoraproject.org/results/atim/video-downloader/fedora-30-x86_64/01030729-video-downloader/video-downloader.spec https://copr-be.cloud.fedoraproject.org/results/atim/video-downloader/fedora-30-x86_64/01030729-video-downloader/video-downloader-0.1.5-6.fc30.src.rpm
LGTM now. Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/video-downloader
FEDORA-2019-b69ffe01d3 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-b69ffe01d3
video-downloader-0.1.5-6.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-b69ffe01d3
video-downloader-0.1.5-6.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.