Spec URL: https://atim.fedorapeople.org/for-review/python-pycryptodome.spec SRPM URL: https://atim.fedorapeople.org/for-review/python-pycryptodome-3.9.0-1.fc30.src.rpm Description: PyCryptodome is a self-contained Python package of low-level cryptographic primitives. Fedora Account System Username: atim
Are you sure this is actually any different from python-pycryptodomex? https://apps.fedoraproject.org/packages/python-pycryptodomex
(In reply to Elliott Sales de Andrade from comment #1) From RHBZ#1750590 https://bugzilla.redhat.com/show_bug.cgi?id=1750590: - pycryptodome - an almost drop-in replacement for the old PyCrypto library - pycryptodomex (already packaged in Fedora) - a library independent of the old PyCrypto ! One must avoid having both PyCrypto and PyCryptodome installed at the same time, as they will interfere with each other. Source: https://github.com/Legrandin/pycryptodome I tried to build Password Safe with 'python-pycryptodomex' but no luck unfortunately.
- BSD, Public Domain, Apache not valid license shorthands, it should be: License: BSD and Public Domain and ASL 2.0 - Use %pypi_source: Source0: %{pypi_source} - Not need to include all the Licenses, they are all in the root license file already. No need to include tests readme either: %files -n python3-%{pypi_name} %license LICENSE.rst %doc README.rst Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License", "*No copyright* BSD (unspecified)", "*No copyright* Public domain", "*No copyright* Public domain BSD (unspecified)", "BSD (unspecified)", "*No copyright* GNU General Public License". 538 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/python-pycryptodome/review-python- pycryptodome/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/python3.8/site- packages/Crypto(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/Cipher(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/Cipher/__pycache__(python3-crypto), /usr/lib64/python3.8/site-packages/Crypto/Hash(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/Hash/__pycache__(python3-crypto), /usr/lib64/python3.8/site-packages/Crypto/Protocol(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/Protocol/__pycache__(python3-crypto), /usr/lib64/python3.8/site-packages/Crypto/PublicKey(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/PublicKey/__pycache__(python3-crypto), /usr/lib64/python3.8/site-packages/Crypto/Random(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/Random/__pycache__(python3-crypto), /usr/lib64/python3.8/site-packages/Crypto/SelfTest(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Cipher(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Cipher/__pycache__(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Hash(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Hash/__pycache__(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Protocol(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Protocol/__pycache__(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/PublicKey(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/PublicKey/__pycache__(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Random(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Random/__pycache__(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Signature(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Signature/__pycache__(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Util(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/Util/__pycache__(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/SelfTest/__pycache__(python3-crypto), /usr/lib64/python3.8/site-packages/Crypto/Signature(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/Signature/__pycache__(python3-crypto), /usr/lib64/python3.8/site-packages/Crypto/Util(python3-crypto), /usr/lib64/python3.8/site- packages/Crypto/Util/__pycache__(python3-crypto), /usr/lib64/python3.8/site-packages/Crypto/__pycache__(python3-crypto) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-pycryptodome [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pycryptodome-3.9.0-1.fc32.x86_64.rpm python-pycryptodome-debugsource-3.9.0-1.fc32.x86_64.rpm python-pycryptodome-3.9.0-1.fc32.src.rpm python3-pycryptodome.x86_64: W: spelling-error Summary(en_US) Cryptographic -> Cryptography, Cryptographer, Crystallographic python3-pycryptodome.x86_64: W: invalid-license BSD, Public Domain, Apache python3-pycryptodome.x86_64: E: zero-length /usr/lib64/python3.8/site-packages/Crypto/Hash/__init__.pyi python3-pycryptodome.x86_64: E: zero-length /usr/lib64/python3.8/site-packages/Crypto/PublicKey/__init__.pyi python3-pycryptodome.x86_64: W: pem-certificate /usr/lib64/python3.8/site-packages/Crypto/SelfTest/PublicKey/test_vectors/ECC/ecc_p256_x509.pem python3-pycryptodome.x86_64: W: pem-certificate /usr/lib64/python3.8/site-packages/Crypto/SelfTest/PublicKey/test_vectors/ECC/ecc_p384_x509.pem python3-pycryptodome.x86_64: W: pem-certificate /usr/lib64/python3.8/site-packages/Crypto/SelfTest/PublicKey/test_vectors/ECC/ecc_p521_x509.pem python3-pycryptodome.x86_64: E: non-executable-script /usr/lib64/python3.8/site-packages/Crypto/SelfTest/PublicKey/test_vectors/ECC/gen_ecc_p256.sh 644 /bin/sh python3-pycryptodome.x86_64: E: non-executable-script /usr/lib64/python3.8/site-packages/Crypto/SelfTest/PublicKey/test_vectors/ECC/gen_ecc_p384.sh 644 /bin/sh python3-pycryptodome.x86_64: E: non-executable-script /usr/lib64/python3.8/site-packages/Crypto/SelfTest/PublicKey/test_vectors/ECC/gen_ecc_p521.sh 644 /bin/sh python3-pycryptodome.x86_64: E: non-executable-script /usr/lib64/python3.8/site-packages/Crypto/SelfTest/PublicKey/test_vectors/RSA/gen_rsa_2048.sh 644 /bin/sh python3-pycryptodome.x86_64: E: non-executable-script /usr/lib64/python3.8/site-packages/Crypto/SelfTest/__main__.py 644 /usr/bin/env python python3-pycryptodome.x86_64: E: zero-length /usr/lib64/python3.8/site-packages/Crypto/py.typed python3-pycryptodome.x86_64: E: backup-file-in-package /usr/share/licenses/python3-pycryptodome/LICENSE.orig python-pycryptodome-debugsource.x86_64: W: invalid-license BSD, Public Domain, Apache python-pycryptodome.src: W: spelling-error Summary(en_US) Cryptographic -> Cryptography, Cryptographer, Crystallographic python-pycryptodome.src: W: invalid-license BSD, Public Domain, Apache 3 packages and 0 specfiles checked; 9 errors, 8 warnings.
(In reply to Artem from comment #2) > (In reply to Elliott Sales de Andrade from comment #1) > > From RHBZ#1750590 https://bugzilla.redhat.com/show_bug.cgi?id=1750590: > > - pycryptodome - an almost drop-in replacement for the old PyCrypto library > - pycryptodomex (already packaged in Fedora) - a library independent of the > old PyCrypto > > ! One must avoid having both PyCrypto and PyCryptodome installed at the same > time, as they will interfere with each other. > Yes, because PyCryptodome installs to the same location as the PyCrypto package. But pycryptodomex is still the _same_ package, just with a different import path. > Source: https://github.com/Legrandin/pycryptodome > > I tried to build Password Safe with 'python-pycryptodomex' but no luck > unfortunately. Yes, it's installed to PyCryptodome; you need to patch Password Safe to use that import instead. More than one package depends on PyCrypto, so using this proposed pycryptodome will cause Conflicts that could be avoided by using pycryptodomex.
gnome-passwordsafe built with system 'python-pycryptodomex' so we don't need this python-pycryptodome' https://bodhi.fedoraproject.org/updates/FEDORA-2019-5fc014f121