Spec URL: https://copr-be.cloud.fedoraproject.org/results/filbranden/oomd/fedora-rawhide-x86_64/01031429-oomd/oomd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/filbranden/oomd/srpm-builds/01031429/oomd-0.2.0-1.fc30.src.rpm Description: Userspace Out-Of-Memory (OOM) killer for linux systems. Fedora Account System Username: filbranden
> Summary: Userspace Out-Of-Memory (OOM) killer for linux systems. Please remove '.' at the end of the line. > License: GPLv2 Can you clarify that it is not GPLv2+? > Source0: https://github.com/facebookincubator/oomd/archive/v0.2.0.tar.gz Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz > BuildRequires: meson >= 0.45 Just BuildRequires: meson (if 0.45+ is needed, specify it in upstream too). > BuildRequires: jsoncpp-devel > BuildRequires: systemd-devel > BuildRequires: gtest-devel > BuildRequires: gmock-devel BuildRequires: pkgconfig(jsoncpp) BuildRequires: pkgconfig(libsystemd) BuildRequires: pkgconfig(gtest_main) BuildRequires: pkgconfig(gmock) > %setup -q -n %{name}-%{version} %autosetup > %{!?_licensedir:%global license %%doc} This is not needed for really really long time.
Hi Igor! Thanks for taking this review! I prepared a new spec file and build based on your comments: Spec URL: https://copr-be.cloud.fedoraproject.org/results/filbranden/oomd/fedora-rawhide-x86_64/01031955-oomd/oomd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/filbranden/oomd/srpm-builds/01031955/oomd-0.2.0-2.fc30.src.rpm > > Summary: Userspace Out-Of-Memory (OOM) killer for linux systems. > > Please remove '.' at the end of the line. Done. Also removed "for linux systems", simply "Userspace Out-Of-Memory (OOM) killer" is enough here. > > License: GPLv2 > > Can you clarify that it is not GPLv2+? That's correct, it's GPLv2 only, not GPLv2 or later. (See https://github.com/facebookincubator/oomd#license) > Source0: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz Ah nice! I was looking for so long for the GitHub URL that gives me a tarball including the package name and for the life of me couldn't find it... Thanks a bunch for that! > > BuildRequires: meson >= 0.45 > > Just BuildRequires: meson (if 0.45+ is needed, specify it in upstream too). I just checked and while Meson 0.44 works, it displays a warning ("WARNING: Passed invalid keyword argument 'main' in meson.build line 144.") due to issue https://github.com/mesonbuild/meson/issues/2828 Meson 0.43 doesn't work at all ("Value 'c++17' for combo option 'cpp_std' is not one of the choices.") Since there's a warning, I'd prefer to keep the dependency on 0.45 and not 0.44 (do you agree?) I'm happy to push a PR to document that upstream. That would be here (https://github.com/facebookincubator/oomd#building-and-installing), right? Thanks! Filipe
There is special keyword in project() called meson_version. Also, use %license LICENSE to denote license file. Rest looks good.
> There is special keyword in project() called meson_version. Ah, of course! I just pushed a new PR for that: https://github.com/facebookincubator/oomd/pull/102 Should be included in the next upstream release. > Also, use %license LICENSE to denote license file. 🤦 Fixed now. Spec URL: https://copr-be.cloud.fedoraproject.org/results/filbranden/oomd/fedora-31-x86_64/01032075-oomd/oomd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/filbranden/oomd/srpm-builds/01032075/oomd-0.2.0-3.fc30.src.rpm > Rest looks good. Awesome! So next step is `fedpkg request-repo`, correct? I'll go ahead and execute that. Thanks for the very quick reviews, Igor! Cheers, Filipe
https://pagure.io/releng/fedora-scm-requests/issue/16645
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/oomd
Packages built! rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1376965 f31: https://koji.fedoraproject.org/koji/buildinfo?buildID=1376974 f30: https://koji.fedoraproject.org/koji/buildinfo?buildID=1376978 Should I add it to "updates" for f31 and f30? Should I add it to comps.xml? (Steps 13 and 14 from https://fedoraproject.org/wiki/New_package_process_for_existing_contributors) Thanks! Filipe
(In reply to Filipe Brandenburger from comment #7) > Packages built! :champagne: \o/ > rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1376965 > f31: https://koji.fedoraproject.org/koji/buildinfo?buildID=1376974 > f30: https://koji.fedoraproject.org/koji/buildinfo?buildID=1376978 > > Should I add it to "updates" for f31 and f30? Yes. You need to submit Bodhi updates. > Should I add it to comps.xml? Well, you'd need to discuss it with Workstation WG. Just adding packages is not good idea. Open a ticket on https://pagure.io/fedora-workstation.
FEDORA-2019-a92a124efe has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-a92a124efe
FEDORA-2019-c1d03c403b has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c1d03c403b
> > Should I add it to "updates" for f31 and f30? > > Yes. You need to submit Bodhi updates. Awesome, that's now done (as reported to the bug.) > > Should I add it to comps.xml? > > Well, you'd need to discuss it with Workstation WG. Just adding packages is not good idea. Open a ticket on https://pagure.io/fedora-workstation. Ah, I actually think it's not really appropriate to add it at this point... Was asking here mostly to confirm that. Will leave that out for now. Thanks for all your help! Cheers, Filipe
oomd-0.2.0-4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c1d03c403b
oomd-0.2.0-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-a92a124efe
oomd-0.2.0-4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
oomd-0.2.0-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.