1751431 – "guest-get-memory-block-info" is enabled but in fact it is not currently supported

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1751431 - "guest-get-memory-block-info" is enabled but in fact it is not currently supported

Summary: "guest-get-memory-block-info" is enabled but in fact it is not currently supp...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 8
Classification:	Red Hat
Component:	virtio-win
Sub Component:
Version:	8.2
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	unspecified
Target Milestone:	rc
Target Release:	8.2
Assignee:	Basil Salman
QA Contact:	xiagao
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:	1779884
TreeView+	depends on / blocked

Reported:	2019-09-12 01:33 UTC by xiagao
Modified:	2022-05-11 09:42 UTC (History)
CC List:	5 users (show)
Fixed In Version:
Doc Type:	If docs needed, set a value
Doc Text:
Clone Of:
Clones:	1779884 (view as bug list)
Environment:
Last Closed:	2020-02-04 12:27:28 UTC
Type:	Bug
Target Upstream Version:
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Issue Tracker	RHELPLAN-28600	0	None	None	None	2022-05-11 09:42:03 UTC

Description xiagao 2019-09-12 01:33:25 UTC

Description of problem:
as $summary

Version-Release number of selected component (if applicable):
mingw-qemu-ga-win-100.0.0.0-3.el7ev

How reproducible:
100%

Steps to Reproduce:
1.boot win2019 guest with qemu-ga-win msi installed

2.issue guest-info cmd from host
# nc -U /tmp/helloworld2
{"execute":"guest-info"}
{"return": {"version": "100.0.0", "supported_commands": [
......
{"enabled": true, "name": "guest-get-memory-block-info", "success-response": true}, 
{"enabled": false, "name": "guest-set-memory-blocks", "success-response": true}, 
{"enabled": false, "name": "guest-get-memory-blocks", "success-response": true}, 
......


3.Since "guest-get-memory-block-info" is enabled, issue "guest-get-memory-block-info" cmd.
{"execute":"guest-get-memory-block-info"}
{"error": {"class": "GenericError", "desc": "this feature or command is not currently supported"}}

Expected results:
"guest-get-memory-block-info" should be disabled like "guest-get-memory-blocks" if it's not currently supported.

Additional info:
{"execute":"guest-info"}
{"return": {"version": "100.0.0", "supported_commands": [
{"enabled": true, "name": "guest-get-osinfo", "success-response": true}, 
{"enabled": true, "name": "guest-get-timezone", "success-response": true}, 
{"enabled": true, "name": "guest-get-users", "success-response": true}, 
{"enabled": true, "name": "guest-get-host-name", "success-response": true}, 
{"enabled": true, "name": "guest-exec", "success-response": true}, 
{"enabled": true, "name": "guest-exec-status", "success-response": true}, 
{"enabled": true, "name": "guest-get-memory-block-info", "success-response": true}, 
{"enabled": false, "name": "guest-set-memory-blocks", "success-response": true}, 
{"enabled": false, "name": "guest-get-memory-blocks", "success-response": true}, 
{"enabled": true, "name": "guest-set-user-password", "success-response": true}, 
{"enabled": true, "name": "guest-get-fsinfo", "success-response": true}, 
{"enabled": false, "name": "guest-set-vcpus", "success-response": true}, 
{"enabled": true, "name": "guest-get-vcpus", "success-response": true}, 
{"enabled": true, "name": "guest-network-get-interfaces", "success-response": true}, 
{"enabled": false, "name": "guest-suspend-hybrid", "success-response": false}, 
{"enabled": true, "name": "guest-suspend-ram", "success-response": false}, 
{"enabled": true, "name": "guest-suspend-disk", "success-response": false}, 
{"enabled": true, "name": "guest-fstrim", "success-response": true}, 
{"enabled": true, "name": "guest-fsfreeze-thaw", "success-response": true}, 
{"enabled": true, "name": "guest-fsfreeze-freeze-list", "success-response": true}, 
{"enabled": true, "name": "guest-fsfreeze-freeze", "success-response": true}, 
{"enabled": true, "name": "guest-fsfreeze-status", "success-response": true}, 
{"enabled": true, "name": "guest-file-flush", "success-response": true}, 
{"enabled": true, "name": "guest-file-seek", "success-response": true}, 
{"enabled": true, "name": "guest-file-write", "success-response": true}, 
{"enabled": true, "name": "guest-file-read", "success-response": true}, 
{"enabled": true, "name": "guest-file-close", "success-response": true}, 
{"enabled": true, "name": "guest-file-open", "success-response": true}, 
{"enabled": true, "name": "guest-shutdown", "success-response": false}, 
{"enabled": true, "name": "guest-info", "success-response": true}, 
{"enabled": true, "name": "guest-set-time", "success-response": true}, 
{"enabled": true, "name": "guest-get-time", "success-response": true}, 
{"enabled": true, "name": "guest-ping", "success-response": true}, 
{"enabled": true, "name": "guest-sync", "success-response": true}, 
{"enabled": true, "name": "guest-sync-delimited", "success-response": true}
]}}

Comment 1 Basil Salman 2019-10-27 11:51:04 UTC

"guest-get-memory-block-info" command was added to blacklist for Windows systems and Linux system that don't use sysfs,
since this command is not supported for such systems and will be shown as disabled for these systems.

sent patches to qemu-devel:
https://lists.nongnu.org/archive/html/qemu-devel/2019-10/msg04112.html

Comment 2 Basil Salman 2019-10-31 13:20:58 UTC

The build with the fix:
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=995415

Comment 5 xiagao 2019-11-06 04:45:32 UTC

Test with mingw-qemu-ga-win-101.0.0.0-3.el7ev, "guest-set-memory-blocks" command is disabled.
...
 {"enabled": false, "name": "guest-set-memory-blocks", "success-response": true}, 
 {"enabled": false, "name": "guest-get-memory-blocks", "success-response": true}, 
 {"enabled": true, "name": "guest-set-user-password", "success-response": true}, 

...

So change status to verified.

Comment 6 xiagao 2019-11-06 04:50:50 UTC

(In reply to Basil Salman from comment #1)
> "guest-get-memory-block-info" command was added to blacklist for Windows
> systems and Linux system that don't use sysfs,

Basil Salman, hi

To avoid some mistake, I want to confirm with you something,you mean to disable "guest-get-memory-block-info" command for both linux system and windows system?
As far as I know,"guest-get-memory-block-info" command is supported for linux guest.


> since this command is not supported for such systems and will be shown as
> disabled for these systems.
> 
> sent patches to qemu-devel:
> https://lists.nongnu.org/archive/html/qemu-devel/2019-10/msg04112.html

Comment 7 Basil Salman 2019-11-07 09:45:03 UTC

(In reply to xiagao from comment #6)
> (In reply to Basil Salman from comment #1)
> > "guest-get-memory-block-info" command was added to blacklist for Windows
> > systems and Linux system that don't use sysfs,
Hi,

"guest-get-memory-block-info" was disabled for Windows guests and for Linux systems that do not use sysfs specifically.
in this case it was not disabled for all linux guests, but only for Linux guests that don't support it.
according to Qemu-ga code in upstream this type of Linux guests does not support "guest-get-memory-block-info" command in addition to some other commands
that require sysfs.

> Basil Salman, hi
> 
> To avoid some mistake, I want to confirm with you something,you mean to
> disable "guest-get-memory-block-info" command for both linux system and
> windows system?
> As far as I know,"guest-get-memory-block-info" command is supported for
> linux guest.
> 
> 
> > since this command is not supported for such systems and will be shown as
> > disabled for these systems.
> > 
> > sent patches to qemu-devel:
> > https://lists.nongnu.org/archive/html/qemu-devel/2019-10/msg04112.html

Comment 10 errata-xmlrpc 2020-02-04 12:27:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0351

Note You need to log in before you can comment on or make changes to this bug.