We have %py3_build and %py3_install macros - maybe use those?

Shouldn't LICENSE be %license, not %doc?

What's the deal with all the commented-out Requires: lines? Shouldn't those be reviewed and if appropriate updated, or removed?

Per the guidelines - https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ - the package that contains the modules (in this case, there is only one package) *must* Provides: python3-(modulename) for each module - https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_provides . It doesn't matter that this is an application, as long as it's shipping modules installed to the system-wide path it needs to follow the rules for modules. FWIW I would usually separate the modules into one or more subpackages and have the 'binary' in its own package that depended on the module subpackages, but that's not required.

Fixed, thanks.

Spec URL: https://abompard.fedorapeople.org/reviews/bugzilla2fedmsg/bugzilla2fedmsg.spec
SRPM URL: https://abompard.fedorapeople.org/reviews/bugzilla2fedmsg/bugzilla2fedmsg-1.0.0-1.fc30.src.rpm

rpmlint output on SRPM:

bugzilla2fedmsg.src: W: spelling-error %description -l en_US bugzilla -> Bugzilla, ChatZilla
bugzilla2fedmsg.src:44: W: macro-in-comment %{__python3}

both fairly harmless (macro-in-comment is bad if the macro might have a newline in it, but that one's very unlikely to). Could fix 'em if you like.

Right, I've fixed it, thanks.

Any chance for a review here soon?

It's waiting on https://bugzilla.redhat.com/show_bug.cgi?id=1750777 , which is waiting on Aurelien to rename its async module to...something other than async, see #c1 onwards.

OK, the other package is approved now, so reviewing this one (using  my own build of the stompest package to build this against):

[+]    MUST: rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.

[adamw@adam Downloads]$ rpmlint ./bugzilla2fedmsg-1.0.0-1.fc30.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[adamw@adam Downloads]$ rpmlint /var/lib/mock/fedora-31-x86_64/result/bugzilla2fedmsg-1.0.0-1.fc31.noarch.rpm 
bugzilla2fedmsg.noarch: W: no-manual-page-for-binary bugzilla2fedmsg
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

So...arguably since the binary isn't really intended to be run by humans, it should got /usr/libexec rather than /usr/bin . Per the FHS, /usr/bin is for "user commands" while /usr/libexec is for "Binaries run by other programs". I'm not going to block the review on this, though.

[+]    MUST: The package must be named according to the Package Naming Guidelines .
[+]    MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[+]    MUST: The package must meet the Packaging Guidelines .
[+]    MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
[+]    MUST: The License field in the package spec file must match the actual license.
[+]    MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license.
[+]    MUST: The spec file must be written in American English.
[+]    MUST: The spec file for the package MUST be legible.
[+]    MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
[+]    MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[NA]   MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[+]    MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
[NA]   MUST: The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[NA]   MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[+]    MUST: Packages must NOT bundle copies of system libraries.
[NA]   MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[+]    MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[+]    MUST: A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations)
[+]    MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[+]    MUST: Each package must consistently use macros.
[+]    MUST: The package must contain code, or permissible content.
[NA]   MUST: Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[+]    MUST: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[NA]   MUST: Static libraries must be in a -static package.
[NA]   MUST: Development files must be in a -devel package.
[NA]   MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[+]    MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[NA]   MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[+]    MUST: Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
[+]    MUST: All filenames in rpm packages must be valid UTF-8.
[+]    MUST: Packages being added to the distribution MUST NOT depend on any packages which have been marked as being deprecated.

And with that review is approved, thanks.

ping abompard? time to import + build?

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/bugzilla2fedmsg

Package is in repos