Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://raw.githubusercontent.com/Vascom/svt-vp9/master/svt-vp9.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/4483/37644483/svt-vp9-0-1.20190906gite9653d9.fc32.src.rpm Description: The Scalable Video Technology for VP9 Encoder (SVT-VP9 Encoder) is a VP9-compliant encoder library core. The SVT-VP9 Encoder development is a work-in-progress targeting performance levels applicable to both VOD and Live encoding/transcoding video applications. The SVT-VP9 Encoder is being optimized to achieve excellent performance levels currently supporting 10 density-quality presets (please refer to the user guide for more details) on a system with a dual Intel® Xeon® Scalable processor targeting: Real-time encoding of up to two 4Kp60 streams on the Gold 6140 with M8. SVT-VP9 Encoder also supports 3 modes: A visually optimized mode for visual quality (-tune 0) An PSNR/SSIM optimized mode for PSNR / SSIM benchmarking (-tune 1 (Default setting)) An VMAF optimized mode for VMAF benchmarking (-tune 2)
I will review this.
> # Patch build gstreamer plugin Just use one one sed command: sed -e "/svtvp9enc_dep =/d" -e "s|install: true,|install: true, include_directories : '../Source/API', link_args : '-lSvtVp9Enc',|" -e "s|, svtvp9enc_dep||" -e "s|svtvp9enc_dep.found()|true|" -i gstreamer-plugin/meson.build > mkdir -p release mkdir -p %{_target_platform} > pushd release > %cmake3 \ > -DCMAKE_SKIP_BUILD_RPATH=TRUE \ > .. > %make_build > popd pushd %{_target_platform} %cmake -G Ninja \ -DCMAKE_SKIP_BUILD_RPATH=TRUE \ .. popd %ninja_build -C %{_target_platform} > pushd gstreamer-plugin > export LIBRARY_PATH="$PWD/../Bin/Release:$LIBRARY_PATH" > %meson > %meson_build > popd %meson_build -C gstreamer-plugin > pushd release > %make_install > popd > pushd gstreamer-plugin > %meson_install > popd %ninja_install -C %{_target_platform} %meson_install -C gstreamer-plugin > export LIBRARY_PATH="$PWD/../Bin/Release:$LIBRARY_PATH" Do you really need this during build? > %{_libdir}/gstreamer-1.0/libgstsvtvp9enc.so Add Requires: gstreamer1-plugins-base%{?_isa}.
1. In order to avoid unintentional soname bump, we forbid globbing the major soname version, be more specific instead: %{_libdir}/libSvtVp9Enc.so.1 -> %{_libdir}/libSvtVp9Enc.so.1* 2. fedora-review tool say that license is incorrect but it correct according to this list https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses 3. There few more licenses found and probably should add MIT and BSD BSD 2-clause "Simplified" License --------------------------------- OpenVisualCloud-SVT-VP9-e9653d9/LICENSE.md BSD 3-clause "New" or "Revised" License --------------------------------------- OpenVisualCloud-SVT-VP9-e9653d9/Source/Lib/VPX/LICENSE Expat License ------------- OpenVisualCloud-SVT-VP9-e9653d9/Source/App/EbAppFifo.c ISC License ----------- OpenVisualCloud-SVT-VP9-e9653d9/Source/Lib/ASM_SSE2/x86inc.asm 4. Package should not depend on package which is not available in official Fedora repo.
Spec URL: https://raw.githubusercontent.com/Vascom/svt-vp9/master/svt-vp9.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/6732/37646732/svt-vp9-0-1.20190906gite9653d9.fc32.src.rpm All done.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License", "Expat License", "ISC License", "BSD 3-clause "New" or "Revised" License". 348 files have unknown license. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in svt-vp9 , svt-vp9-devel , gstreamer1-svt-vp9 [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: svt-vp9-0-1.20190906gite9653d9.fc32.x86_64.rpm svt-vp9-devel-0-1.20190906gite9653d9.fc32.x86_64.rpm gstreamer1-svt-vp9-0-1.20190906gite9653d9.fc32.x86_64.rpm svt-vp9-debuginfo-0-1.20190906gite9653d9.fc32.x86_64.rpm svt-vp9-debugsource-0-1.20190906gite9653d9.fc32.x86_64.rpm svt-vp9-0-1.20190906gite9653d9.fc32.src.rpm svt-vp9.x86_64: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable svt-vp9.x86_64: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending svt-vp9.x86_64: W: invalid-license BSD-2-Clause-Patent svt-vp9.x86_64: W: shared-lib-calls-exit /usr/lib64/libSvtVp9Enc.so.1 exit.5 svt-vp9.x86_64: W: executable-stack /usr/lib64/libSvtVp9Enc.so.1 svt-vp9.x86_64: W: no-manual-page-for-binary SvtVp9EncApp svt-vp9-devel.x86_64: W: invalid-license BSD-2-Clause-Patent svt-vp9-devel.x86_64: W: no-documentation gstreamer1-svt-vp9.x86_64: W: invalid-license BSD-2-Clause-Patent gstreamer1-svt-vp9.x86_64: W: no-documentation svt-vp9-debuginfo.x86_64: W: invalid-license BSD-2-Clause-Patent svt-vp9-debugsource.x86_64: W: invalid-license BSD-2-Clause-Patent svt-vp9.src: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable svt-vp9.src: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending svt-vp9.src: W: invalid-license BSD-2-Clause-Patent 6 packages and 0 specfiles checked; 0 errors, 15 warnings. Rpmlint (debuginfo) ------------------- Checking: svt-vp9-debuginfo-0-1.20190906gite9653d9.fc32.x86_64.rpm svt-vp9-debuginfo.x86_64: W: invalid-license BSD-2-Clause-Patent 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). gstreamer1-svt-vp9.x86_64: W: invalid-license BSD-2-Clause-Patent gstreamer1-svt-vp9.x86_64: W: invalid-url URL: https://github.com/OpenVisualCloud/SVT-VP9 <urlopen error [Errno -2] Name or service not known> gstreamer1-svt-vp9.x86_64: W: no-documentation svt-vp9-debugsource.x86_64: W: invalid-license BSD-2-Clause-Patent svt-vp9-debugsource.x86_64: W: invalid-url URL: https://github.com/OpenVisualCloud/SVT-VP9 <urlopen error [Errno -2] Name or service not known> svt-vp9-debuginfo.x86_64: W: invalid-license BSD-2-Clause-Patent svt-vp9-debuginfo.x86_64: W: invalid-url URL: https://github.com/OpenVisualCloud/SVT-VP9 <urlopen error [Errno -2] Name or service not known> svt-vp9.x86_64: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable svt-vp9.x86_64: W: spelling-error %description -l en_US transcoding -> trans coding, trans-coding, transcending svt-vp9.x86_64: W: invalid-license BSD-2-Clause-Patent svt-vp9.x86_64: W: invalid-url URL: https://github.com/OpenVisualCloud/SVT-VP9 <urlopen error [Errno -2] Name or service not known> svt-vp9.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSvtVp9Enc.so.1 sem_post svt-vp9.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSvtVp9Enc.so.1 sem_wait svt-vp9.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSvtVp9Enc.so.1 sem_init svt-vp9.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSvtVp9Enc.so.1 pthread_join svt-vp9.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSvtVp9Enc.so.1 pthread_create svt-vp9.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSvtVp9Enc.so.1 sem_destroy svt-vp9.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSvtVp9Enc.so.1 pthread_setaffinity_np svt-vp9.x86_64: W: undefined-non-weak-symbol /usr/lib64/libSvtVp9Enc.so.1 pthread_cancel svt-vp9.x86_64: W: shared-lib-calls-exit /usr/lib64/libSvtVp9Enc.so.1 exit.5 svt-vp9.x86_64: W: executable-stack /usr/lib64/libSvtVp9Enc.so.1 svt-vp9.x86_64: W: no-manual-page-for-binary SvtVp9EncApp svt-vp9-devel.x86_64: W: invalid-license BSD-2-Clause-Patent svt-vp9-devel.x86_64: W: invalid-url URL: https://github.com/OpenVisualCloud/SVT-VP9 <urlopen error [Errno -2] Name or service not known> svt-vp9-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 25 warnings. Unversioned so-files -------------------- gstreamer1-svt-vp9: /usr/lib64/gstreamer-1.0/libgstsvtvp9enc.so Source checksums ---------------- https://github.com/OpenVisualCloud/SVT-VP9/tarball/e9653d92e9515bfc14d27b8aef51d8e5817b3601 : CHECKSUM(SHA256) this package : 1e2f86b79c7527da496c7ae096bd11061bb0d04adbb5807b1a79b9a712e60c0b CHECKSUM(SHA256) upstream package : 1e2f86b79c7527da496c7ae096bd11061bb0d04adbb5807b1a79b9a712e60c0b Requires -------- svt-vp9 (rpmlib, GLIBC filtered): libSvtVp9Enc.so.1()(64bit) libSvtVp9Enc.so.1(SVT_VP9_0)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) svt-vp9-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libSvtVp9Enc.so.1()(64bit) svt-vp9(x86-64) gstreamer1-svt-vp9 (rpmlib, GLIBC filtered): gstreamer1-plugins-base(x86-64) libSvtVp9Enc.so.1()(64bit) libSvtVp9Enc.so.1(SVT_VP9_0)(64bit) libc.so.6()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgstvideo-1.0.so.0()(64bit) rtld(GNU_HASH) svt-vp9-debuginfo (rpmlib, GLIBC filtered): svt-vp9-debugsource (rpmlib, GLIBC filtered): Provides -------- svt-vp9: libSvtVp9Enc.so.1()(64bit) libSvtVp9Enc.so.1(SVT_VP9_0)(64bit) svt-vp9 svt-vp9(x86-64) svt-vp9-devel: pkgconfig(SvtVp9Enc) svt-vp9-devel svt-vp9-devel(x86-64) gstreamer1-svt-vp9: gstreamer1(element-svtvp9enc)()(64bit) gstreamer1(encoder-video/x-vp9)()(64bit) gstreamer1-svt-vp9 gstreamer1-svt-vp9(x86-64) libgstsvtvp9enc.so()(64bit) svt-vp9-debuginfo: debuginfo(build-id) svt-vp9-debuginfo svt-vp9-debuginfo(x86-64) svt-vp9-debugsource: svt-vp9-debugsource svt-vp9-debugsource(x86-64) Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -b 1751987 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: R, SugarActivity, Perl, fonts, PHP, Ocaml, Python, Haskell, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Please remove custom compiler flags -O2 -O3 from meson build script to use Fedora standard flags. This minor issue can be fixed during package import. Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/svt-vp9