Spec URL: https://hobbes1069.fedorapeople.org//Coin4.spec SRPM URL: https://hobbes1069.fedorapeople.org//Coin4-4.0.0-1.fc30.src.rpm Description: Coin is a 3D graphics library with an Application Programming Interface based on the Open Inventor 2.1 API.
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=37672923
Naming: Coin4 → coin4 [https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_general_naming] Provides:Coin4 can be added. Requires: zlib-devel bzip2-devel → one per line please %description devel → there should be a dot at the end of the text. Looks all nice. Though I wonder one thing: is is worth to bother with alternatives? Maybe just make coin*-devel packages Conflict with each other? The user doesn't get much benefit either way: it is still not possible to build against multiple Coin versions at the same time, and conflicting packages are easier to implement.
fedora-review says: - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 127211520 bytes in 4678 files. Yep, /usr/share/doc/Coin4/html should move to -doc subpackage.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > Naming: Coin4 → coin4 > [https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > #_general_naming] > Provides:Coin4 can be added. I'm not necessarily against this but I was trying to stay consistent with Coin2 and Coin3 already in Fedora... > Requires: zlib-devel bzip2-devel > → one per line please > > %description devel → there should be a dot at the end of the text. Fixed. > Looks all nice. Though I wonder one thing: is is worth to bother with > alternatives? > Maybe just make coin*-devel packages Conflict with each other? The user > doesn't get > much benefit either way: it is still not possible to build against multiple > Coin versions > at the same time, and conflicting packages are easier to implement. Yeah, I considered both but decided to stay consistent with Ralf's packages as it does let you switch between them if you are actively developing with the Coin3D stack, but yes, it serves no purpose on Fedora Infra. (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > fedora-review says: > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 127211520 bytes in 4678 files. > > Yep, /usr/share/doc/Coin4/html should move to -doc subpackage. Yeah, the guidelines are somewhat ambiguous here... so <name>-doc or <name>-devel-doc? :)
(In reply to Richard Shaw from comment #4) > (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > > Naming: Coin4 → coin4 > > [https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > > #_general_naming] > > Provides:Coin4 can be added. > > I'm not necessarily against this but I was trying to stay consistent with > Coin2 and Coin3 already in Fedora... Yeah. The guidelines say "SHOULD" so it's your choice. I try to push all new packages to use lowercase, but that's just a preference. > > Though I wonder one thing: is is worth to bother with > > alternatives? > > Maybe just make coin*-devel packages Conflict with each other? The user > > doesn't get > > much benefit either way: it is still not possible to build against multiple > > Coin versions > > at the same time, and conflicting packages are easier to implement. > > Yeah, I considered both but decided to stay consistent with Ralf's packages > as it does let you switch between them if you are actively developing with > the Coin3D stack, but yes, it serves no purpose on Fedora Infra. OK. > (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > > fedora-review says: > > - Large documentation must go in a -doc subpackage. Large could be size > > (~1MB) or number of files. > > Note: Documentation size is 127211520 bytes in 4678 files. > > > > Yep, /usr/share/doc/Coin4/html should move to -doc subpackage. > > Yeah, the guidelines are somewhat ambiguous here... so <name>-doc or > <name>-devel-doc? :) <name>-doc.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5) > (In reply to Richard Shaw from comment #4) > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #2) > > > Naming: Coin4 → coin4 > > > [https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > > > #_general_naming] > > > Provides:Coin4 can be added. > > > > I'm not necessarily against this but I was trying to stay consistent with > > Coin2 and Coin3 already in Fedora... > > Yeah. The guidelines say "SHOULD" so it's your choice. I try to push all new > packages to use lowercase, but that's just a preference. After thinking about it a bit I'm seriously considering just calling it "coin" that's what Debian does (well libcoin for the resultant package) and the provided RPM Spec calls it "Coin". Considering that typically when you have multiple major versions the number at the end of the package would be the soversion (not the release version) but I think that Coin2 and Coin3 are close enough :) So probably call this just plain "coin" as it's the latest release and do a Proivdes: Coin4 for consistency. I'll do the same for the -devel package. > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #3) > > > fedora-review says: > > > - Large documentation must go in a -doc subpackage. Large could be size > > > (~1MB) or number of files. > > > Note: Documentation size is 127211520 bytes in 4678 files. > > > > > > Yep, /usr/share/doc/Coin4/html should move to -doc subpackage. > > > > Yeah, the guidelines are somewhat ambiguous here... so <name>-doc or > > <name>-devel-doc? :) > > <name>-doc. I agree in principle, as that's what the guidelines say, but the don't cover the fact that some of it is end user documentation (-doc) where in this case it's only useful for developers, hence my thoughts to call it -devel-doc.
I think it's OK to have just once package with all the docs... This satisfies the main optimization, namely that this doesn't get pulled in through deps and on the buildroot. Real users don't care about a few megs.
SPEC: https://hobbes1069.fedorapeople.org/coin.spec SRPM: https://hobbes1069.fedorapeople.org/coin-4.0.0-2.fc30.src.rpm * Tue Sep 17 2019 Richard Shaw <hobbes1069> - 4.0.0-2 - Update spec file per reviewer comments. - Change package name from Coin4 to coin.
I've been fighting other freecad issues so I wasn't too worried, but any feedback on my updates?
+ package name is OK + latest version + license is acceptable for Fedora + license is specified correctly (*) + builds and installs OK + BR/R/P look ok (*) I think the license can be simplified to just "BSD". BSD can always be "upgraded" to GPLv3. Package is APPROVED.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #10) > > (*) I think the license can be simplified to just "BSD". BSD can always be > "upgraded" to GPLv3. I've done that in the past but the Fedora packaging license page doesn't specifically address it as far as I can tell, only GPL style licenses. I'll ask at some point but yeah, doesn't hurt anything. > Package is APPROVED. Thanks for the review!
Bah, coin is already taken... Guess I have to change to coin4.
Ok, let's talk about this one more time... Since I can't have the name "coin" I'm thinking I should go ahead and use "Coin4" for consistency with Coin2 and Coin3. I think consistency with the other packages is more important than the naming guidelines.
(In reply to Richard Shaw from comment #13) > Ok, let's talk about this one more time... Since I can't have the name > "coin" I'm thinking I should go ahead and use "Coin4" for consistency with > Coin2 and Coin3. I think consistency with the other packages is more > important than the naming guidelines. Oh, I should have checked that. Coin4 is fine as the second choice. Please go ahead.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/Coin4
FEDORA-2019-e1fbb1c109 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-e1fbb1c109
Coin4-4.0.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d756edf752
Coin4-4.0.0-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-e1fbb1c109
Coin4-4.0.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
Coin4-4.0.0-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.