Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033352-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033352-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons-19.01.4-1.fc30.src.rpm Description: This package provides a GNOME Shell extension for showing the contents of ~/Desktop on the desktop of the Shell. Common file management operations such as launching, copy/paste, rename and deleting are supported. Fedora Account System Username: atim Working COPR: https://copr.fedorainfracloud.org/coprs/atim/gnome-shell-extension-desktop-icons
https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033363-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons.spec https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033363-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons-19.01.4-2.fc30.src.rpm
https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033461-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons.spec https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033461-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons-19.01.4-3.fc30.src.rpm
I will review this package. > %meson --localedir=share/gnome-shell/extensions/%{extid}/locale Please ask upstream to not use hadcoded paths. > meson.add_install_script('meson_post_install.py') This must be removed in %prep: sed -e "/meson_post_install/d" -i meson.build
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: BUILDSTDERR: warning: File listed twice: /usr/share/gnome- shell/extensions/desktop-icons@csoriano/locale/ca/LC_MESSAGES/desktop- icons.mo See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)". 35 files have unknown license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gnome-shell-extension-desktop-icons-19.01.4-3.fc32.noarch.rpm gnome-shell-extension-desktop-icons-19.01.4-3.fc32.src.rpm gnome-shell-extension-desktop-icons.noarch: W: spelling-error %description -l en_US csoriano -> censorial gnome-shell-extension-desktop-icons.src: W: spelling-error %description -l en_US csoriano -> censorial 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_RU.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). gnome-shell-extension-desktop-icons.noarch: W: spelling-error %description -l en_US csoriano -> censorial gnome-shell-extension-desktop-icons.noarch: W: invalid-url URL: https://gitlab.gnome.org/World/ShellExtensions/desktop-icons <urlopen error [Errno -2] Name or service not known> 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://gitlab.gnome.org/World/ShellExtensions/desktop-icons/-/archive/19.01.4/gnome-shell-extension-desktop-icons-19.01.4.tar.gz : CHECKSUM(SHA256) this package : 9f4f173ec64ff8aab8696804e10ae1cf0fab16e508f5fb52a33d216acff41fc1 CHECKSUM(SHA256) upstream package : 9f4f173ec64ff8aab8696804e10ae1cf0fab16e508f5fb52a33d216acff41fc1 Requires -------- gnome-shell-extension-desktop-icons (rpmlib, GLIBC filtered): /usr/bin/gjs gnome-shell nautilus xdg-desktop-portal-gtk Provides -------- gnome-shell-extension-desktop-icons: gnome-shell-extension-desktop-icons Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1752292 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, Ocaml, C/C++, Python, SugarActivity, Haskell, R, Perl, PHP, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Please also fix issue with duplicate localization files.
I changed locale dest path in meson and now it in proper place for locales: %meson --localedir=%{_datadir}/locale Tested and locales works. LGTM now. https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033547-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons.spec https://copr-be.cloud.fedoraproject.org/results/atim/gnome-shell-extension-desktop-icons/fedora-30-x86_64/01033547-gnome-shell-extension-desktop-icons/gnome-shell-extension-desktop-icons-19.01.4-4.fc30.src.rpm
LGTM now. Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-extension-desktop-icons
FEDORA-2019-75bf7cb279 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-75bf7cb279
FEDORA-2019-4291d9d4e9 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-4291d9d4e9
gnome-shell-extension-desktop-icons-19.01.4-4.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-4291d9d4e9
gnome-shell-extension-desktop-icons-19.01.4-4.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-75bf7cb279
gnome-shell-extension-desktop-icons-19.01.4-4.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
gnome-shell-extension-desktop-icons-19.01.4-4.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.