Fedora Account System
Red Hat Associate
Red Hat Customer
Spec Name or Url: http://rpm.frields.org/extras-testing/perl-PatchReader/perl-PatchReader.spec SRPM Name or Url: http://rpm.frields.org/extras-testing/perl-PatchReader/perl-PatchReader-0.9.5-1.src.rpm Description: PatchReader is a set of utilities for reading in, transforming, and doing various other things with a patch. It basically allows you to create a chain of readers that can read a patch, remove files from a patch, add CVS context, fix up the patch root according to CVS, and output the patch as raw unified or through a template processor (used in some places to output a patch as HTML). (As noted in %changelog, the spec is based on Dag Wieers' package of the same name.)
Needswork'n'nitpicks: - Uselessly redefines %{perl_vendor*}, doesn't need %{perl_vendorarch} - Requires: perl(:MODULE_COMPAT_*) missing - Doesn't run test suite during build - Redundant %doc for man page - Installs *.pm executable - Off sync with many "best practices" from fedora-rpmdevtools' perl spec template Here's my package which should be ready to roll; "|| :" could be removed from %check and BuildRequires trimmed assuming recent perl packages though: http://cachalot.mine.nu/4/SRPMS/perl-PatchReader-0.9.5-0.2.src.rpm Note: the URLs you posted apparently use some kind of a frame hack which makes them non-wgettable.
Thanks, Ville -- some questions follow so I can learn something out of this: (In reply to comment #1) > - Requires: perl(:MODULE_COMPAT_*) missing What does this mean? > - Installs *.pm executable You must have picked this up during the few minutes before I fixed this problem -- the ones up there as of this morning don't have this problem, but thanks. > - Off sync with many "best practices" from fedora-rpmdevtools' perl spec > template Yeah, I should have probably started there instead of appropriating Dag's and starting with it. > Here's my package which should be ready to roll; "|| :" could be removed from > %check and BuildRequires trimmed assuming recent perl packages though: > http://cachalot.mine.nu/4/SRPMS/perl-PatchReader-0.9.5-0.2.src.rpm Do you want me to take this one over then? > Note: the URLs you posted apparently use some kind of a frame hack which makes > them non-wgettable. Yes, but elinks should work fine if you're stuck with a text browser.
(In reply to comment #2) > > - Requires: perl(:MODULE_COMPAT_*) missing > > What does this mean? Requires: perl(:MODULE_COMPAT_X.Y.Z) is used to make the package depend on a version of perl that uses modules from the X.Y.Z-versioned directories (as in eg. /usr/lib/perl5/vendor_perl/X.Y.Z). See the perl spec template for an example how to generate that based on the version of perl the package is built with. > > http://cachalot.mine.nu/4/SRPMS/perl-PatchReader-0.9.5-0.2.src.rpm > > Do you want me to take this one over then? Take what you feel comfortable maintaining in the future. But as said, the above package is IMO in a pretty good shape, and using specfiles based on the spec template makes it easier for folks to review things. > > them non-wgettable. > > Yes, but elinks should work fine if you're stuck with a text browser. OT: not stuck; wget or curl or direct rpm -Uvh <url-to-src.rpm> just "integrates" better with the way I work.
OK, refer to new spec and SRPM for 0.9.5-2: http://rpm.frields.org/extras-testing/perl-PatchReader/
Created attachment 122110 [details] Cosmetic changes Approved with the attached patch containing some final cosmetic improvements applied (can be done post-import, before the first build).
Please do not remove the FE-ACCEPT blocker. Thanks.
Package Change Request ====================== Package Name: perl-PatchReader New Branches: EL-5 EL-6 Owners: pfrields perl-sig InitialCC: Please create EPEL branches for this package.
CVS done (by process-cvs-requests.py).