Description of problem:

the playbook fails on:

TASK [openshift_certificate_expiry : Check cert expirys on host] ***************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_certificate_expiry/tasks/main.yml:8
fatal: [master1]: FAILED! => {"changed": false, "module_stderr": "Shared connection to master1 closed.\r\n", "module_stdout": "Traceback (most recent call last):\r\n  File \"/tmp/ansible_LS1_66/ansible_module_openshift_cert_expiry.py\", line 876, in <module>\r\n    main()\r\n  File \"/tmp/ansible_LS1_66/ansible_module_openshift_cert_expiry.py\", line 661, in main\r\n    c = cfg['users'][0]['user']['client-certificate-data']\r\nKeyError: 'client-certificate-data'\r\n", "msg": "MODULE FAILURE", "rc": 1}
	to retry, use: --limit @/usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_11/upgrade_control_plane.retry

Problem located here:
https://github.com/openshift/openshift-ansible/blob/b7ad55a99bc13c0affd2f90f22f7b57e93ef25fb/roles/openshift_certificate_expiry/tasks/main.yml#L8-L13
https://github.com/openshift/openshift-ansible/blob/b7ad55a99bc13c0affd2f90f22f7b57e93ef25fb/roles/lib_utils/library/openshift_cert_expiry.py#L876

Also I found that "node.kubeconfig" was missing "client-certificate-date". Even copying the certificate from the other kubeconfig it did not work.


Version-Release number of the following components:
openshift-ansible-playbooks-3.11.135-1.git.0.b7ad55a.el7.noarch
ansible-2.6.18-1.el7ae.noarch

FYI:
atomic-openshift-3.11.88-1.git.0.47f4e98.el7.x86_64
customer running it before minor upgrade

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:
TASK [openshift_certificate_expiry : Check cert expirys on host] ***************
task path: /usr/share/ansible/openshift-ansible/roles/openshift_certificate_expiry/tasks/main.yml:8
<date redacted>
Using module file /usr/share/ansible/openshift-ansible/roles/lib_utils/library/openshift_cert_expiry.py
<master1> ESTABLISH SSH CONNECTION FOR USER: root
<master1> SSH: EXEC ssh -o ControlMaster=auto -o ControlPersist=600s -o StrictHostKeyChecking=no -o KbdInteractiveAuthentication=no -o PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey -o PasswordAuthentication=no -o User=root -o ConnectTimeout=30 -o ControlPath=/root/.ansible/cp/%h-%r master1 '/bin/sh -c '"'"'/usr/bin/python && sleep 0'"'"''
<master1> (1, '', 'Traceback (most recent call last):\n  File "/tmp/ansible_UCo68d/ansible_module_openshift_cert_expiry.py", line 876, in <module>\n    main()\n  File "/tmp/ansible_UCo68d/ansible_module_openshift_cert_expiry.py", line 661, in main\n    c = cfg[\'users\'][0][\'user\'][\'client-certificate-data\']\nKeyError: \'client-certificate-data\'\n')
<master1> Failed to connect to the host via ssh: Traceback (most recent call last):
  File "/tmp/ansible_UCo68d/ansible_module_openshift_cert_expiry.py", line 876, in <module>
    main()
  File "/tmp/ansible_UCo68d/ansible_module_openshift_cert_expiry.py", line 661, in main
    c = cfg['users'][0]['user']['client-certificate-data']
KeyError: 'client-certificate-data'
The full traceback is:
Traceback (most recent call last):
  File "/tmp/ansible_UCo68d/ansible_module_openshift_cert_expiry.py", line 876, in <module>
    main()
  File "/tmp/ansible_UCo68d/ansible_module_openshift_cert_expiry.py", line 661, in main
    c = cfg['users'][0]['user']['client-certificate-data']
KeyError: 'client-certificate-data'
fatal: [master1]: FAILED! => {
    "changed": false, 
    "module_stderr": "Traceback (most recent call last):\n  File \"/tmp/ansible_UCo68d/ansible_module_openshift_cert_expiry.py\", line 876, in <module>\n    main()\n  File \"/tmp/ansible_UCo68d/ansible_module_openshift_cert_expiry.py\", line 661, in main\n    c = cfg['users'][0]['user']['client-certificate-data']\nKeyError: 'client-certificate-data'\n", 
    "module_stdout": "", 
    "msg": "MODULE FAILURE", 
    "rc": 1
}

Expected results:

Additional info:
maybe related to:
https://bugzilla.redhat.com/show_bug.cgi?id=1520971#c6
https://github.com/openshift/openshift-ansible/pull/8132/files