Bug 1753289 - Incorrect flash when custom button under generic object class is deleted
Summary: Incorrect flash when custom button under generic object class is deleted
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.11.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: GA
: 5.12.0
Assignee: Zita Nemeckova
QA Contact: Tasos Papaioannou
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1773667
TreeView+ depends on / blocked
 
Reported: 2019-09-18 14:19 UTC by John Dupuy
Modified: 2020-10-26 16:13 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1773667 (view as bug list)
Environment:
Last Closed: 2020-10-26 16:13:39 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
incorrect flash (369.56 KB, image/gif)
2019-09-18 14:20 UTC, John Dupuy
no flags Details

Description John Dupuy 2019-09-18 14:19:53 UTC
Description of problem:
Incorrect flash message when button is deleted

Version-Release number of selected component (if applicable):
5.11.0.25, also present in 5.10.10

How reproducible:
100%

Steps to Reproduce:
1. Add a generic object class
2. Create a button under the class
3. Delete the button

Actual results:
The flash message reads "Button:"undefined" was successfully deleted"

Expected results:
The flash message should read "Button: <button_name> was successfully deleted"

Additional info:
The attached gif also contains bug 1753281

Comment 2 John Dupuy 2019-09-18 14:20:26 UTC
Created attachment 1616259 [details]
incorrect flash

Comment 3 John Dupuy 2019-09-18 18:39:32 UTC
Note this BZ also occurs with button groups under generic object classes: 

Button Group:"undefined" was successfully deleted

Comment 5 Nikhil Dhandre 2019-09-19 11:19:26 UTC
I think this bug is duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1744478

Comment 7 CFME Bot 2019-09-30 06:21:15 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/7be7595d7c0da12299aeeb16226f2502ed82dd5e
commit 7be7595d7c0da12299aeeb16226f2502ed82dd5e
Author:     Zita Nemeckova <znemecko>
AuthorDate: Thu Sep 19 08:16:22 2019 -0400
Commit:     Zita Nemeckova <znemecko>
CommitDate: Thu Sep 19 08:16:22 2019 -0400

    Fix missing name of deleted GOD Button/ButtonGroup

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1744478
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1753289

 app/assets/javascripts/components/generic_object/generic-object-definition-toolbar.js | 4 +-
 1 file changed, 2 insertions(+), 2 deletions(-)


Note You need to log in before you can comment on or make changes to this bug.