RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1753319 - [machines] icon for removing a disk isn't obvious
Summary: [machines] icon for removing a disk isn't obvious
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: cockpit-appstream
Version: 8.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.2
Assignee: Simon Kobyda
QA Contact: YunmingYang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-09-18 15:02 UTC by Dr. David Alan Gilbert
Modified: 2020-04-28 15:43 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-28 15:43:05 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:1639 0 None None None 2020-04-28 15:43:19 UTC

Description Dr. David Alan Gilbert 2019-09-18 15:02:57 UTC 
Description of problem:
For me, the boxed '-' to the right of the single disk wasn't obvious; I thought it might be a drop down or something, clicking it removed the disk from the VM with no confirmation or anything; it seems too easy to break a VM.

Version-Release number of selected component (if applicable):
cockpit-machines-197.3-1.el8.noarch

How reproducible:
100%

Steps to Reproduce:
1. Create a VM
2. Show a VM/disks tab
3. Wonder what the boxed '-' is to the right of the disk
4. Click it. oops

Actual results:
Disk is removed from VM

Expected results:
Some how make it more obvious that's going to change the VM and/or ask me.

Additional info:
Comment 1 Katerina Koukiou 2019-10-10 13:24:25 UTC 
This was addressed by:
commit 7e391d18dc0640a15533a925000b7817d724fe91
Author: Simon Kobyda <skobyda>
Date:   Tue Jul 23 10:24:39 2019 +0200

    machines: Change disk actions design

$ git describe 7e391d18dc0640a15533a925000b7817d724fe91
203-55-g7e391d18d

So after release 204 the [-] button ws replaced with a [Detach] button.

We probably need to have a dialog in addition, for the operation confirmation, but I think the current fix addresses this issue.
Comment 2 Simon Kobyda 2019-10-10 13:58:34 UTC 
Confirmation dialog will be added once this gets merged: https://github.com/cockpit-project/cockpit/pull/12661
Comment 3 Simon Kobyda 2019-10-24 11:57:46 UTC 
There is now a confirmation dialog:

commit deb75755ffa79e1e8819448af439757898df9936
Author: Simon Kobyda <skobyda>
Date:   Tue Aug 27 18:27:21 2019 +0200

    machines: Use Delete component for deletion of network and disks
    
    Closes #12661
    Fixed https://bugzilla.redhat.com/show_bug.cgi?id=1753319
Comment 5 Xianghua Chen 2019-12-10 06:57:54 UTC 
Verified with packages:
cockpit-machines-208-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

Steps:
1. Create a VM
2. Show a VM/disks tab
3. Click "Remove" to the right of the disk

There will be a dialog to let user confirm to remove the disk, click Remove and the disk is removed successfully.

So verified.
Comment 7 errata-xmlrpc 2020-04-28 15:43:05 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639
Note You need to log in before you can comment on or make changes to this bug.