Bug 1753799
| Summary: | Unresponsive Gnome Due To JavaScript Errors in RHEL 7.7 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Paul Gozart <pgozart> | ||||
| Component: | gnome-shell | Assignee: | Florian Müllner <fmuellner> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 7.7 | CC: | a.korsunsky, alanm, amike, andreas.luik, ayadav, barryz, brclark, cpippin, david.lee, fmuellner, jadahl, james-p, jraising, jwright, kyoneyam, pjasbuti, sfroemer, srigler, swachira, tborcin, tpelka, vchoudha | ||||
| Target Milestone: | rc | Keywords: | ZStream | ||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | gnome-shell-3.28.3-24, mutter-3.28.3-20 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1780030 1816064 1890540 (view as bug list) | Environment: | |||||
| Last Closed: | 2020-03-31 19:39:53 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1782102 | ||||||
| Bug Blocks: | 1780030, 1816064, 1890540 | ||||||
| Attachments: |
|
||||||
|
Description
Paul Gozart
2019-09-19 22:00:56 UTC
@fmuellner Would it be possible to backport these patches into the RHEL 3.28 packages? https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/395 https://gitlab.gnome.org/GNOME/mutter/merge_requests/556 Yes, if we can get the necessary acks. We, too, have a RHEL7.7 user who is experiencing this, with "/var/log/messages" containing lots of: JS ERROR: TypeError: windowActor is null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82:13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153:9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 A status report would be appreciated. Thanks. Can't see mentioned JS ERRORS anymore with new mutter/gnome-shell builds, but I can see:
JS ERROR: TypeError: super._onDestroy is not a function
_onDestroy@/usr/share/gnome-shell/extensions/apps-menu.github.com/extension.js:457:9
destroy@resource:///org/gnome/shell/ui/panelMenu.js:192:9
wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
destroy@/usr/share/gnome-shell/extensions/apps-menu.github.com/extension.js:708:9
disable@/usr/share/gnome-shell/extensions/apps-menu.github.com/extension.js:722:5
disableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:83:9
unloadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:185:5
reloadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:200:5
_onVersionValidationChanged@resource:///org/gnome/shell/ui/extensionSystem.js:300:9
Is this something that we should worry about?
(In reply to Tomas Pelka from comment #14) > Can't see mentioned JS ERRORS anymore with new mutter/gnome-shell builds, > but I can see: > > JS ERROR: TypeError: super._onDestroy is not a function > > _onDestroy@/usr/share/gnome-shell/extensions/apps-menu@gnome-shell- > extensions.gcampax.github.com/extension.js:457:9 > > destroy@resource:///org/gnome/shell/ui/panelMenu.js:192:9 > > wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 > > destroy@/usr/share/gnome-shell/extensions/apps-menu@gnome-shell-extensions. > gcampax.github.com/extension.js:708:9 > > disable@/usr/share/gnome-shell/extensions/apps-menu@gnome-shell-extensions. > gcampax.github.com/extension.js:722:5 > > disableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:83:9 > > unloadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:185:5 > > reloadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:200:5 > > _onVersionValidationChanged@resource:///org/gnome/shell/ui/extensionSystem. > js:300:9 > > Is this something that we should worry about? Filed #1782102 - it is most probably harmless but lets record it. it could be closed anytime. (In reply to Tomas Pelka from comment #14) > Can't see mentioned JS ERRORS anymore with new mutter/gnome-shell builds, > but I can see: > > JS ERROR: TypeError: super._onDestroy is not a function This is another bug in the backport of the 8.2 classic session. > Is this something that we should worry about? The error prevents some cleanups from being run when the apps-menu extension is disabled, which will at least trigger other warnings (unless the error occurs at the end of the session). Considering that the fix consists of dropping a downstream patch, I'm in favor of fixing it. OK so rhbz1782102 was confirmed as a bug, but as we do not have time to fix it in 7.8 (and it is not considered as blocking issue). Moving this one to VERIFIED. We have upgraded to gnome-shell-3.28.3-14.el7_7.x86_64 and mutter-3.28.3-14.el7_7.x86_64 - but are still seeing 'JS ERROR: TypeError: windowActor is null' in /var/log/messages: Feb 10 19:37:07 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82:13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153:9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Feb 10 19:37:12 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82:13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153:9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Feb 11 19:02:11 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82:13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153:9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Feb 11 19:02:16 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82:13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153:9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 Feb 11 19:02:21 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82:13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153:9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 I though these versions of gnome-shell/mutter were meant to fix this issue? (In reply to James Pearson from comment #25) > We have upgraded to gnome-shell-3.28.3-14.el7_7.x86_64 and > mutter-3.28.3-14.el7_7.x86_64 - but are still seeing 'JS ERROR: TypeError: > windowActor is null' in /var/log/messages: > > Feb 10 19:37:07 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is > null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82: > 13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82: > 22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153: > 9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 > Feb 10 19:37:12 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is > null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82: > 13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82: > 22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153: > 9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 > Feb 11 19:02:11 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is > null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82: > 13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82: > 22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153: > 9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 > Feb 11 19:02:16 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is > null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82: > 13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82: > 22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153: > 9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 > Feb 11 19:02:21 adldfwd5820-227 journal: JS ERROR: TypeError: windowActor is > null#012_addWindowEffect@resource:///org/gnome/shell/ui/closeDialog.js:82: > 13#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82: > 22#012vfunc_show@resource:///org/gnome/shell/ui/closeDialog.js:153: > 9#012wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22 > > I though these versions of gnome-shell/mutter were meant to fix this issue? Florian any idea? Any update to this? We're still seeing this problem ... I backported one my upstream fix in mutter: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=27099596 I was able to reproduce the exceptions only before applying the patch. (In reply to Florian Müllner from comment #30) > I backported one my upstream fix in mutter: > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=27099596 > > I was able to reproduce the exceptions only before applying the patch. Any chance I could get hold of that patch to test? (In reply to James Pearson from comment #31) > (In reply to Florian Müllner from comment #30) > > I backported one my upstream fix in mutter: > > https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=27099596 > > > > I was able to reproduce the exceptions only before applying the patch. > > Any chance I could get hold of that patch to test? Absolutely, do you know who is your RHEL representative? Who could deliver these pkgs to you? (In reply to Tomas Pelka from comment #32) > > > > Any chance I could get hold of that patch to test? > > Absolutely, do you know who is your RHEL representative? Who could deliver > these pkgs to you? AFAIK, we don't have a RHEL representative Could you just attach the patch file to this BZ ? Thanks (In reply to James Pearson from comment #33) > (In reply to Tomas Pelka from comment #32) > > > > > > Any chance I could get hold of that patch to test? > > > > Absolutely, do you know who is your RHEL representative? Who could deliver > > these pkgs to you? > > AFAIK, we don't have a RHEL representative > > Could you just attach the patch file to this BZ ? > > Thanks Florian can you please do it? Created attachment 1669406 [details]
Hide close dialog before destroying
Sure.
(In reply to Florian Müllner from comment #35) > Created attachment 1669406 [details] > Hide close dialog before destroying Thanks - we'll see if it helps us Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:1021 |