Bug 1754237 - has_metadata function is missing in virt.xs for DomainCheckpoint
Summary: has_metadata function is missing in virt.xs for DomainCheckpoint
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: perl-Sys-Virt
Version: 8.1
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: rc
: 8.0
Assignee: Daniel Berrangé
QA Contact: Dan Zheng
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-09-22 04:14 UTC by Dan Zheng
Modified: 2020-05-05 09:50 UTC (History)
2 users (show)

Fixed In Version: perl-Sys-Virt-6.0.0-1.module+el8.2.0+5488+267def79
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-05 09:49:41 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2020:2017 0 None None None 2020-05-05 09:50:27 UTC

Description Dan Zheng 2019-09-22 04:14:29 UTC
Description of problem:
has_metadata function is missing in virt.xs for DomainCheckpoint.

Version-Release number of selected component (if applicable):
perl-Sys-Virt-5.6.0-2.module+el8.1.0+4140+e3893fe6.x86_64

How reproducible:

100%

Steps to Reproduce:
1.
# virsh checkpoint-list vm2
 Name   Creation Time
-----------------------------------
 chp1   2019-09-22 09:32:24 +0800
 chp3   2019-09-22 10:29:02 +0800

# cat test.pl
...
if (int(@ARGV) < 1) {
    die "syntax: $0 DOMAIN";
}

my $conn = Sys::Virt->new();
my $dom = $conn->get_domain_by_name(shift @ARGV);
my $chp1 = $dom->get_checkpoint_by_name('chp1');
print $chp1->has_metadata();

# ./test.pl vm2
Can't locate object method "has_metadata" via package "Sys::Virt::DomainCheckpoint" at ./test.pl line 41.

2. No definition in virt.xs, but defined in lib/Sys/Virt/DomainCheckpoint.pm
...
=item $res = $domchkp->has_metadata()

Returns a true value if this checkpoint has metadata associated with
it.




3.

Actual results:
See above

Expected results:
has_metadata() can be invoked

Additional info:

Comment 1 Daniel Berrangé 2019-12-11 10:48:34 UTC
commit 7b5852c3e80d5171ca9da43b40506aea76dc42d2
Author: Daniel P. Berrangé <berrange>
Date:   Tue Dec 10 13:06:29 2019 +0000

    Remove docs for has_metadata method which doesn't exist
    
    Reviewed-by: Michal Privoznik <mprivozn>
    Signed-off-by: Daniel P. Berrangé <berrange>

Comment 3 Dan Zheng 2020-02-12 07:01:16 UTC
perl-Sys-Virt-6.0.0-1.module+el8.2.0

Check in lib/Sys/Virt/DomainCheckpoint.pm, $domchkp->has_metadata() is removed.

Comment 5 errata-xmlrpc 2020-05-05 09:49:41 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2017


Note You need to log in before you can comment on or make changes to this bug.