Bug 175494 - Review Request: new
Review Request: new
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: John Mahowald
David Lawrence
:
: 175496 (view as bug list)
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2005-12-11 17:28 EST by W. Michael Petullo
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2005-12-19 17:30:05 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description W. Michael Petullo 2005-12-11 17:28:18 EST
Spec Name or Url: http://flyn.org/SRPMS/new.spec
SRPM Name or Url: http://www.flyn.org/projects/new/new-1.3.5-1.src.rpm
Description: A simple template system for creating text files.
Comment 1 Ville Skyttä 2005-12-11 17:53:42 EST
*** Bug 175496 has been marked as a duplicate of this bug. ***
Comment 2 John Mahowald 2005-12-13 12:36:24 EST
- package meets naming guidelines
- license (GPL) OK, text in %doc, matches source
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 


Stuff needing work:
- warnings about duplicate files
- %doc %{_mandir} is useless, rpm knows about man already
- empty NEWS and FAQ aren't useful, don't include
- Don't need to list every file in %files, including a directory includes its
contents. Wildcards accepted, useful for including everything but not owning the
directory. So you can do:

%files
%{_bindir}/*
%{_datadir}/new
%{_mandir}/*/*

- Your header and pkgconfig files should be in a seperate devel sub package.
This devel package should require the base new package, the exact same version.
See PackageReviewGuidelines on the wiki.
Comment 3 W. Michael Petullo 2005-12-13 19:40:19 EST
Changes recommended by John:

Spec Name or Url: http://flyn.org/SRPMS/new.spec
SRPM Name or Url: http://www.flyn.org/projects/new/new-1.3.5-2.src.rpm
Description: A simple template system for creating text files.
Comment 4 John Mahowald 2005-12-19 01:18:03 EST
Builds and works. rpmlint complains about:

E: new non-executable-script /usr/share/new/templates/missing/default 0644
E: new non-executable-script /usr/share/new/templates/py/default 0644
E: new non-executable-script /usr/share/new/templates/sh/default 0644
W: new-devel no-documentation

but these can be ignored, templates aren't executable.

devel subpackage included, no .la files.

Remainder of review in comment 2.

APPROVED
Comment 5 Michael Schwendt 2005-12-24 14:00:24 EST
> %files devel
> %{_libdir}/pkgconfig/new.pc
> %{_includedir}/new
> %{_libdir}/lib*.so

Missing %defattr(..). If built, files in binary package will be
owned by the build user.
Comment 6 W. Michael Petullo 2005-12-24 15:09:42 EST
new-1.3.5-3 is now in CVS.  This version fixes the issue raised in command #5.

Note You need to log in before you can comment on or make changes to this bug.