Bug 175495 - Review Request: cgi-util: A C library for creating CGI programs
Summary: Review Request: cgi-util: A C library for creating CGI programs
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All Linux
medium
medium
Target Milestone: ---
Assignee: Ignacio Vazquez-Abrams
QA Contact: David Lawrence
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2005-12-11 22:37 UTC by W. Michael Petullo
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-04-08 01:05:18 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
mock build log (10.28 KB, text/plain)
2006-02-23 10:01 UTC, Ignacio Vazquez-Abrams
no flags Details

Description W. Michael Petullo 2005-12-11 22:37:29 UTC
Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec
SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-1.src.rpm
Description: A C library for creating Common Gateway Interface ("CGI") programs

Comment 1 W. Michael Petullo 2005-12-14 01:10:45 UTC
The following version spilts out a devel package:

Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec
SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-2.src.rpm
Description: A C library for creating Common Gateway Interface ("CGI") programs

Comment 2 Ignacio Vazquez-Abrams 2006-02-21 12:15:15 UTC
- %description of -devel is overly verbose
? Why is the patch being used to rename files?
- Does not build on mock FC4/i386.

Comment 3 W. Michael Petullo 2006-02-22 00:32:55 UTC
The following shortens the package descriptions and no longer renames the
documentation files:

Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec
SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-3.src.rpm
Description: A C library for creating Common Gateway Interface ("CGI") programs

Ignacio, what causes the package to fail to build on mock FC4/i386?

Comment 4 Ignacio Vazquez-Abrams 2006-02-22 07:47:40 UTC
gcc -DHAVE_CONFIG_H -I. -I. -I. -g -Werror -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -m32 -march=i386 -mtune=pentium4 -fasynchronous-unwind-tables -MT
cgi-util.lo -MD -MP -MF .deps/cgi-util.Tpo -c cgi-util.c  -fPIC -DPIC -o
.libs/cgi-util.o
cc1: warnings being treated as errors
cgi-util.c: In function 'cgi_init':
cgi-util.c:220: warning: ignoring return value of 'fgets', declared with
attribute warn_unused_result
make[1]: *** [cgi-util.lo] Error 1

Comment 5 W. Michael Petullo 2006-02-22 23:31:09 UTC
The following removes the use of -Werror from the build process:

Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec
SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-4.src.rpm
Description: A C library for creating Common Gateway Interface ("CGI") programs

Comment 6 Ignacio Vazquez-Abrams 2006-02-23 10:01:51 UTC
Created attachment 125091 [details]
mock build log

Unfortunately your first attempt to remove -Werror has failed.

Comment 7 W. Michael Petullo 2006-02-23 23:57:07 UTC
The following removes the use of -Werror from Makefile.in:

Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec
SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-5.src.rpm
Description: A C library for creating Common Gateway Interface ("CGI") programs

Comment 8 Ignacio Vazquez-Abrams 2006-03-09 17:39:00 UTC
- test.cgi and filetest.cgi aren't useful to have as system binaries so they
shouldn't be in %{_bindir}. Put them as %doc along with the corresponding .html
files.
- Move README to -devel %doc and add test.c and filetest.c
- Pass --disable-static to configure


Comment 9 W. Michael Petullo 2006-03-09 23:31:39 UTC
The following implements Ignacio's recommendations:

Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec
SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-6.src.rpm
Description: A C library for creating Common Gateway Interface ("CGI") programs

Comment 10 Ignacio Vazquez-Abrams 2006-04-04 23:15:54 UTC
I really would prefer that you use mv or rename in %prep instead of using a
patch to rename files... but I'll consider it a non-blocker.

OTOH, you need to remove the .cgi files from %{_bindir}.

Comment 11 W. Michael Petullo 2006-04-05 00:20:44 UTC
The patch is used to rename files so that I can get this change upstream.  The
maintainers seem willing to accept it after the next version is released.

The following implements Ignacio's recommendations:

Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec
SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-7.src.rpm
Description: A C library for creating Common Gateway Interface ("CGI") programs

Comment 12 Ignacio Vazquez-Abrams 2006-04-07 06:51:19 UTC
APPROVED.


Note You need to log in before you can comment on or make changes to this bug.