Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-1.src.rpm Description: A C library for creating Common Gateway Interface ("CGI") programs
The following version spilts out a devel package: Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-2.src.rpm Description: A C library for creating Common Gateway Interface ("CGI") programs
- %description of -devel is overly verbose ? Why is the patch being used to rename files? - Does not build on mock FC4/i386.
The following shortens the package descriptions and no longer renames the documentation files: Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-3.src.rpm Description: A C library for creating Common Gateway Interface ("CGI") programs Ignacio, what causes the package to fail to build on mock FC4/i386?
gcc -DHAVE_CONFIG_H -I. -I. -I. -g -Werror -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -m32 -march=i386 -mtune=pentium4 -fasynchronous-unwind-tables -MT cgi-util.lo -MD -MP -MF .deps/cgi-util.Tpo -c cgi-util.c -fPIC -DPIC -o .libs/cgi-util.o cc1: warnings being treated as errors cgi-util.c: In function 'cgi_init': cgi-util.c:220: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result make[1]: *** [cgi-util.lo] Error 1
The following removes the use of -Werror from the build process: Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-4.src.rpm Description: A C library for creating Common Gateway Interface ("CGI") programs
Created attachment 125091 [details] mock build log Unfortunately your first attempt to remove -Werror has failed.
The following removes the use of -Werror from Makefile.in: Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-5.src.rpm Description: A C library for creating Common Gateway Interface ("CGI") programs
- test.cgi and filetest.cgi aren't useful to have as system binaries so they shouldn't be in %{_bindir}. Put them as %doc along with the corresponding .html files. - Move README to -devel %doc and add test.c and filetest.c - Pass --disable-static to configure
The following implements Ignacio's recommendations: Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-6.src.rpm Description: A C library for creating Common Gateway Interface ("CGI") programs
I really would prefer that you use mv or rename in %prep instead of using a patch to rename files... but I'll consider it a non-blocker. OTOH, you need to remove the .cgi files from %{_bindir}.
The patch is used to rename files so that I can get this change upstream. The maintainers seem willing to accept it after the next version is released. The following implements Ignacio's recommendations: Spec Name or Url: http://flyn.org/SRPMS/cgi-util.spec SRPM Name or Url: http://flyn.org/SRPMS/cgi-util-2.2.1-7.src.rpm Description: A C library for creating Common Gateway Interface ("CGI") programs
APPROVED.