Bug 175500 - Review Request: compat-wxGTK & compat-wxPythonGTK2
Review Request: compat-wxGTK & compat-wxPythonGTK2
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matthias Saou
David Lawrence
Depends On:
Blocks: 154618 FE-ACCEPT
  Show dependency treegraph
Reported: 2005-12-11 18:47 EST by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-04-19 17:40:48 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Spec file patch (8.63 KB, patch)
2005-12-19 12:06 EST, Matthias Saou
no flags Details | Diff
Spec file patch (1.58 KB, patch)
2005-12-19 12:27 EST, Matthias Saou
no flags Details | Diff

  None (edit)
Description Tom "spot" Callaway 2005-12-11 18:47:46 EST
Spec Name or Url: http://auroralinux.org/people/spot/review/compat-wxPython.spec

SRPM Name or Url: http://auroralinux.org/people/spot/review/compat-wxGTK-2.4.2-14.src.rpm


These are the compat packages for wx 2.4, based off the already approved packages in Fedora Extras. Infact, other than the name change, the only difference is that some binaries have been removed (because they conflict with the 2.6 binaries) and that wx-config is now wx-2.4-config. Applications needing to use the compat-wx* packages will need to be modified to call wx-2.4-config instead of wx-config.

wxWidgets/GTK is the GTK+ (1.2) port of the C++ cross-platform wxWidgets
GUI library, offering classes for all common GUI controls as well as a
comprehensive set of helper classes for most common application tasks,
ranging from networking to HTML display and image manipulation.

wxPython is a GUI toolkit for the Python programming language. It allows
Python programmers to create programs with a robust, highly functional
graphical user interface, simply and easily. It is implemented as a Python
extension module (native code) that wraps the popular wxWindows cross
platform GUI library, which is written in C++.
Comment 1 Matthias Saou 2005-12-12 06:35:52 EST
These look pretty good (apart from the added tabs, when the spec files used
spaces ;-)). Have you tried to modify and build some applications using them?
(just to know if it'll be easy or not), like audacity for instance?

If no one else steps up, I wouldn't mind reviewing the packages, but I'll
need to do some further testing.
Comment 2 Matthew Miller 2005-12-15 12:56:28 EST
Matthias -- by all means, please review. :)
Comment 3 Matthias Saou 2005-12-19 12:03:35 EST
Packages that will need to have their spec file updated for the change :
- audacity
- bochs
- comical
- pgadmin3
- scorched3d

I've only tested a rebuild of audacity, and it worked fine changing just :
- The BuildRequires to add "compat-"
- The %build section to add just before the %configure line :
  export WX_CONFIG="%{_bindir}/wx-2.4-config"

Please consider applying the spec file patch I'll attach as it fixes many
minor cosmetic issues in the spec file. It also changes to 755 the mode of
the %ghost'ed script, so that rpmlint stops complaining.
Comment 4 Matthias Saou 2005-12-19 12:06:15 EST
Created attachment 122410 [details]
Spec file patch
Comment 5 Matthias Saou 2005-12-19 12:27:56 EST
Created attachment 122411 [details]
Spec file patch
Comment 6 Matthias Saou 2005-12-19 12:29:54 EST
Since the patches only contain minor changes, I already approve both packages.
Comment 7 Matthias Saou 2006-02-24 11:34:19 EST
I see these have been imported, but only compat-wxGTK bas been built in FC5, is
that wanted? What about FC4?
Comment 8 Michael Schwendt 2006-03-17 15:13:23 EST
There's a conflict in the virtual Provides of the published packages!

Currently both  wxGTK-devel  and  compat-wxGTK2-devel  as well as
wxGTK  and  compat-wxGTK2  contain

  "Provides: wxGTK2-devel = some version"
  "Provides: wxGTK2 = some version"

This makes them competing packages. You cannot do this, as wxGTK and
compat-wxGTK2 are _not_ equivalent. It causes RPM to let the newer
version win, which results in removal of the packages with the older
versions during installation or in a failed transaction check.
Comment 9 Michael Schwendt 2006-03-17 15:38:07 EST
compat-wxGTK2-devel is broken!

$ wxgtk2-2.4-config --cflags
-I/usr/lib/wx/include/gtk2-2.4 -DGTK_NO_CHECK_CASTS -D__WXGTK__

It points to  /usr/lib/wx/include/gtk2-2.4  but the compat-wxGTK2-devel
package contains headers in a different path:


On the contrary, compat-wxGTK-devel is okay.
Comment 10 Matthew Miller 2006-03-17 15:40:13 EST
Michael -- what's your advice for resolving comment #8? I'd not like to remove
that from the main wxGTK package, but it seems necessary here....
Comment 11 Michael Schwendt 2006-03-17 15:45:53 EST
Re: comment 9

--- compat-wxGTK.spec.~1.2.~    2006-01-06 18:52:38.000000000 +0100
+++ compat-wxGTK.spec   2006-03-17 21:51:27.000000000 +0100
@@ -288,7 +288,7 @@
 %ghost %{_bindir}/wx-2.4-config
 %files common -f wxstd.lang

Re: comment 10

Remove the Provides from the compat-wxGTK2{-devel} packages, but not
from the new wxGTK{-devel} packages.
Comment 12 Michael Schwendt 2006-03-17 15:51:09 EST
Btw, compat-wxGTK{-devel} must not "Provides: wxGTK = ..." and
"Provides: wxGTK-devel = ..." either.
Comment 13 Matthew Miller 2006-03-17 15:52:53 EST
And then any packages which link against this must work just by virtue of the
automatic library deps, and any which have explict requires statements must be
fixed, yeah?
Comment 14 Michael Schwendt 2006-03-17 16:00:12 EST
> And then any packages which link against this must work just
> by virtue of the automatic library deps

That's how ordinary "compat-" packages work anyway. You let a _new_
compat- package provide the SONAMES needed by old binaries. The
SONAME dependencies don't care which package contains the needed

> and any which have explict requires statements must be
> fixed, yeah?

Those packages are broken by design.

Same applies to BuildRequires and the current brokeness due to these
"virtual provides" madness. A package which "BuildRequires: wxGTK2-devel"
cannot be built with compat-wxGTK2-devel which "Provides: wxGTK2-devel"
and vice versa.
Comment 15 Matthew Miller 2006-03-17 16:02:28 EST
Make sense. And is ideal, because it's someone else's problem. *grin*
Comment 16 Alex Lancaster 2006-04-19 10:37:45 EDT
Looks like compat-wxPythonGTK2 hasn't yet been built on devel or FC-5.  Causes
some problems like bug #188215.
Comment 17 Matthew Miller 2006-04-19 10:47:59 EDT
The specific code in bug #188215 (simply importing wxPython) should work fine
with the new 2.6.x wxPython.
Comment 18 Joel Schaerer 2006-04-19 15:56:57 EDT
When will the new packages be available? The code i would like to use is mainly
incompatible with wx2.6, so the packages are going to be needed! 
As of today, i only see the old package:
wxPythonGTK2.i386                            extras
in extras, and it doesn't work (cf bug #188215)
Comment 19 Tom "spot" Callaway 2006-04-19 17:40:48 EDT
New packages should now be available.
Comment 20 Alex Lancaster 2006-04-19 21:12:39 EDT
Shouldn't package reviews be closed as NEXTRELEASE?
Comment 21 Tom "spot" Callaway 2006-04-19 21:20:12 EDT
Ehh. Semantics.

I think of NEXTRELEASE as "FC-6" as opposed to "Immediately in repo", but I
could see either being valid.

They're built. That's what really matters, right? :)
Comment 22 Alex Lancaster 2006-04-19 22:41:10 EDT
(In reply to comment #21)
> Ehh. Semantics.
> I think of NEXTRELEASE as "FC-6" as opposed to "Immediately in repo", but I
> could see either being valid.

Sure, just wondering whether the process had changed.  I was going off of step
14 of:


> They're built. That's what really matters, right? :)

Indeed, thank you.

Note You need to log in before you can comment on or make changes to this bug.