Spec URL: https://fedorapeople.org/~gd/smbcmp/smbcmp.spec SRPM URL: https://fedorapeople.org/~gd/smbcmp/smbcmp-0.1-0.src.rpm Description: Small curses utility to diff, compare and debug SMB network traces Fedora Account System Username: gd
The package doesn't install nor does it work at all. The License tag should say: GPLv3+ The README.md should be added in the files section with: %doc README.md The LICENSE should be added in the files section with: %license LICENSE The Source0 should be a URL, ask Aurelien to create a tag in git! The project has a setup.py file, but you don't use it to install it. You should use %py3_build and %py3_install. An example is at: https://src.fedoraproject.org/rpms/python3-exiv2 There is no python3-curses package in Feodra! The curses module is provides by python3-libs! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Dist tag is present. - Package does not contain duplicates in %files. Note: BUILDSTDERR: warning: File listed twice: /usr/share/doc/smbcmp/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)". 2 files have unknown license. Detailed output of licensecheck in /home/asn/workspace/package/fedora/review/1755084-smbcmp/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.16 starting (python version = 3.7.4)... Start: init plugins INFO: selinux disabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.16 INFO: Mock Version: 1.4.16 Finish: chroot init INFO: installing package(s): /home/asn/workspace/package/fedora/review/1755084-smbcmp/results/smbcmp-0.1-0.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 32 --setopt=deltarpm=False --disableplugin=local --disableplugin=spacewalk install /home/asn/workspace/package/fedora/review/1755084-smbcmp/results/smbcmp-0.1-0.noarch.rpm Rpmlint ------- Checking: smbcmp-0.1-0.noarch.rpm smbcmp-0.1-0.src.rpm smbcmp.noarch: W: invalid-license GPL-3.0 smbcmp.noarch: W: no-manual-page-for-binary smbcmp smbcmp.src: W: invalid-license GPL-3.0 smbcmp.src: W: invalid-url Source0: smbcmp-0.1.tar.gz 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Requires -------- smbcmp (rpmlib, GLIBC filtered): /usr/bin/python3 python3 python3-curses wireshark Provides -------- smbcmp: smbcmp
Hello, Can you try the spec file from OBS, or reuse things from there? https://build.opensuse.org/package/show/home:aaptel:smbcmp/smbcmp There is a v0.1 tag already.
Aurélien, python packing differs in Fedora compared to openSUSE. We have macros which should be used. If I look for tags at https://github.com/aaptel/smbcmp the list is empty.
The official website and repo is https://smbcmp.github.io and https://github.com/smbcmp/smbcmp (the tag is there).
More work for Günther! Fix the URL: and Source0:
Thanks for the excellent review and all the hints, I'll get to each of them, just next week :)
All things mentioned have been addressed. Can you recheck? Files on the same location as above.
Günther, you have to bump the release version and add changelog entries for what you change. Then post a new spec and srpm urls in the format like in the description :-) Source0 should be: https://github.com/smbcmp/smbcmp/archive/v0.1/%{name}-%{version}.tar.gz
Requires: wireshark tshark is part of wireshark-cli!
Ok, here is new spec with updates: Spec URL: https://fedorapeople.org/~gd/smbcmp/smbcmp.spec SRPM URL: https://fedorapeople.org/~gd/smbcmp/smbcmp-0.1-1.src.rpm Description: Small curses utility to diff, compare and debug SMB network traces Fedora Account System Username: gd
ping
Fixed spec and srpm url destinations, sorry they were invalid before...
LGTM
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/smbcmp
The package has no %{?dist} tag: https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ You will have trouble building it from the same source on multiple Fedora versions.
Oh, thanks for the hint. I resolved it by now and correct dist tag use should be in place now. Thanks!