Description of problem: Sys::Virt::Domain::MIGRATE_PARAM_PARALLEL_CONNECTIONS is missing implementation in virt.xs Version-Release number of selected component (if applicable): perl-Sys-Virt-5.6.0-2.module+el8.1.0+4140+e3893fe6.x86_64 How reproducible: 100% Steps to Reproduce: 1. Sys::Virt::Domain::MIGRATE_PARAM_PARALLEL_CONNECTIONS is defined in Domain.pm, but no implementation codes in virt.xs _migrate() function. virDomainPtr _migrate(dom, destcon, newparams, flags=0) virDomainPtr dom; virConnectPtr destcon; HV *newparams; unsigned long flags; PREINIT: virTypedParameterPtr params; int nparams; 2. 3. Actual results: Expected results: Additional info:
commit 52d9758b6766131a64573fa7e900ed9882f8b21c Author: Daniel P. Berrangé <berrange> Date: Tue Dec 10 13:10:11 2019 +0000 Add handling for VIR_MIGRATE_PARAM_PARALLEL_CONNECTIONS Reviewed-by: Michal Privoznik <mprivozn> Signed-off-by: Daniel P. Berrangé <berrange> commit 5c063fb3a790e7c0dd98850fb29c942412d2bdea Author: Daniel P. Berrangé <berrange> Date: Tue Dec 10 12:59:06 2019 +0000 Fix typo breaking some migrate parameter handling Reviewed-by: Michal Privoznik <mprivozn> Signed-off-by: Daniel P. Berrangé <berrange>
Test package: perl-Sys-Virt-6.0.0-1.module+el8.2.0+5488+267def79.x86_64 On source host: my $migflags = Sys::Virt::Domain::MIGRATE_LIVE | Sys::Virt::Domain::MIGRATE_PARALLEL; my %params = (Sys::Virt::Domain::MIGRATE_PARAM_PARALLEL_CONNECTIONS => $parallel_conns); lives_ok(sub { $srcvm->migrate($otherconn, \%params, $migflags); $mig_failed = 0;}, "migrated domain"); On target host check: my $netstat_out = `netstat -tunap|grep 4915.*ESTABLISHED`; my @list = split(/\n/, $netstat_out); is($#list, $parallel_conns, "get correct parallel connections during migration"); Output: # Begin migration # tcp 0 0 10.66.85.225:40490 10.66.86.12:49152 ESTABLISHED 10495/qemu-kvm # tcp 0 0 10.66.85.225:40494 10.66.86.12:49152 ESTABLISHED 10495/qemu-kvm # tcp 0 0 10.66.85.225:40496 10.66.86.12:49152 ESTABLISHED 10495/qemu-kvm # tcp 0 0 10.66.85.225:40492 10.66.86.12:49152 ESTABLISHED 10495/qemu-kvm ok 1 - get correct parallel connections during migration ok 2 - migrated domain ok 3 - source VM is not still active ok 4 - target VM exists ok 5 - target VM is running PASS.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2017