Bug 1755829 - One of the 'HSM.moveImage' exception handlers refers to non-existing members on the exception instance
Summary: One of the 'HSM.moveImage' exception handlers refers to non-existing members ...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.40.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.4.0
: 4.40.0
Assignee: Nir Soffer
QA Contact: Yosi Ben Shimon
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-09-26 09:57 UTC by Marcin Sobczyk
Modified: 2020-05-20 23:59 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-12-30 12:18:19 UTC
oVirt Team: Storage
Embargoed:
dfediuck: ovirt-4.4+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 103608 0 'None' ABANDONED py3: pylint: Temporarily silence pylint errors 2020-05-20 23:35:10 UTC
oVirt gerrit 103645 0 'None' MERGED storage.exception: Add missing attributes 2020-05-20 23:35:11 UTC

Description Marcin Sobczyk 2019-09-26 09:57:44 UTC 
Description of problem:

Py3-based pylint run has reported an issue with 'HSM.moveImage' method. It seems that one of the exception handlers [1] tries to refer to members that don't exist on the exception instance [2]. Unfortunately this piece of code is not covered by tests nor by basic suite. The pylint errors will be silenced for now, but this isuse should probably be investigated by the storage team.

[1] https://github.com/oVirt/vdsm/blob/ec3aa6746a4ce0510fa314cb62056bf32ce6ab6d/lib/vdsm/storage/hsm.py#L1671
[2] https://github.com/oVirt/vdsm/blob/ec3aa6746a4ce0510fa314cb62056bf32ce6ab6d/lib/vdsm/storage/exception.py#L471
Comment 2 Yosi Ben Shimon 2019-12-09 15:23:00 UTC 
Can I have a scenario for reproduction/verification, please?
Comment 3 Nir Soffer 2019-12-30 12:17:28 UTC 
This is internal issue that was relevant during 4.4 development, and no was
never released. We don't need to verify this.
Comment 4 Nir Soffer 2020-05-20 23:59:50 UTC 
Removing stale need infos.
Note You need to log in before you can comment on or make changes to this bug.