Bug 1756236 - Icon of the "Performance" tab in the detailed view missing
Summary: Icon of the "Performance" tab in the detailed view missing
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-09-27 07:28 UTC by Laurent Bigonville
Modified: 2020-01-26 20:43 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-01-26 20:43:58 UTC
Embargoed:


Attachments (Terms of Use)

Description Laurent Bigonville 2019-09-27 07:28:01 UTC
Hello,

In the detailed page, the Performance tab is using the "utilities-system-monitor" icon (https://github.com/virt-manager/virt-manager/blob/master/virtManager/details/details.py#L2693)

Looks like this icon is not part of the modern/adwaita GNOME icon theme meaning that the icon is missing for some users (it's the case for me on debian unstable)

This icon should either be shipped in virt-manager source code or an other icon should be used

Comment 1 Cole Robinson 2020-01-26 20:43:58 UTC
Thanks for the report, fixed upstream now by using a fallback icon if the preferred one is not available:

commit 3538a8df793c6b3652162d5202b49104236444fd (HEAD -> master)
Author: Cole Robinson <crobinso>
Date:   Sun Jan 26 15:41:21 2020 -0500

    details: Fix perf icon with adwaita-icon-theme


Note You need to log in before you can comment on or make changes to this bug.