Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1756783

Summary: "AttributeError: 'dict_items' object has no attribute 'sort'" error displays when using "nodectl info"
Product: [oVirt] ovirt-node Reporter: Wei Wang <weiwang>
Component: GeneralAssignee: Yuval Turgeman <yturgema>
Status: CLOSED CURRENTRELEASE QA Contact: shiyi lei <shlei>
Severity: high Docs Contact:
Priority: unspecified    
Version: masterCC: bugs, cshao, mavital, peyu, qiyuan, sbonazzo, shlei, weiwang, yaniwang, yturgema
Target Milestone: ovirt-4.4.0Keywords: Regression
Target Release: ---Flags: sbonazzo: ovirt-4.4?
sbonazzo: planning_ack?
sbonazzo: devel_ack+
weiwang: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt-node-ng-4.4.0-0.20191002.0.el8ev Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-20 19:59:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
log files none

Description Wei Wang 2019-09-30 00:12:48 UTC
Created attachment 1620886 [details]
log files

Description of problem:
"AttributeError: 'dict_items' object has no attribute 'sort'" error displays when using "nodectl info"

/usr/lib64/python3.6/re.py:212: FutureWarning: split() requires a non-empty pattern match.
  return _compile(pattern, flags).split(string, maxsplit)
bootloader: 
  default: rhvh-4.4.0.3-0.20190926.0 (4.18.0-146.el8.x86_64)
  entries: 
Traceback (most recent call last):
  File "/usr/lib64/python3.6/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/usr/lib/python3.6/site-packages/nodectl/__main__.py", line 42, in <module>
    CliApplication()
  File "/usr/lib/python3.6/site-packages/nodectl/__init__.py", line 200, in CliApplication
    return cmdmap.command(args)
  File "/usr/lib/python3.6/site-packages/nodectl/__init__.py", line 118, in command
    return self.commands[command](**kwargs)
  File "/usr/lib/python3.6/site-packages/nodectl/__init__.py", line 76, in info
    Info(self.imgbased, self.machine).write()
  File "/usr/lib/python3.6/site-packages/nodectl/info.py", line 102, in write
    pretty_print(k)
  File "/usr/lib/python3.6/site-packages/nodectl/info.py", line 87, in pretty_print
    pretty_print(item, indent+2)
  File "/usr/lib/python3.6/site-packages/nodectl/info.py", line 85, in pretty_print
    items.sort(key=lambda x: x[1]["index"])
AttributeError: 'dict_items' object has no attribute 'sort'


Version-Release number of selected component (if applicable):
RHVH-4.4-20190926.3-RHVH-x86_64-dvd1.iso
cockpit-dashboard-197.3-1.el8.noarch
cockpit-196.3-1.el8.x86_64
cockpit-ws-196.3-1.el8.x86_64
cockpit-system-196.3-1.el8.noarch
cockpit-packagekit-197.3-1.el8.noarch
cockpit-storaged-197.3-1.el8.noarch
cockpit-bridge-196.3-1.el8.x86_64
subscription-manager-cockpit-1.25.16-1.el8.noarch
cockpit-ovirt-dashboard-0.13.8-1.el8ev.noarch
imgbased-1.2.4-0.1.el8ev.noarch

How reproducible:
100%

Steps to Reproduce:
1.Install RHVH-4.4-20190926.3-RHVH-x86_64-dvd1.iso
2.Execute "nodectl info" in terminal in cockpit UI


Actual results:
"AttributeError: 'dict_items' object has no attribute 'sort'" error displays

Expected results:
The information of nodectl displays right without any error

Additional info:

Comment 1 Sandro Bonazzola 2019-09-30 13:16:10 UTC
*** Bug 1756310 has been marked as a duplicate of this bug. ***

Comment 2 shiyi lei 2019-11-11 02:12:24 UTC
[Retest]

Test version:
rhvh-4.4.0.8-0.20191107.0
cockpit-packagekit-197.3-1.el8.noarch
cockpit-196.3-1.el8.x86_64
cockpit-system-196.3-1.el8.noarch
cockpit-dashboard-197.3-1.el8.noarch
cockpit-storaged-197.3-1.el8.noarch
cockpit-bridge-196.3-1.el8.x86_64
subscription-manager-cockpit-1.25.17-1.el8.noarch
cockpit-ovirt-dashboard-0.13.8-1.el8ev.noarch
cockpit-ws-196.3-1.el8.x86_64


Test Steps:
1. Install rhvh-4.4.0.8-0.20191107.0;
2. Execute "nodectl info" in terminal in cockpit UI
3. this command displays:
bootloader: 
  default: rhvh-4.4.0.8-0.20191107.0 (4.18.0-147.el8.x86_64)
  entries: 
    rhvh-4.4.0.8-0.20191107.0 (4.18.0-147.el8.x86_64): 
      index: 0
      kernel: /boot//rhvh-4.4.0.8-0.20191107.0+1/vmlinuz-4.18.0-147.el8.x86_64
      args: boot=UUID=64b515fd-24a4-4873-ba5d-5c09e47319eb rd.lvm.lv=rhvh_dhcp-8-112/swap resume=/dev/mapper/rhvh_dhcp--8--112-swap rd.lvm.lv=rhvh_dhcp-8-112/rhvh-4.4.0.8-0.20191107.0+1 crashkernel=auto img.bootid=rhvh-4.4.0.8-0.20191107.0+1
      root: /dev/rhvh_dhcp-8-112/rhvh-4.4.0.8-0.20191107.0+1
      initrd: /boot//rhvh-4.4.0.8-0.20191107.0+1/initramfs-4.18.0-147.el8.x86_64.img
      title: rhvh-4.4.0.8-0.20191107.0 (4.18.0-147.el8.x86_64)
      blsid: rhvh-4.4.0.8-0.20191107.0+1-4.18.0-147.el8.x86_64
layers: 
  rhvh-4.4.0.8-0.20191107.0: 
    rhvh-4.4.0.8-0.20191107.0+1

Test Result:
the "nodectl info" command can display correctly without any error.


the bug is fixed, QE will move the status to "VERIFIED" after devel change it to "ON_QA"

Comment 3 Wei Wang 2019-12-16 03:12:46 UTC
Retest with RHVH-4.4-20191205.t.1-RHVH-x86_64-dvd1.iso, bug is fixed. And according to comment 2, move bug to "VERIFIED"

Comment 4 Sandro Bonazzola 2020-05-20 19:59:49 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.