Bug 1757247
| Summary: | DHCPv6 relay-fwd requests are ignored by dnsmasq | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Harald Jensås <hjensas> |
| Component: | dnsmasq | Assignee: | Petr Menšík <pemensik> |
| Status: | CLOSED ERRATA | QA Contact: | Petr Sklenar <psklenar> |
| Severity: | high | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.9 | CC: | bfournie, marjones, pemensik, pmosko, thozza |
| Target Milestone: | rc | Keywords: | AutoVerified, Regression, TestCaseProvided, Triaged |
| Target Release: | --- | Flags: | thozza:
mirror+
|
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | dnsmasq-2.76-13.el7 | Doc Type: | No Doc Update |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-09-29 19:31:26 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1711384, 1780577 | ||
|
Description
Harald Jensås
2019-09-30 23:42:19 UTC
This would most likely be fixed by applying:
commit 499d8dde2b1a216eab9252ee500cc31b8c2b2974
Author: yiwenchen <yiwenchen>
Date: Wed Feb 14 22:26:54 2018 +0000
Fix boundary for test introduced in 3e3f1029c9ec6c63e430ff51063a6301d4b2262
This fixes breakage of DHCPv6 relay.
diff --git a/src/rfc3315.c b/src/rfc3315.c
index c3c1c95..21fcd9b 100644
--- a/src/rfc3315.c
+++ b/src/rfc3315.c
@@ -216,9 +216,9 @@ static int dhcp6_maybe_relay(struct state *state, void *inbuff, size_t sz,
for (opt = opts; opt; opt = opt6_next(opt, end))
{
- if (opt6_ptr(opt, 0) + opt6_len(opt) >= end) {
+ if (opt6_ptr(opt, 0) + opt6_len(opt) > end)
return 0;
- }
+
int o = new_opt6(opt6_type(opt));
if (opt6_type(opt) == OPTION6_RELAY_MSG)
{
Result when testing with: dnsmasq-2.76-2.el7.x86_64 Oct 01 14:09:26 pxe-server.lab.example.com dnsmasq[1345]: started, version 2.76 DNS disabled Oct 01 14:09:26 pxe-server.lab.example.com dnsmasq[1345]: compile time options: IPv6 GNU-getopt DBus no-i18n IDN DHCP DHCPv6 no-Lua TFTP no-conntrack ipset auth no-DNSSEC loop-detect inotify Oct 01 14:09:26 pxe-server.lab.example.com dnsmasq-dhcp[1345]: DHCPv6, IP range fd12:3456:789a:2::aaaa -- fd12:3456:789a:2::ffff, lease time 10m Oct 01 14:09:26 pxe-server.lab.example.com dnsmasq-dhcp[1345]: DHCPv6, IP range fd12:3456:789a:1::aaaa -- fd12:3456:789a:1::ffff, lease time 10m Oct 01 14:09:47 pxe-server.lab.example.com dnsmasq-dhcp[1345]: DHCPINFORMATION-REQUEST(eth1) 00:04:c4:4d:7a:ed:13:a4:ad:49:ba:27:61:7c:ff:09:d1:b2 Oct 01 14:10:48 pxe-server.lab.example.com dnsmasq-dhcp[1345]: DHCPSOLICIT(eth1) 00:04:c4:4d:7a:ed:13:a4:ad:49:ba:27:61:7c:ff:09:d1:b2 Oct 01 14:10:48 pxe-server.lab.example.com dnsmasq-dhcp[1345]: DHCPADVERTISE(eth1) fd12:3456:789a:2::aaaa 00:04:c4:4d:7a:ed:13:a4:ad:49:ba:27:61:7c:ff:09:d1:b2 Oct 01 14:10:53 pxe-server.lab.example.com dnsmasq-dhcp[1345]: DHCPREQUEST(eth1) 00:04:c4:4d:7a:ed:13:a4:ad:49:ba:27:61:7c:ff:09:d1:b2 Oct 01 14:10:53 pxe-server.lab.example.com dnsmasq-dhcp[1345]: DHCPREPLY(eth1) fd12:3456:789a:2::aaaa 00:04:c4:4d:7a:ed:13:a4:ad:49:ba:27:61:7c:ff:09:d1:b2 Oct 01 14:11:24 pxe-server.lab.example.com dnsmasq-dhcp[1345]: DHCPRELEASE(eth1) 00:04:c4:4d:7a:ed:13:a4:ad:49:ba:27:61:7c:ff:09:d1:b2 Result when testing with: dnsmasq-2.76-5.el7.x86_64 Oct 01 14:13:27 pxe-server.lab.example.com dnsmasq[1391]: started, version 2.76 DNS disabled Oct 01 14:13:27 pxe-server.lab.example.com dnsmasq[1391]: compile time options: IPv6 GNU-getopt DBus no-i18n IDN DHCP DHCPv6 no-Lua TFTP no-conntrack ipset auth no-DNSSEC loop-detect inotify Oct 01 14:13:27 pxe-server.lab.example.com dnsmasq-dhcp[1391]: DHCPv6, IP range fd12:3456:789a:2::aaaa -- fd12:3456:789a:2::ffff, lease time 10m Oct 01 14:13:27 pxe-server.lab.example.com dnsmasq-dhcp[1391]: DHCPv6, IP range fd12:3456:789a:1::aaaa -- fd12:3456:789a:1::ffff, lease time 10m Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Low: dnsmasq security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2020:3878 |