memAvailable and memCommitted are used for the host statistics are deprecated and not in use for any logic. therfore it should be removed.
Liran, can you please check if it was ever used by engine 4.2+ and if these fields appear in the DWH views? if it's a simple removal, we'll target it
Hi Liran @lrotenbe I see both mem_commited and mem_available in the engine: - mem_commited in table vds_dynamic - mem_available in vds_statistics We do not collect mem_commited and mem_available from engine to DWH.
Note that the columns are also in the engine views: - mem_commited, and mem_available both in vds, and vds_with_tags views.
Yes mem_commited is calculated by the engine, shouldn't be removed. The 'memCommitted' should (VDSM). The 'memAvailable' should be dropped from both, as it seem unused and deprecated for years. Thanks for the confirmation Aviv!
Verified on RHV 4.4.8-4. All looks good to me. Env: - Engine instance with RHV 4.4.8-4 (ovirt-engine-4.4.8.3-0.10.el8ev) and RHEL 8.4 installed. - 3 hosts with RHV 4.4.8-4 and RHEL 8.4, vdsm-4.40.80.4-1.el8ev Tests: - Check that memAvailable and memCommited were removed from the host's stats in vdsm. Steps: 1. Run the command in 1 of the hosts - "vdsm-client Host getStats | grep mem". 2. Check that memAvailable and memCommited attributes aren't present in the command's output. Results (As Expected): 1. The command returned the host's stats. 2. memAvailable and memCommited attributes aren't present in the command's output. - Check that memAvailable was removed from the engine. Tests: - Check that the column memAvailable was removed from the views vds_with_tags and vds, the table vds_statistics and from the functions InsertVdsStatistics and UpdateVdsStatistics. Result (As Expected): The column memAvailable was removed from all those entities. - Do a manual regression. In Admin Portal: 1. Create a 4.5 data center and a 4.5 cluster. 2. Install the host and create a new NFS storage domain. 3. Create a RHEL 8.3 VM with NIC, 3GB memory and set it to start on the same host only. 4. Run the VM and check for it's memory usage with the "free" command. 5. Fill the memory on the host. 6. Check that the host's memory values was updated in the host's page. 7. Check that the VM is running normally and it's memory usage values didn't change drastically. Results (As Expected): 1. The 4.5 data center and the 4.5 cluster were created. 2. The host was installed and the NFS storage domain was created. 3. The VM was created. 4. The VM is running and the memory values are normal. 5. The Host's memory is almost full. 6. The memory values were updated in the host's page. 7. The VM is running normally and it's memory usage values didn't change drastically.
This bugzilla is included in oVirt 4.4.8 release, published on August 19th 2021. Since the problem described in this bug report should be resolved in oVirt 4.4.8 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.