Description of problem:

The daemon_logv() function, when used with syslog facility, always sends the log to syslog, whatever the priority:

dlog.c:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
 35 static int daemon_verbosity_level = LOG_INFO;

 46 void daemon_logv(int prio, const char* template, va_list arglist) {
 47     int saved_errno;
 48 
 49     saved_errno = errno;
 50 
 51     if (daemon_log_use & DAEMON_LOG_SYSLOG) {
 52         openlog(daemon_log_ident ? daemon_log_ident : "UNKNOWN", LOG_PID, LOG_DAEMON);
 53         vsyslog(prio | LOG_DAEMON, template, arglist);
 54     }
 55 
 56     if (prio > daemon_verbosity_level)
 57         goto end_daemon_logv;
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

The condition on line 56 should be moved prior to line 51.

This results in NetworkManager's teamd daemon, a daemonlog client, to send Debug messages every second even though daemon_verbosity_level is set to LOG_INFO.

Note that this may be expected behaviour, from dlog.h:
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------
 94 /** Setter for the verbosity level of standard output.
 95  *
 96  * @param verbosity_prio Minimum priority level for messages to output
 97  * on standard output/error
 98  *
 99  * Allows to decide which messages to output on standard output/error
100  * streams. All messages are logged to syslog and this setting does
101  * not influence that.
102  *
103  * The default value is LOG_WARNING.
104  *
105  * @since 0.14
106  * @see DAEMON_SET_VERBOSITY_AVAILABLE
-------- 8< ---------------- 8< ---------------- 8< ---------------- 8< --------

If so, then filtering should be made on the client side, which looks redundant to me.

In any case, even if it's expected behaviour the line 103 should be changed because default value is not LOG_WARNING, but LOG_INFO (see dlog.c line 35 above).


Version-Release number of selected component (if applicable):

libdaemon-0.14-7.el7.x86_64


How reproducible:

Always