RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1758153 - RFE: add TPM1.2 passthrough support
Summary: RFE: add TPM1.2 passthrough support
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: edk2
Version: 8.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Marc-Andre Lureau
QA Contact: Qinghua Cheng
URL:
Whiteboard:
Depends On: edk2-rebase-rhel-8.3
Blocks: 1734505
TreeView+ depends on / blocked
 
Reported: 2019-10-03 12:30 UTC by Marc-Andre Lureau
Modified: 2023-10-06 18:38 UTC (History)
14 users (show)

Fixed In Version: edk2-20200602gitca407c7246bf-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-03-25 03:53:15 UTC
Type: Feature Request
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
ovmf tpm1 patch (6.91 KB, patch)
2019-10-03 12:31 UTC, Marc-Andre Lureau
no flags Details | Diff

Description Marc-Andre Lureau 2019-10-03 12:30:24 UTC
In bug 1734505, a customer is trying to passthrough a TPM 1.2 device and enabling windows bitlocker with UEFI.

Under some limited context, it is possible to passthrough a TPM 1.2 device and enabling windows bitlocker with seabios. (When seabios detects a passthrough TPM, it doesn't extend any PCR)

Currently, ovmf supports vTPM 2.0 only.

Adding support for TPM 1.2 seems quite straightforward. I removed PCR extension altogether for now. Bitlocker seems quite happy about the result, although I lack a host with IMA/grub meansurements to confirm this is enough.

See attached patch

Comment 1 Marc-Andre Lureau 2019-10-03 12:31:16 UTC
Created attachment 1622293 [details]
ovmf tpm1 patch

Comment 8 Laszlo Ersek 2020-02-23 20:06:27 UTC
Related upstream patches, posted by Marc-André:

[edk2-devel] [PATCH v2 0/3] Ovmf: enable TPM 1.2
http://mid.mail-archive.com/20200213131222.157700-1-marcandre.lureau@redhat.com
https://edk2.groups.io/g/devel/message/54362

Comment 9 Laszlo Ersek 2020-03-02 20:37:45 UTC
Further iterations:

[edk2-devel] [PATCH v3 0/6] Ovmf: enable TPM 1.2
https://edk2.groups.io/g/devel/message/54854
http://mid.mail-archive.com/20200226093459.1131530-1-marcandre.lureau@redhat.com

[edk2-devel] [PATCH v4 0/5] Ovmf: enable TPM 1.2
https://edk2.groups.io/g/devel/message/54894
http://mid.mail-archive.com/20200226152433.1295789-1-marcandre.lureau@redhat.com

V4 is ready to go in, with Simon Hardy's T-b, once edk2-stable202002 is tagged and the hard feature freeze ends (expected on March 4th).

Comment 10 Laszlo Ersek 2020-03-04 12:25:02 UTC
Upstream v4 has been merged as commit range ecb30848fdc9..61d3b2d4279e, via <https://github.com/tianocore/edk2/pull/416/>.

Comment 16 Qinghua Cheng 2020-06-28 12:07:55 UTC
Verified on RHEL 8.3

kernel: 4.18.0-215.el8.x86_64
qemu-kvm: qemu-kvm-4.2.0-19.module+el8.3.0+6473+93e27135.x86_64
edk: edk2-ovmf-20200602gitca407c7246bf-1.el8.noarch

Verified with windows 2019 guest:
passthrough test: pass
Run bitlocker app: BZ 1734505

Verified with linux rhel 8.3 guest: 
passthrough test: pass


Note You need to log in before you can comment on or make changes to this bug.