Spec URL: https://packages.groonga.org/tmp/fasttext.spec SRPM URL: https://packages.groonga.org/tmp/fasttext-0.9.1-1.fc30.src.rpm Description: Efficient learning of word representations and sentence classification Fedora Account System Username: kenhys It is not in good shaped package yet, but I need some advice how to solve issues. * can't enable hardening properly. currently hardening is disabled in above spec. /usr/bin/c++ -pthread -std=c++11 -funroll-loops -O3 -march=native -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/re dhat-hardened-ld -rdynamic CMakeFiles/fasttext-bin.dir/src/main.cc.o -o fasttext -Wl,-rpath,/home/vagrant/rpmbuild/BUILD/fastText-0.9.1: - lpthread libfasttext.so.0 /usr/bin/ld: CMakeFiles/fasttext-bin.dir/src/main.cc.o: relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a PIE o bject; recompile with -fPIC I've tried to apply https://fedoraproject.org/wiki/Changes/Harden_All_Packages, but no luck. * can't build debuginfo package properly. currently debug package is disabled in above spec because of Empty %files file debugsourcefiles.list.
- Add a comment for each patch explaining why they are needed (could be a link to a bug report or a merge request) - Group: is not used in Fedora - Use a better name for your archive: Source0: https://github.com/facebookresearch/fastText/archive/v%{version}/%{name}-%{version}.tar.gz - Not used since Fedora 28: Requires(post): /sbin/ldconfig Requires(postun): /sbin/ldconfig %post libs -p /sbin/ldconfig %postun libs -p /sbin/ldconfig - Not needed: %clean - Not needed: %defattr(-,root,root,-) - Use %autosetup -p1 -n fastText-%{version} instead of: %setup -q -n fastText-%{version} %patch0 -p1 %patch1 -p1 %patch2 -p1 %patch3 -p1 - In order to avoid unintentional soname bump we forbud globbing the major soname version, be more specific instead: %{_libdir}/*.so.* - Not ok: %global debug_package %{nil} You need to find why there is no debug info produced. The CMakeLists.txt doesn't respect the CXXFLAGS set by %cmake, you need to patch it to remove what is set here: set(CMAKE_CXX_FLAGS " -pthread -std=c++11 -funroll-loops -O3 -march=native") march=native and O3 are notably not ok for Fedora! diff -up fastText-0.9.1/CMakeLists.txt.orig fastText-0.9.1/CMakeLists.txt --- fastText-0.9.1/CMakeLists.txt.orig 2019-07-04 13:48:15.000000000 +0200 +++ fastText-0.9.1/CMakeLists.txt 2019-10-06 20:30:26.513646833 +0200 @@ -15,8 +15,6 @@ set (fasttext_VERSION_MINOR 1) include_directories(fasttext) -set(CMAKE_CXX_FLAGS " -pthread -std=c++11 -funroll-loops -O3 -march=native") - set(HEADER_FILES src/args.h src/densematrix.h - Add dots at the end of your description sentences. - Build with fPIC instead of removing hardening entirely %build export CXXFLAGS="%build_cxxflags -fPIC" %cmake . %make_build V=1 - You must install the license file with %license in %files and you should install the others docs with %doc in %files: %files libs %license LICENSE %doc CODE_OF_CONDUCT.md CONTRIBUTING.md README.md - You need to BR gcc and gcc-c--: BuildRequires: gcc BuildRequires: gcc-c++
Thank you for reviewing. I've updated spec and SRPM Spec URL: https://packages.groonga.org/tmp/fasttext/fasttext.spec SRPM URL: https://packages.groonga.org/tmp/fasttext/fasttext-0.9.1-1.fc30.src.rpm Here is the summary for updates. * Removed unused Group * Removed unused ldconfig scriptlet * Removed needless %defattr, %clean * Updated Source0: URL correctly * Added %license tag * Added missing BR to gcc-c++ * Added comments for patches * Fixed to unintentional soname bump (less globbing in %files) * Fixed %description, add missing . in end of sentences * Fixed to use %autosetup instead of series of %patch * Added a patch to enable hardening with -fPIC
- Own this directory: [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/fasttext %{_includedir}/fasttext/*.h → %{_includedir}/fasttext/ Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Expat License", "Unknown or generated", "Expat License Public domain", "*No copyright* Public domain". 428 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/fasttext/review-fasttext/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/include/fasttext [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fasttext-libs , fasttext-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fasttext-0.9.1-1.fc32.x86_64.rpm fasttext-libs-0.9.1-1.fc32.x86_64.rpm fasttext-devel-0.9.1-1.fc32.x86_64.rpm fasttext-debuginfo-0.9.1-1.fc32.x86_64.rpm fasttext-debugsource-0.9.1-1.fc32.x86_64.rpm fasttext-0.9.1-1.fc32.src.rpm fasttext.x86_64: W: no-documentation fasttext.x86_64: W: no-manual-page-for-binary fasttext fasttext-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libfasttext.so.0 exit.5 fasttext-devel.x86_64: W: no-documentation 6 packages and 0 specfiles checked; 0 errors, 4 warnings.
Thank you for reviewing. I've updated spec and SRPM again. Spec URL: https://packages.groonga.org/tmp/fasttext/fasttext.spec SRPM URL: https://packages.groonga.org/tmp/fasttext/fasttext-0.9.1-1.fc30.src.rpm Directory ownership issue was fixed.
Here is the diff to the previous version in https://bugzilla.redhat.com/show_bug.cgi?id=1758487#c4 % diff -u fasttext.v2.spec fasttext.spec --- fasttext.v2.spec 2019-10-07 16:46:14.772791086 +0900 +++ fasttext.spec 2019-10-09 13:33:45.136620422 +0900 @@ -65,7 +65,8 @@ %{_libdir}/libfasttext.so.0 %files devel -%{_includedir}/fasttext/*.h +%dir %{_includedir}/fasttext +%{_includedir}/fasttext/ %{_libdir}/libfasttext.so %{_libdir}/pkgconfig/fasttext.pc
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fasttext
Please close your Review Requests when they are complete.