Bug 175899 - Review Request: perl-DBD-CSV - DBI driver for CSV files
Summary: Review Request: perl-DBD-CSV - DBI driver for CSV files
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Paul Howarth
QA Contact: David Lawrence
URL: http://search.cpan.org/dist/DBD-CSV/
Whiteboard:
Depends On: perl-Text-CSV_XS
Blocks: FE-ACCEPT 176137
TreeView+ depends on / blocked
 
Reported: 2005-12-16 00:26 UTC by Jose Pedro Oliveira
Modified: 2008-12-18 00:34 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-01-31 14:19:44 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Jose Pedro Oliveira 2005-12-16 00:26:06 UTC
Spec Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-DBD-CSV.spec

SRPM Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-DBD-CSV-0.22-1.src.rpm

Description:
The DBD::CSV module is yet another driver for the DBI (Database
independent interface for Perl). This one is based on the SQL
"engine" SQL::Statement and the abstract DBI driver DBD::File
and implements access to so-called CSV files (Comma separated
values). Such files are mostly used for exporting MS Access and
MS Excel data.

Note: This is a perl-Log-Log4perl BR

Comment 1 Jose Pedro Oliveira 2005-12-19 17:41:46 UTC
SRPM Name or Url:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-DBD-CSV-0.22-2.src.rpm

Changelog:
Added missing build requirement perl(DBD::CSV) >= 0.30.
This perl module is shipped
   i) standalone
  ii) and inside the DBI tarball (since  DBI >= 1.42)

Comment 2 Paul Howarth 2006-01-30 15:11:41 UTC
Review:

- rpmlint clean
- package and spec naming OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in English and is legible
- sources match upstream
- package builds OK on FC4 (i386) and in mock for rawhide (i386)
- BR's OK
- no locales, libraries, pkgconfigs or subpackages to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no desktop entry needed
- no scriptlets

Approved.


Comment 3 Jose Pedro Oliveira 2006-01-31 14:19:44 UTC
Already built for devel.
Pending: FC-4 CSV branch creation.

Comment 4 Steven Pritchard 2008-12-16 20:22:48 UTC
Package Change Request
======================
Package Name: perl-DBD-CSV
New Branches: EL-4 EL-5
Owners: steve

Comment 5 Kevin Fenzi 2008-12-18 00:34:16 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.