Bug 1759430

Description of problem:
Overcloud nodes, once deployed comes up with ethX name for all types of intel interfaces. These are usually referred to as 'non-persistent nic names' : https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/networking_guide/sec-disabling_consistent_network_device_naming

Although introspection data gives consistent nic names like enoX , ensXfY , ensX etc.
The older versions of RHOS had consistent names in the overcloud.

This difference is due to the 'net.ifnames=0' in grub config.
[root@overcloud-computeovsdpdksriov-1 ~]# grep GRUB_CMDLINE_LINUX /etc/sysconfig/grub
GRUB_CMDLINE_LINUX="console=ttyS0 console=ttyS0,115200n81 no_timer_check net.ifnames=0 crashkernel=auto rhgb quiet"
GRUB_CMDLINE_LINUX="${GRUB_CMDLINE_LINUX:+$GRUB_CMDLINE_LINUX }${TRIPLEO_HEAT_TEMPLATE_KERNEL_ARGS}"
GRUB_CMDLINE_LINUX_DEFAULT="${GRUB_CMDLINE_LINUX_DEFAULT:+$GRUB_CMDLINE_LINUX_DEFAULT }\$tuned_params"
[root@overcloud-computeovsdpdksriov-1 ~]# cat /proc/cmdline 
BOOT_IMAGE=(hd0,msdos2)/boot/vmlinuz-4.18.0-80.11.1.el8_0.x86_64 root=UUID=064cb90a-9365-4963-9e64-9bc6e71842eb ro console=ttyS0 console=ttyS0,115200n81 no_timer_check net.ifnames=0 crashkernel=auto rhgb quiet default_hugepagesz=1GB hugepagesz=1G hugepages=104 iommu=pt intel_iommu=on isolcpus=2-39 skew_tick=1 nohz=on nohz_full=2-39 rcu_nocbs=2-39 tuned.non_isolcpus=00000003 intel_pstate=disable nosoftlockup



Version-Release number of selected component (if applicable):
RHOS15 GA

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:
All intel nics are named as ethX names, confusing the user as the introspection data gives different names. Using consistent names would end in deployment / os-net-config failure.

Expected results:
NIC Names seen introspection data should be same as the nic names created by kernel while deployment.
The previous behavior of having enoX , ensX is preferred rather than all nic named as ethX.

Additional info:
I prefer this fix to be in the director image by removing 'net.ifnames=0' in grub config.