Bug 1759878 - python-pyvmomi: bring back python2 subpackage
Summary: python-pyvmomi: bring back python2 subpackage
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: python-pyvmomi
Version: epel7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Dominik 'Rathann' Mierzejewski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1757722 (view as bug list)
Depends On: 1763484
Blocks: EPEL7FailsToInstall 1760984
TreeView+ depends on / blocked
 
Reported: 2019-10-09 10:08 UTC by Dominik 'Rathann' Mierzejewski
Modified: 2021-04-15 23:25 UTC (History)
8 users (show)

Fixed In Version: python-pyvmomi-6.7.3-4.el7,python-pyvmomi-7.0.1-2.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-04-15 23:25:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github vmware pyvmomi issues 865 0 'None' 'open' 'tests.test_connect.ConnectionTests fail on RHEL7' 2019-11-28 13:31:32 UTC

Description Dominik 'Rathann' Mierzejewski 2019-10-09 10:08:23 UTC
Description of problem:
https://src.fedoraproject.org/rpms/python-pyvmomi/c/400048ef70a6ba7fd5863c09b4413c4f89274349?branch=epel7 removed python2 support. There's no corresponding upstream reference, so even though you wrote "due to failing tests", I still don't know why, exactly. Please bring back the python2 subpackage, I'm still using it.

Version-Release number of selected component (if applicable):
6.7.3-2.el7

Comment 1 Dominik Mierzejewski 2019-10-14 17:42:09 UTC
I think the two failing tests might be a bug in vcrpy, which is years out of date in EPEL-7 (1.5.2). set_tunnel method is present in both python2 httplib and python3 http.client code since 10 years, so something fishy is going on here.

You disabled tests with python3 in EPEL-7, so you don't even know if they're failing. Dropping python2 subpackage because of two failing tests seems unfair...

Comment 2 Raphael Groner 2019-10-20 08:56:11 UTC
Duplication of bug #1757722. Discussed the python2 support with upstream.
See https://github.com/vmware/pyvmomi/issues/837

Comment 3 Raphael Groner 2019-10-20 08:58:52 UTC
*** Bug 1757722 has been marked as a duplicate of this bug. ***

Comment 4 Raphael Groner 2019-10-20 09:02:51 UTC
> I think the two failing tests might be a bug in vcrpy, which is years out of date in EPEL-7 (1.5.2).

This is actually also a bug in rawhide for FTBFS.
https://bugzilla.redhat.com/show_bug.cgi?id=1763484

Comment 5 Raphael Groner 2019-11-14 07:13:06 UTC
> You disabled tests with python3 in EPEL-7, so you don't even know if they're failing. 
> Dropping python2 subpackage because of two failing tests seems unfair...

DEBUG util.py:686:  Executing command: ['/usr/bin/yum-builddep', '--installroot', '/var/lib/mock/epel7-build-18188773-1298191/root/', '/var/lib/mock/epel7-build-18188773-1298191/root//builddir/build/SRPMS/python-pyvmomi-6.7.3-3.el7.src.rpm'] with env {'TERM': 'vt100', 'SHELL': '/bin/bash', 'HOME': '/var/lib/mock/epel7-build-18188773-1298191/rpmconfig', 'HOSTNAME': 'mock', 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf "\\033]0;<mock-chroot>\\007"', 'PS1': '<mock-chroot> \\s-\\v\\$ ', 'LANG': 'C.UTF-8', 'LC_MESSAGES': 'C.UTF-8', 'LD_PRELOAD': '/var/tmp/tmp.mock.bmkn6olx/$LIB/nosync.so'} and shell False
DEBUG util.py:595:  Last metadata expiration check: 0:00:10 ago on Thu Nov 14 06:59:59 2019.
DEBUG util.py:593:  No matching package to install: 'python36-testtools >= 0.9.34'
DEBUG util.py:593:  No matching package to install: 'python36-vcrpy'
DEBUG util.py:593:  No matching package to install: 'python36-yarl'
DEBUG util.py:593:  No matching package to install: 'python36-fixtures'
DEBUG util.py:593:  No matching package to install: 'python36-tox'
DEBUG util.py:593:  No matching package to install: 'python34-testtools >= 0.9.34'
DEBUG util.py:593:  No matching package to install: 'python34-vcrpy'
DEBUG util.py:593:  No matching package to install: 'python34-yarl'
DEBUG util.py:593:  No matching package to install: 'python34-fixtures'
DEBUG util.py:593:  No matching package to install: 'python34-tox'
DEBUG util.py:593:  Not all dependencies satisfied

https://koji.fedoraproject.org/koji/taskinfo?taskID=38986280

Comment 6 Dominik 'Rathann' Mierzejewski 2019-11-14 11:12:30 UTC
If you don't want to maintain the python2 subpackage (I know it works for me and I'm using it) then please add me to co-maintainers (FAS: rathann). I'll maintain it for you. I find it very frustrating that you simply dropped the python2 subpackage because of two failing tests when you're not even testing the python3 subpackage.

Comment 7 Raphael Groner 2019-11-14 11:21:53 UTC
According to FAS, you're provenpackager. Please feel free to use the power. :-)

But again, I doubt there's much sense to continue with a python2 subpackage. We'd run into version conflicts, e.g. I've already discussed with upstream about python2 and any further releases. Why not stick with EPEL6 then, as downgrade? EPEL7 has somehow a long period left for stable support and I'm not convinced to use downstream forks to heavily insist on py2 enforcements anywhere.

Comment 8 Dominik 'Rathann' Mierzejewski 2019-11-14 11:46:03 UTC
(In reply to Raphael Groner from comment #7)
> According to FAS, you're provenpackager. Please feel free to use the power. :-)

I am, but I don't want to abuse that power, so I'm asking first. Adding me to co-maintainers would make it official. Anyway, I've added a bugzilla watch on the EPEL component for the time being and I'll bring back the EPEL7 python2 subpackage shortly. Thank you.

> But again, I doubt there's much sense to continue with a python2 subpackage. We'd run into version conflicts, e.g. I've already discussed with upstream about python2 and any further releases.

I saw the ticket, it was inconclusive.

> Why not stick with EPEL6 then, as downgrade? EPEL7 has somehow a long period left for stable support and I'm not convinced to use downstream forks to heavily insist on py2 enforcements anywhere.

I'm using this on RHEL7 as part of internal OpenShift-related tooling. Downgrading to RHEL6 is not an option. I have plans for moving my tooling to python3, but that takes time, and I need a working version now.

Comment 9 Troy Dawson 2019-11-14 14:38:01 UTC
Dominik, are you also using python2-pyvirtualize?
We are thinking of removing that python2 package, because it can't install, but if you planning on maintaining python2-pyvmomi, and are using python2-pyvirtualize, then we can hold off on that.

Comment 10 Raphael Groner 2019-11-14 15:08:32 UTC
(In reply to Troy Dawson from comment #9)
> Dominik, are you also using python2-pyvirtualize?
> We are thinking of removing that python2 package, because it can't install,
> but if you planning on maintaining python2-pyvmomi, and are using
> python2-pyvirtualize, then we can hold off on that.

Maybe take an alternative look into python-vconnector and its further depending packages instead. They seem to provide the better API and show more active development from upstream. Honestly, I doubt I'm going to continue with pyvirtualize anyhow.

Comment 11 Raphael Groner 2019-11-14 15:10:13 UTC
(In reply to Dominik 'Rathann' Mierzejewski from comment #8)
> (In reply to Raphael Groner from comment #7)

> I'm using this on RHEL7 as part of internal OpenShift-related tooling.
> Downgrading to RHEL6 is not an option. I have plans for moving my tooling to
> python3, but that takes time, and I need a working version now.

That smells like need for a separate python2-pyvmomi package then for legacy reasons. It can have a completely separate version model.

Comment 12 Fedora Update System 2019-11-29 03:37:55 UTC
python-pyvmomi-6.7.3-4.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-92d7ecde76

Comment 13 Fedora Update System 2019-12-14 01:04:56 UTC
python-pyvmomi-6.7.3-4.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Frank Adaemmer 2021-03-03 08:07:20 UTC
python2-pyvmomi went missing again. Anyone knows the reason for that? @updates

Comment 15 Dominik 'Rathann' Mierzejewski 2021-03-03 11:10:51 UTC
IT looks like Raphael removed the python2 package again from EPEL7:
https://src.fedoraproject.org/rpms/python-pyvmomi/c/a28fbaa61c302539c30bd8d68de96dadaec2f3e3?branch=epel7

Raphael, please revert.

Comment 16 Dominik 'Rathann' Mierzejewski 2021-03-03 11:23:35 UTC
Or actually, I'll fix it myself, as it's a quick fix.

Comment 17 Dominik 'Rathann' Mierzejewski 2021-03-03 11:30:18 UTC
7.0.1-2 contains python2 package again: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-3aa347a6ab . Please test and give karma.

Comment 18 Frank Adaemmer 2021-03-03 13:46:48 UTC
Thank you, that was fast. :-)

Comment 19 Raphael Groner 2021-03-03 15:41:39 UTC
It was agreed in another bug that python2 has no future in case of pyvmomi upstream, so the decision is clear to have a downstream issue here and I refuse to maintain.

(In reply to Raphael Groner from comment #11)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #8)
> > (In reply to Raphael Groner from comment #7)
> 
> > I'm using this on RHEL7 as part of internal OpenShift-related tooling.
> > Downgrading to RHEL6 is not an option. I have plans for moving my tooling to
> > python3, but that takes time, and I need a working version now.
> 
> That smells like need for a separate python2-pyvmomi package then for legacy
> reasons. It can have a completely separate version model.

Comment 20 Raphael Groner 2021-03-03 15:44:26 UTC
There's no official support from upstream any more for python2. Good luck then!
https://github.com/vmware/pyvmomi/issues/837

Comment 21 Dominik 'Rathann' Mierzejewski 2021-03-03 16:04:04 UTC
(In reply to Raphael Groner from comment #19)
> It was agreed in another bug that python2 has no future in case of pyvmomi
> upstream, so the decision is clear to have a downstream issue here and I
> refuse to maintain.

Who agreed and where? It certainly wasn't me. Nobody's asking you to do anything special to maintain the python2 package. Just please stop removing it quietly when it still works fine.

If and when a new version stops working with python2, I'll look at introducing a separate legacy python2 package, but that would be a lot of unnecessary work right now.

Comment 22 Raphael Groner 2021-03-03 16:33:14 UTC
> Just please stop removing it quietly when it still works fine.

No, tests fail and upstream refused to fix in case of python2 execution. Did you read the linked upstream issue?

> I'll look at introducing a separate legacy python2 package

Indeed same thought here but no interest from my side. Please feel free to start that fork.

Comment 23 Frank Adaemmer 2021-03-04 08:50:25 UTC
I understand your position and I just want to add a "users" perspective. As I have written in bug #1934425 we want to use ansible. Now we cannot use ansible package (base on python 2) because we need pyvmomi and we cannot use ansible-python3 package because we need e.g. python winrm module.

Comment 24 Raphael Groner 2021-03-04 09:47:31 UTC
> As I have written in bug #1934425 we want to use ansible.

Well, both Ansible (from Red Hat) and VMware are all commercial products. Me as a community member and unpaid Fedora contributor can not help with compatibility issues born from silly management decision. What does user mean.

> we need e.g. python winrm module.

WinRM is from Microsoft, blame them instead. Why not SSH as alternative?


Note You need to log in before you can comment on or make changes to this bug.