From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.8) Gecko/20050512 Red Hat/1.0.4-1.4.1 Firefox/1.0.4 Description of problem: hangcheck-timer kernel modules are currently not build on s390 and s390x arches. Version-Release number of selected component (if applicable): kernel-2.6.9-25 How reproducible: Always Steps to Reproduce: 1.install RHEL4 U3 kernel on s390 machine 2.cd /lib/modules/2.6.9-25/ 3.search for hangcheck-timer.ko Additional info:
This is just a matter of including the Kconfig where HANGCHECK_TIMER is configured. But this is drivers/char/Kconfig which we currently do not include from s390 Kconfig since there is too much stuff there that don't makes sense on s390. I wonder why the hangcheck timer is not in the watchdog directory? (The watchdog/Kconfig is included from s390 Kconfig).
The hangcheck timer also needs a monotonic_clock function. This is currently not implemented on s390 but it could be easily done by using get_clock().
Um, just figured out that Jason already added the monotonic_clock function, so this patch is not upstream. Jason: The comment from the archs that have the monotonic_clock() says: /* monotonic_clock(): returns # of nanoseconds passed since time_init() Your code just returns get_clock() which is nanoseconds since 1900. But time_init should refer to the time the machine booted. Therfore it should be get_clock() - jiffies_timer_cc, or?
well, i agree it doesn't meet the spec, but the way its implemented should be fine since we subtract out the previous value that monotonic_clock() returned. thus, the starting point is irrelevant as long as its conssitent.
Correct, it should work if it only takes the difference. But I think this could be easier done by adding the monotonic_clock interface to s390 arch code. See my attached patch. BTW, your definition of the s390 second had a typo ;-
Created attachment 123076 [details] hangcheck-timer.diff
look good to me...probably worth sending upstream as well.
I've talked with Martin Schwidefsky, he has no objections to the monotonic_clock in our arch code, so we will send this upstream too.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHSA-2006-0132.html