Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1760554

Summary: FAIL: Gaps were detected in the annobin coverage.
Product: Red Hat Enterprise Linux 8 Reporter: Flavio Leitner <fleitner>
Component: annobinAssignee: Nick Clifton <nickc>
Status: CLOSED CURRENTRELEASE QA Contact: qe-baseos-tools-bugs
Severity: medium Docs Contact:
Priority: medium    
Version: 8.0CC: ctrautma, fweimer, jhsiao, mcermak, nickc, ralongi
Target Milestone: rc   
Target Release: 8.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-10-16 11:01:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Flavio Leitner 2019-10-10 19:45:56 UTC 
Description of problem:

Errata complains about gaps:
Detecting usr/sbin/ovsdb-server with not-hardened warnings '
Hardened: ovsdb-server: FAIL: Gaps were detected in the annobin coverage.  Run with -v to list.' on x86_64

https://rpmdiff.engineering.redhat.com/run/418735/7/

Version-Release number of selected component (if applicable):
openvswitch2.12-2.12.0-2.el8fdp

How reproducible:
Always

Steps to Reproduce:
# annocheck --verbose /usr/bin/ovs-appctl | grep gap:
Hardened: /usr/bin/ovs-appctl: gap:  (24a00..25fa9 probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/build-static/../dpdk-stable-18.11.2/x86_64-native-linuxapp-gcc/include/rte_ethdev.h) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (26070..266de probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/dpdk-stable-18.11.2/lib/librte_eal/common/eal_common_memzone.c) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (26790..26c51 probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/dpdk-stable-18.11.2/lib/librte_eal/common/eal_common_memory.c) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (26df0..275e0 probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/dpdk-stable-18.11.2/lib/librte_eal/common/eal_common_bus.c) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (27630..277cb probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/dpdk-stable-18.11.2/lib/librte_eal/common/eal_common_proc.c) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (27e60..2808b probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/dpdk-stable-18.11.2/lib/librte_eal/common/eal_common_proc.c) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (28240..28317 probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/dpdk-stable-18.11.2/lib/librte_eal/common/eal_common_proc.c) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (28390..28b9a probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/dpdk-stable-18.11.2/lib/librte_eal/common/rte_malloc.c) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (28bc0..2a54e probable component: /usr/src/debug/openvswitch2.12-2.12.0-2.el8fdp.x86_64/dpdk-stable-18.11.2/lib/librte_eal/linuxapp/eal/eal_memory.c) in annobin notes.
Hardened: /usr/bin/ovs-appctl: gap:  (2a6b0..2c272 probable component: get_xstats_count.cold.15) in annobin notes.


Actual results:
Many gaps are found in different binaries

Expected results:
No gaps.

Additional info:
Comment 2 Flavio Leitner 2019-10-11 14:58:40 UTC 
Looks like there is a bug in annobin maybe due to how the package is built.
Let me know how I can help from the package side.
Thanks,
fbl
Comment 3 Nick Clifton 2019-10-15 13:09:20 UTC 
Hi Flavio,

  What is the name of the package for openvswitch ?

  Ie I am trying to rebuild the ovsdb-server binary locally, so that I can see 
  how it is compiled, but at the moment I do not know how to check out the
  RHEL 8.1 sources.  I tried:

    % rhpkg clone -b rhel-8.1.0 openvswitch rhel-8.1.0
    [...]
    fatal: Remote branch rhel-8.1.0 not found in upstream origin

Cheers
  Nick
Comment 4 Flavio Leitner 2019-10-15 14:48:38 UTC 
(In reply to Nick Clifton from comment #3)
>   What is the name of the package for openvswitch ?
We support multiple versions, so the name contains the version as well.
Also we don't ship as part of RHEL, so the branches are different:

% rhpkg clone -b fast-datapath-rhel-8 openvswitch2.12 fast-datapath-rhel-8

fbl
Comment 5 Nick Clifton 2019-10-16 11:01:58 UTC 
Hi Flavio,

  Thanks for the package details.  With that I was able to reproduce the
  problem locally, and I have some good news:

  * This definitely is a bug in annobin, not openvswitch.
  * The bug has already been fixed.

  The bad news is that the fix is in RHEL 8.1.0 but not RHEL 8.0.0.
  (Specifically the fix is in annobin version 8.65 and later, but
  8.0.0 uses annobin 8.64).

  So if you are able to rebuild on 8.1.0 the problem will go away.
  Alternatively just feel free to continue waiving FAIL results for gaps.
  The cause is a bug in the annobin plugin which is generating the wrong
  section name for the notes for unlikely-to-execute code.

  I do not think that this problem is sufficient to warrant a z-stream
  fix for 8.0.0 however, so I am just going to close this BZ with
  FIXED/CURRENTRELEASE.

Cheers
  Nick
Comment 6 Flavio Leitner 2019-10-16 12:14:00 UTC 
OK, we will waive temporarily until the fix land in the proper places.
Thanks Nick!