Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://www.flyn.org/SRPMS/sphinxbase.spec SRPM URL: https://www.flyn.org/SRPMS/sphinxbase-5prealpha-6.fc30.src.rpm Description: Common library for CMU Sphinx voice recognition products Fedora Account System Username: mikep
The sphinxbase package was recently retired, and I am trying to revitalize it. Corresponding release engineering ticket: https://pagure.io/releng/issue/8898
Version 5prealpha is not valid. 5prealpha > 5. See https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
The CMU Sphinx versioning seems a bit arbitrary. See https://sourceforge.net/projects/cmusphinx/files/pocketsphinx/. I sent a note to the development team asking for the history and intent of the version numbers. This should allow me to select a good approach from https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/.
- make install DESTDIR=%{buildroot} → %make_install - %ldconfig_scriptlets can be dropeed unless EPEL7 planned - Globbing the whole %{python3_sitearch}/* is forbidden, be more specific instead. %files -n python3-sphinxbase %{python3_sitearch}/sphinxbase - prealpha should be moved to the Release tag as extraver: %global extraver prealpha Release: 6.%{extraver}%{?dist} Problem is it won't be > to the latest released version in f30. Solution here would be to bump Epoch.
Spec URL: https://www.flyn.org/SRPMS/sphinxbase.spec SRPM URL: https://www.flyn.org/SRPMS/sphinxbase-5-6.prealpha.fc30.src.rpm Description: Common library for CMU Sphinx voice recognition products Fedora Account System Username: mikep - Use %make_install - Remove %ldconfig_scriptlets - More specific glob in %{python3_sitearch} - Move prealpha and make use of epoch
Release: 0.1.%{extraver}%{?dist} Also, %changelog entry doesn't match.
Spec URL: https://www.flyn.org/SRPMS/sphinxbase.spec SRPM URL: https://www.flyn.org/SRPMS/sphinxbase-5-0.1.prealpha.fc30.src.rpm Description: Common library for CMU Sphinx voice recognition products Fedora Account System Username: mikep - Adjusted release and fixed changelog
- We forbid globbing the major soname version to avoid unintentional soname bump, please be more specific instead: %{_libdir}/libsphinxad.so.3* %{_libdir}/libsphinxbase.so.3* - Install error: DEBUG util.py:595: Error: DEBUG util.py:595: Problem 1: conflicting requests DEBUG util.py:595: - nothing provides sphinxbase-libs(x86-64) = 5-0.1.prealpha.fc32 needed by python3-sphinxbase-1:5-0.1.prealpha.fc32.x86_64 DEBUG util.py:595: Problem 2: conflicting requests DEBUG util.py:595: - nothing provides sphinxbase-libs(x86-64) = 5-0.1.prealpha.fc32 needed by sphinxbase-devel-1:5-0.1.prealpha.fc32.x86_64 You need to include the Epoch in your Requires (both base and devel packages): Requires: %{name}%{?_isa} = %{?epoch:%{epoch}:}%{version}-%{release} - I would remove this static lib too: Package does not contain any libtool archives (.la) Note: python3-sphinxbase : /usr/lib64/python3.8/site- packages/sphinxbase/_sphinxbase.la See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries find %{buildroot} -name '*.la' -delete instead of rm -f %{buildroot}%{_libdir}/*.la - Add the Epoch in the changelog too: * Sun Oct 13 2019 W. Michael Petullo <mike> - 1:5-0.1.prealpha - Escape variables in your %changelog entries: - More work to switch to Python 3 - Use %%make_install - Remove %%ldconfig_scriptlets - More specific glob in %%{python3_sitearch} - Move prealpha and make use of epoch Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ - Package does not contain any libtool archives (.la) Note: python3-sphinxbase : /usr/lib64/python3.8/site- packages/sphinxbase/_sphinxbase.la See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/sphinxbase See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "GPL (v2 or later)", "FSF Unlimited License (with Retention) GPL (v2 or later)", "FSF Unlimited License (with Retention)", "BSD 3-clause "New" or "Revised" License", "GPL (v3 or later)". 413 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/sphinxbase/review- sphinxbase/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 296960 bytes in 33 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sphinxbase-devel , sphinxbase-libs , python3-sphinxbase [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: sphinxbase-5-0.1.prealpha.fc32.x86_64.rpm sphinxbase-devel-5-0.1.prealpha.fc32.x86_64.rpm sphinxbase-libs-5-0.1.prealpha.fc32.x86_64.rpm python3-sphinxbase-5-0.1.prealpha.fc32.x86_64.rpm sphinxbase-debuginfo-5-0.1.prealpha.fc32.x86_64.rpm sphinxbase-debugsource-5-0.1.prealpha.fc32.x86_64.rpm sphinxbase-5-0.1.prealpha.fc32.src.rpm sphinxbase.x86_64: W: incoherent-version-in-changelog 5-0.1.prealpha ['1:5-0.1.prealpha.fc32', '1:5-0.1.prealpha'] sphinxbase.x86_64: W: manual-page-warning /usr/share/man/man1/sphinx_lm_convert.1.gz 15: warning: macro `lower'' not defined sphinxbase.x86_64: W: no-manual-page-for-binary sphinx_jsgf2fsg sphinxbase-devel.x86_64: W: incoherent-version-dependency-on sphinxbase/sphinxbase-libs/libsphinxbase 5 1:5 sphinxbase-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libsphinxbase.so.3.0.0 exit.5 python3-sphinxbase.x86_64: W: no-documentation sphinxbase.src:39: W: unversioned-explicit-provides bundled(jquery) sphinxbase.src:151: W: macro-in-%changelog %make_install sphinxbase.src:152: W: macro-in-%changelog %ldconfig_scriptlets sphinxbase.src:153: W: macro-in-%changelog %{python3_sitearch} 7 packages and 0 specfiles checked; 0 errors, 10 warnings.
Spec URL: https://www.flyn.org/SRPMS/sphinxbase.spec SRPM URL: https://www.flyn.org/SRPMS/sphinxbase-5-0.1.prealpha.fc30.src.rpm Description: Common library for CMU Sphinx voice recognition products Fedora Account System Username: mikep - Use epoch in requires - Remove remaining .la file - More specific globbing of libraries I edited the changelog to use %% along with the version epoch.
Package approved.
See also https://pagure.io/releng/issue/8898.