Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://raw.githubusercontent.com/RussianFedora/doublecmd/master/doublecmd.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8733/38288733/doublecmd-0.9.6-1.fc32.src.rpm Description: Double Commander is a cross platform open source file manager with two panels side by side. It is inspired by Total Commander and features some new ideas.
%{_mandir}/man1/%{name}.1.gz -> %{_mandir}/man1/%{name}.1.*
I will change it. You can make review?
1. Upstream URL probably should be: Source0: http://sourceforge.net/projects/%{name}/files/Double%20Commander%20Source/%{name}-%{version}-src.tar.gz 2. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor/scalable, /usr/share/polkit-1, /usr/lib/.build-id/ca, /usr/lib/.build-id/99, /usr/share/polkit-1/actions Weird, since there: Requires: hicolor-icon-theme As for polkit seems to be not mandatory to add it Requires, but maybe Recommends? Check this review https://bugzilla.redhat.com/show_bug.cgi?id=1739807#c5 Requires: polkit%{?_isa} 3. This correct %_libdir/%name/%name.zdli ? Or should be %{_libdir}/%{name}/%{name}.zdli ? 4. There many warnings about unstripped-binary-or-object but this is not really true. 5. As for licenses, there tons of them. We should list all of them inf spec file. I'll post whole list in next my post. --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib/.build- id/99/72a27c2b751b7d91fe3f400b10d291f32b950d See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING.FPC.txt is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GPL (v2 or later)", "GPL (v2 or later)", "GPL (v2 or later) (with incorrect FSF address)", "*No copyright* Mozilla Public License GPL (v2 or later) (with incorrect FSF address)", "*No copyright* Mozilla Public License (v1.1) GNU General Public License (v2 or later)", "GNU Lesser General Public License (v2.1 or later)", "Expat License", "BSD 2-clause "Simplified" License", "Public domain", "GNU Lesser General Public License (v3 or later)", "GPL (v3 or later) (with incorrect FSF address)", "*No copyright* Expat License", "GNU Lesser General Public License (v2 or later)", "*No copyright* Mozilla Public License (v1.1)", "*No copyright* Public domain", "*No copyright* Mozilla Public License (v1.1) GNU Lesser General Public License (v2.1 or later)", "Mozilla Public License (v1.1) GNU Lesser General Public License (v2.1 or later)", "Mozilla Public License (v1.1)", "Apache License (v2.0) Creative Commons CC0 Public License (v1.0)", "zlib/libpng license", "BSD 3-clause "New" or "Revised" License", "Mozilla Public License (v1.1) GNU General Public License (v2 or later)", "GNU Lesser General Public License", "BSD 4-clause "Original" or "Old" License", "GNU General Public License (v2)", "*No copyright* Mozilla Public License (v1.1) GNU Lesser General Public License". 1785 files have unknown license. Detailed output of licensecheck in /mnt/data- linux/tmp/1761338-doublecmd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable/apps, /usr/share/icons/hicolor/scalable, /usr/share/polkit-1, /usr/lib/.build-id/ca, /usr/lib/.build-id/99, /usr/share/polkit-1/actions [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/doublecmd(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/dsx(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/dsx/dsxlocate(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wcx(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wcx/cpio(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wcx/deb(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wcx/rpm(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wcx/unrar(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wcx/zip(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wdx(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wdx/audioinfo(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wdx/deb_wdx(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wdx/rpm_wdx(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wdx/scripts(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wfx(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wfx/ftp(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wfx/ftp/language(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wfx/samba(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wlx(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/plugins/wlx/wlxmplayer(Failed, defaulting, set, C, to, locale,), /usr/lib64/doublecmd/scripts(Failed, defaulting, set, C, to, locale,), /usr/share/doc/doublecmd- common(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/doc(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/highlighters(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/language(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/language/lcl(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/cursors(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/128x128(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/128x128/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/128x128/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/16x16(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/16x16/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/16x16/apps(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/16x16/devices(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/16x16/dirhotlist(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/16x16/emblems(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/16x16/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/16x16/places(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/20x20(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/20x20/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/20x20/apps(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/20x20/emblems(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/20x20/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/24x24(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/24x24/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/24x24/apps(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/24x24/devices(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/24x24/dirhotlist(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/24x24/emblems(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/24x24/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/24x24/places(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/32x32(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/32x32/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/32x32/apps(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/32x32/devices(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/32x32/dirhotlist(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/32x32/emblems(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/32x32/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/32x32/places(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/40x40(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/40x40/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/40x40/devices(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/40x40/emblems(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/40x40/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/48x48(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/48x48/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/48x48/devices(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/48x48/emblems(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/48x48/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/60x60(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/60x60/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/60x60/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/64x64(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/64x64/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/64x64/devices(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/64x64/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/72x72(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/72x72/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/72x72/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/8x8(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/8x8/emblems(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/96x96(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/96x96/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/96x96/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/scalable(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/scalable/actions(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/scalable/devices(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/dctheme/scalable/mimetypes(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/mainicon(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/mainicon/alt(Failed, defaulting, set, C, to, locale,), /usr/share/doublecmd/pixmaps/mainicon/colored(Failed, defaulting, set, C, to, locale,), /usr/share/licenses/doublecmd-common(Failed, defaulting, set, C, to, locale,) [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://doublecmd.sourceforge.net/doublecmd/doublecmd-0.9.6-src.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in doublecmd-gtk , doublecmd-qt , doublecmd-common [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 15493120 bytes in /usr/share doublecmd-common-0.9.6-1.fc32.x86_64.rpm:15472640 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: doublecmd-gtk-0.9.6-1.fc32.x86_64.rpm doublecmd-qt-0.9.6-1.fc32.x86_64.rpm doublecmd-common-0.9.6-1.fc32.x86_64.rpm doublecmd-0.9.6-1.fc32.src.rpm doublecmd-gtk.x86_64: W: no-documentation doublecmd-gtk.x86_64: W: no-manual-page-for-binary doublecmd doublecmd-qt.x86_64: W: no-documentation doublecmd-qt.x86_64: W: no-manual-page-for-binary doublecmd-qt doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/dsx/dsxlocate/dsxlocate.dsx doublecmd-common.x86_64: E: shared-lib-without-dependency-information /usr/lib64/doublecmd/plugins/dsx/dsxlocate/dsxlocate.dsx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/cpio/cpio.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/deb/deb.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/rpm/rpm.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/unrar/unrar.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/zip/zip.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wdx/audioinfo/audioinfo.wdx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wdx/deb_wdx/deb_wdx.wdx doublecmd-common.x86_64: E: shared-lib-without-dependency-information /usr/lib64/doublecmd/plugins/wdx/deb_wdx/deb_wdx.wdx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wdx/rpm_wdx/rpm_wdx.wdx doublecmd-common.x86_64: E: shared-lib-without-dependency-information /usr/lib64/doublecmd/plugins/wdx/rpm_wdx/rpm_wdx.wdx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wfx/ftp/ftp.wfx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wfx/samba/samba.wfx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wlx/wlxmplayer/wlxmplayer.wlx doublecmd-common.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/99/72a27c2b751b7d91fe3f400b10d291f32b950d ../../../../usr/lib64/doublecmd/doublecmd doublecmd-common.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/ca/ac107b468875c1b7dd6c9476546b919abbd171 ../../../../usr/lib64/doublecmd/doublecmd-qt doublecmd.src: W: invalid-url Source0: http://doublecmd.sourceforge.net/doublecmd/doublecmd-0.9.6-src.tar.gz HTTP Error 404: Not Found 4 packages and 0 specfiles checked; 3 errors, 19 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_UA.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "ru_UA.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/dsx/dsxlocate/dsxlocate.dsx doublecmd-common.x86_64: E: shared-lib-without-dependency-information /usr/lib64/doublecmd/plugins/dsx/dsxlocate/dsxlocate.dsx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/cpio/cpio.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/deb/deb.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/rpm/rpm.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/unrar/unrar.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wcx/zip/zip.wcx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wdx/audioinfo/audioinfo.wdx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wdx/deb_wdx/deb_wdx.wdx doublecmd-common.x86_64: E: shared-lib-without-dependency-information /usr/lib64/doublecmd/plugins/wdx/deb_wdx/deb_wdx.wdx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wdx/rpm_wdx/rpm_wdx.wdx doublecmd-common.x86_64: E: shared-lib-without-dependency-information /usr/lib64/doublecmd/plugins/wdx/rpm_wdx/rpm_wdx.wdx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wfx/ftp/ftp.wfx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wfx/samba/samba.wfx doublecmd-common.x86_64: W: unstripped-binary-or-object /usr/lib64/doublecmd/plugins/wlx/wlxmplayer/wlxmplayer.wlx doublecmd-common.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/99/72a27c2b751b7d91fe3f400b10d291f32b950d ../../../../usr/lib64/doublecmd/doublecmd doublecmd-common.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/ca/ac107b468875c1b7dd6c9476546b919abbd171 ../../../../usr/lib64/doublecmd/doublecmd-qt doublecmd-qt.x86_64: W: no-documentation doublecmd-qt.x86_64: W: no-manual-page-for-binary doublecmd-qt doublecmd-gtk.x86_64: W: no-documentation doublecmd-gtk.x86_64: W: no-manual-page-for-binary doublecmd 3 packages and 0 specfiles checked; 3 errors, 18 warnings. Requires -------- doublecmd-gtk (rpmlib, GLIBC filtered): doublecmd-common(x86-64) libX11.so.6()(64bit) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libdbus-1.so.3()(64bit) libdbus-1.so.3(LIBDBUS_1_3)(64bit) libdl.so.2()(64bit) libgdk-x11-2.0.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgthread-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libpango-1.0.so.0()(64bit) libpthread.so.0()(64bit) libutil.so.1()(64bit) doublecmd-qt (rpmlib, GLIBC filtered): doublecmd-common(x86-64) libQt5Pas.so.1()(64bit) libX11.so.6()(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-1.so.3(LIBDBUS_1_3)(64bit) libdl.so.2()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libpthread.so.0()(64bit) libutil.so.1()(64bit) doublecmd-common (rpmlib, GLIBC filtered): Provides -------- doublecmd-gtk: application() application(doublecmd.desktop) doublecmd-gtk doublecmd-gtk(x86-64) mimehandler(inode/directory) doublecmd-qt: application() application(doublecmd-qt.desktop) doublecmd-qt doublecmd-qt(x86-64) doublecmd-common: doublecmd-common doublecmd-common(x86-64) Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1761338 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: SugarActivity, Perl, Ocaml, PHP, Python, Haskell, R, fonts, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Created attachment 1625570 [details] license list
Spec URL: https://raw.githubusercontent.com/RussianFedora/doublecmd/master/doublecmd.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1552/38301552/doublecmd-0.9.6-2.fc32.src.rpm 1. Source0 corrected. 2. Directories owning corrected. 3. Using macro corrected. 4. It is fpc generated code, already stripped. 5. Licenses added.
1. Linter still warning about unowned dirs. We probably need to move this Requires from main package to 'common'? %package common Summary: Common files for Double Commander Requires: hicolor-icon-theme Requires: polkit%{?_isa} 2. Source0: http://sourceforge.net/projects/%{name}/files/Double%20Commander%20Source/%{name}-%{version}-src.tar.gz -> Source0: https://sourceforge.net/projects/%{name}/files/Double%20Commander%20Source/%{name}-%{version}-src.tar.gz Probably better switch to https. But overall LGTM. This minor issues could be fixed during import. --- [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/polkit-1, /usr/lib/.build-id/6a, /usr/share/polkit-1/actions, /usr/share/icons/hicolor, /usr/share/icons/hicolor/scalable/apps, /usr/lib/.build-id/12, /usr/share/icons/hicolor/scalable
Well, there is DoubleCmd availabl in Copr and you could learn a few tricks from it: https://copr-dist-git.fedorainfracloud.org/cgit/vondruch/doublecmd/doublecmd-gtk.git/tree/doublecmd-gtk.spec E.g. I believe you package does not ship proper debug info (although I did not investigated it). Also, I never bothered to get DoubleCmd into Fedora, mainly because it bundles quite some library. What is the status here? At least, it seems that your license tag is more complex due to this, but it does not bother to list which license belongs where.
Vit, thanks. Can you show your tricks as pull-request when code will be added to https://src.fedoraproject.org ? I am fully disable debug. I don't think any user will need that :)
> mainly because it bundles quite some library. This eased now a little bit in Fedora, except for cryptographic libraries and other security critical components.
(In reply to Vasiliy Glazov from comment #8) > Vit, thanks. > > Can you show your tricks as pull-request when code will be added to > https://src.fedoraproject.org ? > > I am fully disable debug. I don't think any user will need that :) ABRT needs them for example. (In reply to Artem from comment #9) > > mainly because it bundles quite some library. > > This eased now a little bit in Fedora, except for cryptographic libraries > and other security critical components. Yes, it eased a bit, but still, the "bundled" requires are mandatory if I am not mistaken: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling
(In reply to Vít Ondruch from comment #7) > it seems that your license tag is more complex due to this, but it does not bother to list > which license belongs where. https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios ~~~ In addition, the package must contain a comment explaining the multiple licensing breakdown. The actual implementation of this is left to the maintainer. ~~~
> Yes, it eased a bit, but still, the "bundled" requires are mandatory if I am not mistaken: Oh, also need to list all of bundled components. For example: Provides: bundled() = 1.0.0~beta
(In reply to Artem from comment #12) > > Yes, it eased a bit, but still, the "bundled" requires are mandatory if I am not mistaken: > > Oh, also need to list all of bundled components. For example: > > Provides: bundled() = 1.0.0~beta ^^^^^^^^^ There should be mentioned what is bundled. E.g. `bundled(CmdLine) = 6.0.1` etc. If there was provided more info in comments where the upstream of this component lives etc, it would be even more valuable. Besides that, I typically add tests to check if the version is still correct, e.g.: https://src.fedoraproject.org/rpms/ruby/blob/private-ruby-2.7/f/ruby.spec#_797
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/doublecmd
What if I add licensecheck file to package and comment about it to spec instead list all files for all licenses?
Review closed. All work now in https://src.fedoraproject.org/rpms/doublecmd Vit, if you want I will be happy to add you as comaintainer.
(In reply to Vasiliy Glazov from comment #15) > What if I add licensecheck file to package and comment about it to spec > instead list all files for all licenses? Not sure what is "licensecheck file", but typically it is enough to have list like: ~~~ # LGPL and GPL: components/CmdLine/* # GPLv2+: components/KASToolBar/* ~~~ So it should not be that long. (In reply to Vasiliy Glazov from comment #16) > Vit, if you want I will be happy to add you as comaintainer. Thx. Not sure if I will have the cycles, because my Copr repo is now mostly maintained by Marcin (szpak), he might be interested
The COPR repo is automatically (weekly) updated with SVN builds (due to very rare releases of DoubleCmd in the past) and I will keep it to follow the development - https://github.com/szpak/doublecmd-rpm As we may hit the same issues (or precisely I might hit them earlier :) ), so you can add me as a co-maintainer to make it easier to exchange patches. However, I assume you will be the main person behind a stable DoubleCmd in Fedora with me as a support. I'm glad (finally) seeing it in Fedora (officially)! (especially just a few days after the initial review request :) ) P.S. Vasiliy in the meantime you might want to create a PR in https://github.com/szpak/doublecmd-rpm to adjust Vit's/my .spec file to the new official one :).