Description of problem: $ fedpkg override create --duration=31 python-pytest-steps-1.6.2-1.fc31 Expiration date may not be longer than 31 Could not execute create_buildroot_override: Cannot create override. Rounding error? Version-Release number of selected component (if applicable): fedpkg-1.37-5.el8.1.noarch How reproducible: The first time I have seen this. Creating the update with --duration=30 works.
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle. Changing version to 32.
Hello, I believe that the functionality is placed in another component - bodhi-client or bodhi server. Fedpkg calls a method in bodhi-client with the duration argument and doesn't work with it directly. ~~~~~ fedpkg/__init__.py: override = bodhi.save_override(nvr=build, duration=duration, notes=notes) ~~~~~ So changing component field and hope the record will end in the right hands.
Yes, this is set in bodhi. The default is: 'buildroot_limit': { 'value': 31, Do you think we should change it to something else? 30 days is already really long...
I opened the bug because of the error message is inconsistent with the rule enforced by the code: 31 is not "longer than 31". As to the question about what lengths make sense: I think long overrides are useful. Sometimes it's not clear when the build in the override will go stable. For example, if I build an override before beta freeze, it might very likely be needed over that initial period before the freeze and the three weeks of freeze. ~4 weeks gives a reasonable chance of the override staying in place for the whole time. I normally create overrides with the maximum allowed length because it's hard to say a priori how long they will be needed, and it'd be a hassle to have the override expire prematurely and have to redo builds.
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4) > I opened the bug because of the error message is inconsistent with the rule > enforced by the code: > 31 is not "longer than 31". The code is: days = config.get('buildroot_limit') limit = now + timedelta(days=days) if expiration_date > limit: request.errors.add('body', 'expiration_date', 'Expiration date may not be longer than %i' % days) return But can you file that in upstream github.com/fedora-infra/bodhi ? > > As to the question about what lengths make sense: I think long overrides are > useful. > Sometimes it's not clear when the build in the override will go stable. For > example, > if I build an override before beta freeze, it might very likely be needed > over that > initial period before the freeze and the three weeks of freeze. ~4 weeks > gives a > reasonable chance of the override staying in place for the whole time. > > I normally create overrides with the maximum allowed length because it's > hard to say > a priori how long they will be needed, and it'd be a hassle to have the > override > expire prematurely and have to redo builds. ok, fair enough.
https://github.com/fedora-infra/bodhi/issues/4182
This message is a reminder that Fedora 32 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 32 on 2021-05-25. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '32'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 32 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 32 changed to end-of-life (EOL) status on 2021-05-25. Fedora 32 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.