Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01063098-vim-nerdtree-git-plugin/vim-nerdtree-git-plugin.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01063098-vim-nerdtree-git-plugin/vim-nerdtree-git-plugin-0-1.20190613git0501cdf.fc31.src.rpm Description: A plugin of NERDTree showing git status flags. Works with the LATEST version of NERDTree. Fedora Account System Username: atim
- The license is not VIM, but WTFPL https://github.com/Xuyuanp/nerdtree-git-plugin/blob/master/LICENSE - Please install this license file with %license in %files . Use commit f522a091e2838812d2669c331d7e9c283db6d54d Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* do What The Fuck you want to Public License (v2)". 1 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/vim-nerdtree-git- plugin/review-vim-nerdtree-git-plugin/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vim-nerdtree-git-plugin-0-1.20190613git0501cdf.fc32.noarch.rpm vim-nerdtree-git-plugin-0-1.20190613git0501cdf.fc32.src.rpm vim-nerdtree-git-plugin.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
Fixes license. There was no license file when i did first build. Thank you for review! https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-rawhide-x86_64/01125836-vim-nerdtree-git-plugin/vim-nerdtree-git-plugin.spec https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-rawhide-x86_64/01125836-vim-nerdtree-git-plugin/vim-nerdtree-git-plugin-0-1.20191024gitf522a09.fc32.src.rpm
Fixes -> Fixed
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vim-nerdtree-git-plugin
FEDORA-2019-c3747cc524 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c3747cc524
FEDORA-2019-9b9bde88d6 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-9b9bde88d6
FEDORA-2019-2f0714cf00 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-2f0714cf00
FEDORA-EPEL-2019-c156cfb67a has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-c156cfb67a
FEDORA-EPEL-2019-925e1ca29f has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-925e1ca29f
vim-nerdtree-git-plugin-0-1.20191024gitf522a09.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-9b9bde88d6
vim-devicons-0.11.0-1.20191110gite3e6aa1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-2f0714cf00
vim-nerdtree-git-plugin-0-1.20191024gitf522a09.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c3747cc524
vim-nerdtree-git-plugin-0-1.20191024gitf522a09.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-c156cfb67a
vim-devicons-0.11.0-1.20191110gite3e6aa1.el8 has been pushed to the Fedora EPEL 8 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-925e1ca29f
vim-nerdtree-git-plugin-0-1.20191024gitf522a09.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
vim-nerdtree-git-plugin-0-1.20191024gitf522a09.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
vim-devicons-0.11.0-1.20191110gite3e6aa1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.
vim-nerdtree-git-plugin-0-1.20191024gitf522a09.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.
vim-devicons-0.11.0-1.20191110gite3e6aa1.el8 has been pushed to the Fedora EPEL 8 stable repository. If problems still persist, please make note of it in this bug report.