Spec URL: https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01063633-vim-devicons/vim-devicons.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01063633-vim-devicons/vim-devicons-0.11.0-1.20190923gitfae1550.fc31.src.rpm Description: Supports plugins such as NERDTree, vim-airline, CtrlP, powerline, denite, unite, lightline.vim, vim-startify, vimfiler, vim-buffet and flagship. Features: - Adds filetype glyphs (icons) to various vim plugins. - Customizable and extendable glyphs settings. - Supports a wide range of file type extensions. - Supports popular full filenames, like .gitignore, node_modules, .vimrc, and many more. - Supports byte order marker (BOM). - Works with patched fonts, especially Nerd Fonts. Fedora Account System Username: atim
- Own these directories: [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/vim/vimfiles/pythonx, /usr/share/vim/vimfiles/rplugin Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 22 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/vim-devicons/review-vim- devicons/licensecheck.txt [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/vim/vimfiles/pythonx, /usr/share/vim/vimfiles/rplugin [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/vim/vimfiles/autoload/airline(vim-airline), /usr/share/vim/vimfiles/autoload/airline/extensions(vim-airline), /usr/share/vim/vimfiles/autoload/airline/extensions/tabline(vim- airline), /usr/share/vim/vimfiles/autoload/airline/extensions/tabline/formatters(vim- airline), /usr/share/vim/vimfiles/rplugin/python3(vim-go), /usr/share/vim/vimfiles/rplugin/python3/denite(vim-go) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: vim-devicons-0.11.0-1.20190923gitfae1550.fc32.noarch.rpm vim-devicons-0.11.0-1.20190923gitfae1550.fc32.src.rpm vim-devicons.noarch: W: spelling-error %description -l en_US lightline -> light line, light-line, nightlight vim-devicons.noarch: W: spelling-error %description -l en_US startify -> stratify, artistry vim-devicons.noarch: W: spelling-error %description -l en_US filetype -> file type, file-type, teletype vim-devicons.noarch: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments vim-devicons.noarch: W: spelling-error %description -l en_US gitignore -> git ignore, git-ignore, ignore vim-devicons.noarch: W: spelling-error %description -l en_US vimrc -> victim vim-devicons.src: W: spelling-error %description -l en_US powerline -> power line, power-line, PowerPoint vim-devicons.src: W: spelling-error %description -l en_US denite -> denote, dendrite, definite vim-devicons.src: W: spelling-error %description -l en_US lightline -> light line, light-line, nightlight vim-devicons.src: W: spelling-error %description -l en_US startify -> stratify, artistry vim-devicons.src: W: spelling-error %description -l en_US vimfiler -> vim filer, vim-filer, reviler vim-devicons.src: W: spelling-error %description -l en_US filetype -> file type, file-type, teletype vim-devicons.src: W: spelling-error %description -l en_US filenames -> file names, file-names, filaments vim-devicons.src: W: spelling-error %description -l en_US gitignore -> git ignore, git-ignore, ignore vim-devicons.src: W: spelling-error %description -l en_US vimrc -> victim vim-devicons.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 16 warnings.
https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01125841-vim-devicons/vim-devicons.spec https://copr-be.cloud.fedoraproject.org/results/atim/vim-airline/fedora-31-x86_64/01125841-vim-devicons/vim-devicons-0.11.0-1.20191110gite3e6aa1.fc31.src.rpm
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/vim-devicons
FEDORA-2019-942c3567ed has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2019-942c3567ed
vim-devicons-0.11.0-1.20191110gite3e6aa1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-942c3567ed
vim-devicons-0.11.0-1.20191110gite3e6aa1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.