Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-nickel.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-nickel-0.11.0-1.fc32.src.rpm Description: Express.js inspired web framework. Fedora Account System Username: eclipseo
Fix description, please.
New Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-nickel.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-nickel-0.11.0-1.fc32.src.rpm
I can take this review. I would appreciate it very much if you can take bug 1783432 in exchange.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Make the bug summary match the spec file Summary field. - Only the rust-nickel-devel and rust-nickel+default-devel packages can be installed. The other two (rust-nickel+compiletest_rs-devel and rust-nickel+unstable-devel) cannot. Attempting to install them leads to this: Error: Problem 1: conflicting requests - nothing provides (crate(compiletest_rs/default) >= 0.3.0 with crate(compiletest_rs/default) < 0.4.0) needed by rust-nickel+compiletest_rs-devel-0.11.0-1.fc32.noarch Problem 2: conflicting requests - nothing provides (crate(compiletest_rs/default) >= 0.3.0 with crate(compiletest_rs/default) < 0.4.0) needed by rust-nickel+unstable-devel-0.11.0-1.fc32.noarch (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages) - All 4 packages contain this file: /usr/share/cargo/registry/nickel-0.11.0/Cargo.toml That is the only file in the 3 packages other than rust-nickel-devel. - Some tests fail, but %check does not fail the build. Examples: running 75 tests error: no matching package named `compiletest_rs` found location searched: registry `https://github.com/rust-lang/crates.io-index` required by package `nickel v0.11.0 (/builddir/build/BUILD/nickel-0.11.0)` test examples::chaining::expect_200::patch ... FAILED$<2> test examples::chaining::expect_200::delete ... FAILED$<2> test examples::chaining::expect_200::put ... FAILED$<2> test examples::chaining::expect_404::get ... FAILED$<2> test examples::chaining::expect_200::post ... FAILED$<2> test examples::chaining::expect_200::root ... FAILED$<2> test examples::chaining::expect_200::get ... FAILED$<2> test examples::chaining::expect_404::patch ... FAILED$<2> test examples::chaining::expect_404::post ... FAILED$<2> test examples::chaining::expect_404::put ... FAILED$<2> test examples::chaining::expect_404::root ... FAILED$<2> test examples::chaining::expect_404::delete ... FAILED$<2> error: no matching package named `compiletest_rs` found location searched: registry `https://github.com/rust-lang/crates.io-index` required by package `nickel v0.11.0 (/builddir/build/BUILD/nickel-0.11.0)` test examples::custom_error_handler::accepts_some_inputs ... FAILED$<2> test examples::custom_error_handler::has_custom_message_for_fallthrough ... FAILED$<2> test examples::custom_error_handler::has_custom_message_for_custom_error ... FAILED$<2> ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. See above for requires that cannot be satisfied. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 34 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). See above for requires that cannot be satisfied. [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- nickel-devel , rust-nickel+default-devel , rust-nickel+compiletest_rs- devel , rust-nickel+unstable-devel None of the packages have such a dependency. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. Tests are failing, but %check still succeeds anyway. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Not all packages could be installed. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.21 starting (python version = 3.7.5)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.21 INFO: Mock Version: 1.4.21 Finish: chroot init INFO: installing package(s): /home/jamesjer/1763457-rust-nickel/results/rust-nickel+default-devel-0.11.0-1.fc32.noarch.rpm /home/jamesjer/1763457-rust-nickel/results/rust-nickel-devel-0.11.0-1.fc32.noarch.rpm /home/jamesjer/1763457-rust-nickel/results/rust-nickel+unstable-devel-0.11.0-1.fc32.noarch.rpm /home/jamesjer/1763457-rust-nickel/results/rust-nickel+compiletest_rs-devel-0.11.0-1.fc32.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 32 --enablerepo local --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/jamesjer/1763457-rust-nickel/results/rust-nickel+default-devel-0.11.0-1.fc32.noarch.rpm /home/jamesjer/1763457-rust-nickel/results/rust-nickel-devel-0.11.0-1.fc32.noarch.rpm /home/jamesjer/1763457-rust-nickel/results/rust-nickel+unstable-devel-0.11.0-1.fc32.noarch.rpm /home/jamesjer/1763457-rust-nickel/results/rust-nickel+compiletest_rs-devel-0.11.0-1.fc32.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: rust-nickel-devel-0.11.0-1.fc32.noarch.rpm rust-nickel+default-devel-0.11.0-1.fc32.noarch.rpm rust-nickel+compiletest_rs-devel-0.11.0-1.fc32.noarch.rpm rust-nickel+unstable-devel-0.11.0-1.fc32.noarch.rpm rust-nickel-0.11.0-1.fc32.src.rpm rust-nickel-devel.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j rust-nickel-devel.noarch: W: spelling-error %description -l en_US js -> dis, ks, j rust-nickel-devel.noarch: W: invalid-url URL: https://crates.io/crates/nickel HTTP Error 404: Not Found rust-nickel-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/nickel-0.11.0/.cargo-checksum.json rust-nickel-devel.noarch: E: zero-length /usr/share/cargo/registry/nickel-0.11.0/examples/assets/test.txt rust-nickel-devel.noarch: E: zero-length /usr/share/doc/rust-nickel-devel/examples/assets/test.txt rust-nickel+default-devel.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j rust-nickel+default-devel.noarch: W: spelling-error %description -l en_US js -> dis, ks, j rust-nickel+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/nickel HTTP Error 404: Not Found rust-nickel+default-devel.noarch: W: no-documentation rust-nickel+compiletest_rs-devel.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j rust-nickel+compiletest_rs-devel.noarch: W: spelling-error %description -l en_US js -> dis, ks, j rust-nickel+compiletest_rs-devel.noarch: W: spelling-error %description -l en_US compiletest -> completest, compile test, compile-test rust-nickel+compiletest_rs-devel.noarch: W: invalid-url URL: https://crates.io/crates/nickel HTTP Error 404: Not Found rust-nickel+compiletest_rs-devel.noarch: W: no-documentation rust-nickel+unstable-devel.noarch: W: spelling-error Summary(en_US) js -> dis, ks, j rust-nickel+unstable-devel.noarch: W: spelling-error %description -l en_US js -> dis, ks, j rust-nickel+unstable-devel.noarch: W: invalid-url URL: https://crates.io/crates/nickel HTTP Error 404: Not Found rust-nickel+unstable-devel.noarch: W: no-documentation rust-nickel.src: W: spelling-error Summary(en_US) js -> dis, ks, j rust-nickel.src: W: spelling-error %description -l en_US js -> dis, ks, j rust-nickel.src: W: invalid-url URL: https://crates.io/crates/nickel HTTP Error 404: Not Found 5 packages and 0 specfiles checked; 2 errors, 20 warnings. Source checksums ---------------- https://crates.io/api/v1/crates/nickel/0.11.0/download#/nickel-0.11.0.crate : CHECKSUM(SHA256) this package : e5061a832728db2dacb61cefe0ce303b58f85764ec680e71d9138229640a46d9 CHECKSUM(SHA256) upstream package : e5061a832728db2dacb61cefe0ce303b58f85764ec680e71d9138229640a46d9 Requires -------- rust-nickel-devel (rpmlib, GLIBC filtered): (crate(groupable/default) >= 0.2.0 with crate(groupable/default) < 0.3.0) (crate(hyper) >= 0.10.0 with crate(hyper) < 0.11.0) (crate(lazy_static/default) >= 1.0.0 with crate(lazy_static/default) < 2.0.0) (crate(log/default) >= 0.3.0 with crate(log/default) < 0.4.0) (crate(modifier/default) >= 0.1.0 with crate(modifier/default) < 0.2.0) (crate(mustache/default) >= 0.9.0 with crate(mustache/default) < 0.10.0) (crate(plugin/default) >= 0.2.0 with crate(plugin/default) < 0.3.0) (crate(regex/default) >= 1.0.0 with crate(regex/default) < 2.0.0) (crate(serde/default) >= 1.0.0 with crate(serde/default) < 2.0.0) (crate(serde_json/default) >= 1.0.0 with crate(serde_json/default) < 2.0.0) (crate(time/default) >= 0.1.0 with crate(time/default) < 0.2.0) (crate(typemap/default) >= 0.3.0 with crate(typemap/default) < 0.4.0) (crate(url/default) >= 1.0.0 with crate(url/default) < 2.0.0) cargo rust-nickel+default-devel (rpmlib, GLIBC filtered): cargo crate(nickel) rust-nickel+compiletest_rs-devel (rpmlib, GLIBC filtered): (crate(compiletest_rs/default) >= 0.3.0 with crate(compiletest_rs/default) < 0.4.0) cargo crate(nickel) rust-nickel+unstable-devel (rpmlib, GLIBC filtered): (crate(compiletest_rs/default) >= 0.3.0 with crate(compiletest_rs/default) < 0.4.0) (crate(hyper/nightly) >= 0.10.0 with crate(hyper/nightly) < 0.11.0) cargo crate(nickel) Provides -------- rust-nickel-devel: crate(nickel) rust-nickel-devel rust-nickel+default-devel: crate(nickel/default) rust-nickel+default-devel rust-nickel+compiletest_rs-devel: crate(nickel/compiletest_rs) rust-nickel+compiletest_rs-devel rust-nickel+unstable-devel: crate(nickel/unstable) rust-nickel+unstable-devel Generated by fedora-review 0.7.3 (44b83c7) last change: 2019-09-18 Command line :/usr/bin/fedora-review -b 1763457 -m fedora-rawhide-x86_64 -o --enablerepo=local --no-bootstrap-chroot --no-cleanup-after --no-clean Buildroot used: fedora-rawhide-{{ target_arch }} Active plugins: Generic, Shell-api Disabled plugins: Perl, PHP, Haskell, Java, Ruby, Ocaml, C/C++, SugarActivity, fonts, R, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Jerry James from comment #4) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > Issues: > ======= > - Make the bug summary match the spec file Summary field. > Done > - Only the rust-nickel-devel and rust-nickel+default-devel packages can be > installed. The other two (rust-nickel+compiletest_rs-devel and > rust-nickel+unstable-devel) cannot. Attempting to install them leads to > this: > > Error: > Problem 1: conflicting requests > - nothing provides (crate(compiletest_rs/default) >= 0.3.0 with > crate(compiletest_rs/default) < 0.4.0) needed by > rust-nickel+compiletest_rs-devel-0.11.0-1.fc32.noarch > Problem 2: conflicting requests > - nothing provides (crate(compiletest_rs/default) >= 0.3.0 with > crate(compiletest_rs/default) < 0.4.0) needed by > rust-nickel+unstable-devel-0.11.0-1.fc32.noarch > (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to > use not only best candidate packages) > > - All 4 packages contain this file: > > /usr/share/cargo/registry/nickel-0.11.0/Cargo.toml > > That is the only file in the 3 packages other than rust-nickel-devel. This is normal. These are optional packages for the optional dependencies. If the Rust SIG need them for another package, they will then be packaged. In the Cargo.toml, this is defined as follow: [dependencies.compiletest_rs] version = "0.3" optional = true > > - Some tests fail, but %check does not fail the build. Examples: > > running 75 tests > error: no matching package named `compiletest_rs` found > location searched: registry `https://github.com/rust-lang/crates.io-index` > required by package `nickel v0.11.0 (/builddir/build/BUILD/nickel-0.11.0)` > test examples::chaining::expect_200::patch ... FAILED$<2> > test examples::chaining::expect_200::delete ... FAILED$<2> > test examples::chaining::expect_200::put ... FAILED$<2> > test examples::chaining::expect_404::get ... FAILED$<2> > test examples::chaining::expect_200::post ... FAILED$<2> > test examples::chaining::expect_200::root ... FAILED$<2> > test examples::chaining::expect_200::get ... FAILED$<2> > test examples::chaining::expect_404::patch ... FAILED$<2> > test examples::chaining::expect_404::post ... FAILED$<2> > test examples::chaining::expect_404::put ... FAILED$<2> > test examples::chaining::expect_404::root ... FAILED$<2> > test examples::chaining::expect_404::delete ... FAILED$<2> > error: no matching package named `compiletest_rs` found > location searched: registry `https://github.com/rust-lang/crates.io-index` > required by package `nickel v0.11.0 (/builddir/build/BUILD/nickel-0.11.0)` > test examples::custom_error_handler::accepts_some_inputs ... FAILED$<2> > test examples::custom_error_handler::has_custom_message_for_fallthrough ... > FAILED$<2> > test examples::custom_error_handler::has_custom_message_for_custom_error ... > FAILED$<2> > > Same they need compiletest_rs. I have packaged it and made the tests run: https://copr.fedorainfracloud.org/coprs/build/1129155
Everything looks good now. This package is APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nickel
Thanks for the review!